openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
722 stars 38 forks source link

[PRE REVIEW]: TDAvec: Computing Vector Summaries of Persistence Diagrams for Topological Data Analysis in R and Python #7262

Closed editorialbot closed 1 month ago

editorialbot commented 1 month ago

Submitting author: !--author-handle-->@ALuchinsky<!--end-author-handle-- (Alexey Luchinsky) Repository: https://github.com/ALuchinsky/tdavec Branch with paper.md (empty if default branch): Version: v1.0.0 Editor: Pending Reviewers: Pending Managing EiC: Chris Vernon

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/ab5d200fd50bb4d52dfb0cbf6567aa88"><img src="https://joss.theoj.org/papers/ab5d200fd50bb4d52dfb0cbf6567aa88/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/ab5d200fd50bb4d52dfb0cbf6567aa88/status.svg)](https://joss.theoj.org/papers/ab5d200fd50bb4d52dfb0cbf6567aa88)

Author instructions

Thanks for submitting your paper to JOSS @ALuchinsky. Currently, there isn't a JOSS editor assigned to your paper.

@ALuchinsky if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 1 month ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 1 month ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.02 s (1310.5 files/s, 201948.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
HTML                             1             36              2            620
CSV                              2              0              0            601
C++                              9             56             21            481
Markdown                         5            138              0            479
TeX                              1             32              0            282
Python                           4             62             17            271
Cython                           1             64            167            172
Rmd                              2             76            142            128
Jupyter Notebook                 2              0            495            105
R                                2             31             43             98
TOML                             1              1              0              3
-------------------------------------------------------------------------------
SUM:                            30            496            887           3240
-------------------------------------------------------------------------------

Commit count by author:

    32  Aleksei Luchinskii
     3  Luchinsky
editorialbot commented 1 month ago

Paper file info:

📄 Wordcount for paper.md is 3127

✅ The paper includes a Statement of need section

editorialbot commented 1 month ago

License info:

🔴 Failed to discover a valid open source license

editorialbot commented 1 month ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1145/2582112.2582128 is OK
- 10.1090/S0273-0979-09-01249-X is OK
- 10.1007/s10444-021-09893-4 is OK
- 10.3389/frai.2021.667963 is OK
- 10.3389/frai.2021.681108 is OK
- 10.32614/CRAN.package.TDAvec is OK
- 10.32614/CRAN.package.TDA is OK
- 10.21105/joss.00860 is OK
- 10.32614/cran.package.tdakit is OK
- 10.32614/CRAN.package.tdaunif is OK
- 10.32614/cran.package.tdapplied is OK
- 10.32614/CRAN.package.ripserr is OK
- 10.1016/j.patcog.2020.107509 is OK
- 10.1016/j.patrec.2014.07.001 is OK
- 10.1007/978-3-642-40193-0_6 is OK
- 10.1007/s41468-021-00071-5 is OK
- 10.32614/CRAN.package.Rcpp is OK
- 10.5281/zenodo.2533369 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Statistical topological data analysis using persis...
- No DOI given, and none found for title: Persistence images: A stable vector representation...
- No DOI given, and none found for title: kernelTDA: Statistical Learning with Kernel for Pe...
- No DOI given, and none found for title: TDAmapper: Topological Data Analysis using Mapper
- No DOI given, and none found for title: A computationally efficient framework for vector r...
- No DOI given, and none found for title: ggplot2: Elegant Graphics for Data Analysis
- No DOI given, and none found for title: Awesome-TDA
- No DOI given, and none found for title: giotto-tda:: A topological data analysis toolkit f...
- No DOI given, and none found for title: A lean persistent homology library for python
- No DOI given, and none found for title: GUDHI User and Reference Manual
- No DOI given, and none found for title: Dionysus 2 – library for computing persistent homo...
- No DOI given, and none found for title: Persim 0.3.7
- No DOI given, and none found for title: Python interface to TDAvec library

❌ MISSING DOIs

- 10.1007/978-3-540-33259-6_7 may be a valid DOI for title: Computational topology: an introduction
- 10.21105/joss.01315 may be a valid DOI for title: Kepler Mapper: A flexible Python implementation of...

❌ INVALID DOIs

- None
editorialbot commented 1 month ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 1 month ago

Five most similar historical JOSS papers:

TDApplied: An R package for machine learning and inference with persistence diagrams Submitting author: @shaelebrown Handling editor: @mahfuz05062 (Active) Reviewers: @EduPH, @peekxc Similarity score: 0.7560

TDAstats: R pipeline for computing persistent homology in topological data analysis Submitting author: @rrrlw Handling editor: @leeper (Retired) Reviewers: @corybrunson Similarity score: 0.7534

Ripserer.jl: flexible and efficient persistent homology computation in Julia Submitting author: @mtsch Handling editor: @VivianePons (Retired) Reviewers: @juliohm, @sauln Similarity score: 0.7081

giotto-deep: A Python Package for Topological Deep Learning Submitting author: @matteocao Handling editor: @osorensen (Active) Reviewers: @EduPH, @leotrs, @ismailguzel Similarity score: 0.6846

TLViz: Visualising and analysing tensor decomposition models with Python Submitting author: @marieroald Handling editor: @faroit (Active) Reviewers: @sara-02, @yiitozer Similarity score: 0.6751

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

ALuchinsky commented 1 month ago

@editorialbot commands

editorialbot commented 1 month ago

Hello @ALuchinsky, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for branch
@editorialbot set joss-paper as branch

# Run checks and provide information on the repository and the paper file
@editorialbot check repository

# Check the references of the paper for missing DOIs
@editorialbot check references

# Generates the pdf paper
@editorialbot generate pdf

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Get a link to the complete list of reviewers
@editorialbot list reviewers
ALuchinsky commented 1 month ago

@editorialbot check references

editorialbot commented 1 month ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1145/2582112.2582128 is OK
- 10.1090/S0273-0979-09-01249-X is OK
- 10.1007/s10444-021-09893-4 is OK
- 10.3389/frai.2021.667963 is OK
- 10.3389/frai.2021.681108 is OK
- 10.32614/CRAN.package.TDAvec is OK
- 10.32614/CRAN.package.TDA is OK
- 10.21105/joss.00860 is OK
- 10.32614/cran.package.tdakit is OK
- 10.32614/CRAN.package.tdaunif is OK
- 10.32614/cran.package.tdapplied is OK
- 10.32614/CRAN.package.ripserr is OK
- 10.1016/j.patcog.2020.107509 is OK
- 10.1016/j.patrec.2014.07.001 is OK
- 10.1007/978-3-642-40193-0_6 is OK
- 10.1007/s41468-021-00071-5 is OK
- 10.32614/CRAN.package.Rcpp is OK
- 10.5281/zenodo.2533369 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Statistical topological data analysis using persis...
- No DOI given, and none found for title: Persistence images: A stable vector representation...
- No DOI given, and none found for title: kernelTDA: Statistical Learning with Kernel for Pe...
- No DOI given, and none found for title: TDAmapper: Topological Data Analysis using Mapper
- No DOI given, and none found for title: A computationally efficient framework for vector r...
- No DOI given, and none found for title: ggplot2: Elegant Graphics for Data Analysis
- No DOI given, and none found for title: Awesome-TDA
- No DOI given, and none found for title: giotto-tda:: A topological data analysis toolkit f...
- No DOI given, and none found for title: A lean persistent homology library for python
- No DOI given, and none found for title: GUDHI User and Reference Manual
- No DOI given, and none found for title: Dionysus 2 – library for computing persistent homo...
- No DOI given, and none found for title: Persim 0.3.7
- No DOI given, and none found for title: Python interface to TDAvec library

❌ MISSING DOIs

- 10.1007/978-3-540-33259-6_7 may be a valid DOI for title: Computational topology: an introduction
- 10.21105/joss.01315 may be a valid DOI for title: Kepler Mapper: A flexible Python implementation of...

❌ INVALID DOIs

- None
ALuchinsky commented 1 month ago

@editorialbot check references

editorialbot commented 1 month ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.48550/arXiv.1207.6437 is OK
- 10.1145/2582112.2582128 is OK
- 10.48550/arXiv.1507.06217 is OK
- 10.1090/S0273-0979-09-01249-X is OK
- 10.1007/s10444-021-09893-4 is OK
- 10.3389/frai.2021.667963 is OK
- 10.3389/frai.2021.681108 is OK
- 10.32614/CRAN.package.TDAvec is OK
- 10.32614/CRAN.package.TDA is OK
- 10.21105/joss.00860 is OK
- 10.32614/cran.package.tdakit is OK
- 10.32614/CRAN.package.tdaunif is OK
- 10.32614/cran.package.tdapplied is OK
- 10.32614/CRAN.package.ripserr is OK
- 10.1016/j.patcog.2020.107509 is OK
- 10.1016/j.patrec.2014.07.001 is OK
- 10.48550/arXiv.2109.08239 is OK
- 10.1007/978-3-642-40193-0_6 is OK
- 10.1007/s41468-021-00071-5 is OK
- 10.1007/978-3-319-24277-4 is OK
- 10.32614/CRAN.package.Rcpp is OK
- 10.21105/joss.01315 is OK
- 10.5281/zenodo.2533369 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: kernelTDA: Statistical Learning with Kernel for Pe...
- No DOI given, and none found for title: TDAmapper: Topological Data Analysis using Mapper
- No DOI given, and none found for title: Awesome-TDA
- No DOI given, and none found for title: giotto-tda:: A topological data analysis toolkit f...
- No DOI given, and none found for title: A lean persistent homology library for python
- No DOI given, and none found for title: GUDHI User and Reference Manual
- No DOI given, and none found for title: Dionysus 2 – library for computing persistent homo...
- No DOI given, and none found for title: Persim 0.3.7
- No DOI given, and none found for title: Python interface to TDAvec library

❌ MISSING DOIs

- 10.1007/978-3-540-33259-6_7 may be a valid DOI for title: Computational topology: an introduction

❌ INVALID DOIs

- None
crvernon commented 1 month ago

@editorialbot query scope

👋 @ALuchinsky - I am going to run this one by our larger editorial board due to it's smaller code base to ensure it meets our substantial scholarly effort requirement. This should take about two weeks at the most. I'll let you know what I hear back ASAP.

editorialbot commented 1 month ago

Submission flagged for editorial review.

crvernon commented 1 month ago

@editorialbot reject

:wave: @ALuchinsky - After reviewing this with our larger editorial board, we must reject this submission at this time due to it not meeting our substantial scholarly effort requirements partially due to the low lines of code count.

Best wishes for your future development activities and thanks for submitting to JOSS.

editorialbot commented 1 month ago

Paper rejected.