openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
722 stars 38 forks source link

[PRE REVIEW]: SAMPL: An agent-based model to evaluate spatial sampling strategies #7278

Open editorialbot opened 1 month ago

editorialbot commented 1 month ago

Submitting author: !--author-handle-->@ifoxfoot<!--end-author-handle-- (Iris Foxfoot) Repository: https://github.com/EcoModTeam/SAMPL Branch with paper.md (empty if default branch): Version: 1.0.0 Editor: Pending Reviewers: Pending Managing EiC: Kristen Thyng

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/dd72b944eeb3d50c50b798a84333d7e6"><img src="https://joss.theoj.org/papers/dd72b944eeb3d50c50b798a84333d7e6/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/dd72b944eeb3d50c50b798a84333d7e6/status.svg)](https://joss.theoj.org/papers/dd72b944eeb3d50c50b798a84333d7e6)

Author instructions

Thanks for submitting your paper to JOSS @ifoxfoot. Currently, there isn't a JOSS editor assigned to your paper.

@ifoxfoot if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 1 month ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 1 month ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

βœ… OK DOIs

- 10.1111/j.1600-0587.2010.06421.x is OK
- 10.1111/j.1365-2664.2008.01545.x is OK
- 10.1890/14-1826.1 is OK
- 10.1899/04-138.1 is OK
- 10.1007/s10750-019-04017-y is OK
- 10.1080/01621459.1990.10474975 is OK

🟑 SKIP DOIs

- No DOI given, and none found for title: ArcGIS Pro
- No DOI given, and none found for title: NetLogo

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None
editorialbot commented 1 month ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.01 s (627.6 files/s, 31881.5 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
TeX                              1              9              0            104
Markdown                         2             35              0             75
YAML                             1              1              4             25
CSV                              1              0              0              1
-------------------------------------------------------------------------------
SUM:                             5             45              4            205
-------------------------------------------------------------------------------

Commit count by author:

    22  ifoxfoot
     6  Iris Foxfoot
     1  Kiara Cushway
     1  TSwan
     1  cushkia1
editorialbot commented 1 month ago

Paper file info:

πŸ“„ Wordcount for paper.md is 843

βœ… The paper includes a Statement of need section

editorialbot commented 1 month ago

License info:

🟑 License found: GNU General Public License v3.0 (Check here for OSI approval)

editorialbot commented 1 month ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 1 month ago

Five most similar historical JOSS papers:

fishStan: Hierarchical Bayesian models for fisheries Submitting author: @rerickson-usgs Handling editor: @marcosvital (Active) Reviewers: @MikeKaller, @Cole-Monnahan-NOAA Similarity score: 0.7075

portalcasting: Supporting automated forecasting of rodent populations Submitting author: @gmyenni Handling editor: @marcosvital (Active) Reviewers: @ViniciusBRodrigues, @FlukeAndFeather Similarity score: 0.7006

Cacatoo: building, exploring, and sharing spatially structured models of biological systems Submitting author: @bramvandijk88 Handling editor: @Bisaloo (Retired) Reviewers: @emilydolson, @TimKam Similarity score: 0.6906

FielDHub: A Shiny App for Design of Experiments in Life Sciences Submitting author: @DidierMurilloF Handling editor: @csoneson (Active) Reviewers: @Prof-ThiagoOliveira, @dlebauer Similarity score: 0.6867

SSMSE: An R package for Management Strategy Evaluation with Stock Synthesis Operating Models Submitting author: @k-doering-NOAA Handling editor: @sbenthall (Active) Reviewers: @quang-huynh, @iagomosqueira Similarity score: 0.6866

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

kthyng commented 1 month ago

@ifoxfoot Hi! I don't see any code β€” where is your software repository?

ifoxfoot commented 1 month ago

@kthyng Hi! It is in the repository here https://github.com/EcoModTeam/SAMPL. The code is in the file called SAMPL.nlogo. Let me know if it's not showing up for you!

ifoxfoot commented 1 month ago

@kthyng re suggested reviewers. It looks like there is one published JOSS paper that is about a NetLogo model. I would recommend the authors of this paper https://joss.theoj.org/papers/10.21105/joss.05731 as reviewers.

kthyng commented 1 month ago

Hi @ifoxfoot and thanks for your submission! I am looking for some specific items to make sure your submission fits our requirements at a high level (not at the more detailed review level) before moving on to finding an editor or putting this on our waitlist if no relevant editors are available. I'll comment over time as I have a chance to go through them:

In the meantime, please take a look at the comments above ⬆️ from the editorialbot to address any DOI, license, or paper issues if you're able (there may not be any), or suggest reviewers. For reviewers, please suggest 5 reviewers from the database listed above or your own (non-conflicted) extended network. Their github handles are most useful to receive but please don't use "@" to reference them since it will prematurely ping them.

Ok this will be tricky to find reviewers for this sort of niche paper – please dig deep for more reviewer suggestions if you can!

kthyng commented 1 month ago

@ifoxfoot comments/questions:

ifoxfoot commented 1 month ago

hi @kthyng, thanks for the questions!

  1. If the user has NetLogo installed and they download our model or clone it from GitHub, it would look like this: image the info tab where the model documentation is located in is circled in red. Without downloading the file and opening it via NetLogo, viewing the user documentation is more tricky...but it can be seen on lines 1448-1530 of the SAMPL.nlogo file. I could also copy the documentation into a separate file if needed :)
  2. There aren't automated tests but, once the model is downloaded, the user will be able to see a graphical user interface. They can then visually check that what the model is showing matches the inputs.
  3. For reviewers, I'm reaching out to people who I think would be a good fit, but I don't have their GitHub user names yet. In the mean time I would suggest platipodium, Fabbiologia, nick-gauthier, and changliao1025 based off of previous JOSS authorship and reviews. Also agerada from the JOSS reviewer database. I also recommend jzkelter, nicolaspayette and bainco, based on their GitHub contribution history. Also I am familiar with the work of mwrossi who would be a great reviewer. I will add more soon, thanks!
kthyng commented 1 month ago

I'm going to ping the editorial board to take a look at this submission to see if it is in scope for JOSS in terms of substantial scholarly effort. This will take a few weeks β€” takes for your patience.

For reference, running cloc when it recognizes NetLogo gives this: image

kthyng commented 1 month ago

@editorialbot query scope

editorialbot commented 1 month ago

Submission flagged for editorial review.

ifoxfoot commented 1 month ago

@kthyng thanks! re substantial scholarly effort, commit history is rather lacking because the model was previously in a private repository on one of the author's profiles. We opted to make a fresh repository in a GitHub organization....so the early commits aren't shown.

ifoxfoot commented 3 weeks ago

@kthyng any updates on the editorial review? Thanks!

kthyng commented 2 weeks ago

@ifoxfoot Thank you for the ping, I will push on my end.

kthyng commented 1 week ago

@ifoxfoot Can you answer a couple of questions to help with this process?

ifoxfoot commented 1 week ago

Hi @kthyng yes!