[PRE REVIEW]: PySHbundle: A Python tool for processing GRACE Gravimetry data into Global Surface Mass Change Datasets

editorialbot commented 2 months ago

Submitting author: !--author-handle-->@lsmvivek@hugoledoux<!--end-editor-- Reviewers: Pending Managing EiC: Kristen Thyng

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/d623f63c03c6b54f9b6f4fa633747913"><img src="https://joss.theoj.org/papers/d623f63c03c6b54f9b6f4fa633747913/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/d623f63c03c6b54f9b6f4fa633747913/status.svg)](https://joss.theoj.org/papers/d623f63c03c6b54f9b6f4fa633747913)

Author instructions

Thanks for submitting your paper to JOSS @lsmvivek. Currently, there isn't a JOSS editor assigned to your paper.

@lsmvivek if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands

editorialbot commented 2 months ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

editorialbot commented 2 months ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.26 s (178.1 files/s, 80566.8 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          15            987           1572           1780
Jupyter Notebook                 5              0          14443            710
Markdown                        17            273              0            581
YAML                             5             13             10            280
TeX                              1             14              0             77
TOML                             1              5              0             48
HTML                             1              2              0              9
XML                              1              0              0              1
-------------------------------------------------------------------------------
SUM:                            46           1294          16025           3486
-------------------------------------------------------------------------------

Commit count by author:

   185  Abhishek Mhamane
   182  Amin Shakya
   158  lsmvivek
    44  mn5hk
    23  Vivek
     7  vivek
     3  Walling9
     1  Bramha Dutt Vishwakarma

editorialbot commented 2 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1007/s10712-022-09754-9 is OK
- 10.5281/zenodo.8075728 is OK
- 10.18419/opus-9193 is OK
- 10.1002/2017WR021150 is OK
- 10.1029/98JB02844 is OK
- 10.1029/2018GC007529 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: ggtools 1.1.7
- No DOI given, and none found for title: SHBUNDLE 2021
- No DOI given, and none found for title: GitHub - Strawpants/GRACE-filter: Contains softwar...

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

editorialbot commented 2 months ago

Paper file info:

📄 Wordcount for paper.md is 1164

✅ The paper includes a Statement of need section

editorialbot commented 2 months ago

License info:

🟡 License found: Other (Check here for OSI approval)

editorialbot commented 2 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 2 months ago

Five most similar historical JOSS papers:

Geodata-Harvester: A Python package to jumpstart geospatial data extraction and analysis Submitting author: @sebhaan Handling editor: @hugoledoux (Active) Reviewers: @lukasbeuster, @martibosch Similarity score: 0.6892

Tide Model Driver for MATLAB Submitting author: @chadagreene Handling editor: @kthyng (Active) Reviewers: @adamdanz, @lnferris Similarity score: 0.6866

PyGDH: Python Grid Discretization Helper Submitting author: @kfhiga Handling editor: @melissawm (Retired) Reviewers: @JamieJQuinn, @zhaowei0566 Similarity score: 0.6838

PySPOD: A Python package for Spectral Proper Orthogonal Decomposition (SPOD) Submitting author: @mengaldo Handling editor: @eloisabentivegna (Retired) Reviewers: @albertonogueira, @joao-l-s-almeida, @jdmoorman Similarity score: 0.6770

KerrGeoPy: A Python Package for Computing Timelike Geodesics in Kerr Spacetime Submitting author: @syp2001 Handling editor: @xuanxu (Active) Reviewers: @Uddiptaatwork, @sterinaldi Similarity score: 0.6752

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

kthyng commented 2 months ago

Hi @lsmvivek and thanks for your submission! I am looking for some specific items to make sure your submission fits our requirements at a high level (not at the more detailed review level) before moving on to finding an editor or putting this on our waitlist if no relevant editors are available. I'll comment over time as I have a chance to go through them:

[x] OSI-approved license
[x] Installation instructions
[x] Documentation exists at all
[x] Tests of some sort
[x] Check paper (make sure compiles, read through, check for length 250-1000 words)
[x] Substantial scholarly effort
[x] Clear research application

In the meantime, please take a look at the comments above ⬆️ from the editorialbot to address any DOI, license, or paper issues if you're able (there may not be any), or suggest reviewers. For reviewers, please suggest 5 reviewers from the database listed above or your own (non-conflicted) extended network. Their github handles are most useful to receive but please don't use "@" to reference them since it will prematurely ping them.

I know this is a resubmission — please note here any important items from previous submission we should know (here is a link to the last one https://github.com/openjournals/joss-reviews/issues/7183).

lsmvivek commented 2 months ago

Hi @lsmvivek and thanks for your submission! I am looking for some specific items to make sure your submission fits our requirements at a high level (not at the more detailed review level) before moving on to finding an editor or putting this on our waitlist if no relevant editors are available. I'll comment over time as I have a chance to go through them:

[ ] OSI-approved license

[ ] Installation instructions

[ ] Documentation exists at all

[ ] Tests of some sort

[ ] Check paper (make sure compiles, read through, check for length 250-1000 words)

[ ] Substantial scholarly effort

[ ] Clear research application

In the meantime, please take a look at the comments above ⬆️ from the editorialbot to address any DOI, license, or paper issues if you're able (there may not be any), or suggest reviewers. For reviewers, please suggest 5 reviewers from the database listed above or your own (non-conflicted) extended network. Their github handles are most useful to receive but please don't use "@" to reference them since it will prematurely ping them.

I know this is a resubmission — please note here any important items from previous submission we should know (here is a link to the last one #7183).

Hello @kthyng, Indeed this is a resubmission. I went through the reviewer database and I suggest the following 5 people based on their work profile. Please let me know if anything else is needed.

Geodesy:

busstoptaktik
leouieda
jiangyuinsar

Glaciers:

JordiBolibar
tgoelles

kthyng commented 1 month ago

@lsmvivek

docs don't seem to be working at https://mn5hk.github.io/pyshbundle/

lsmvivek commented 1 month ago

@lsmvivek

docs don't seem to be working at https://mn5hk.github.io/pyshbundle/

Please follow the updated link: https://gess-research-group.github.io/pyshbundle/

lsmvivek commented 1 month ago

Gentle reminder, Please follow the updated link: https://gess-research-group.github.io/pyshbundle/ @kthyng

kthyng commented 1 month ago

@lsmvivek Ok great. Sorry I have been traveling plus had a deadline. Now I am back. We have a backlog of submissions so I will add this to our waitlist. Thanks for your patience.

kthyng commented 1 month ago

@lsmvivek Did I already suggest giving a more descriptive title to this paper? It seems one already needs to know what this package does in order to know what the title means. I struggle with this whenever I try to search for an editor for the submission.

lsmvivek commented 1 month ago

@lsmvivek Did I already suggest giving a more descriptive title to this paper? It seems one already needs to know what this package does in order to know what the title means. I struggle with this whenever I try to search for an editor for the submission.

Dear @kthyng I have updated the paper title. It clearly states the objective of the software, data it works with and the expected output. I have also added more keywords (Geodesy, Gravimetry, Terrestrial Water Storage).

I thank you for suggestion, please let me know if any other changes are needed.

kthyng commented 1 month ago

@editorialbot generate pdf

editorialbot commented 1 month ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 1 month ago

Five most similar historical JOSS papers:

Geodata-Harvester: A Python package to jumpstart geospatial data extraction and analysis Submitting author: @sebhaan Handling editor: @hugoledoux (Active) Reviewers: @lukasbeuster, @martibosch Similarity score: 0.7021

Integrated hydrologic model development and postprocessing for GSFLOW using pyGSFLOW Submitting author: @jlarsen-usgs Handling editor: @crvernon (Active) Reviewers: @thurber, @mdbartos, @mdbartos Similarity score: 0.6950

baseflow: a MATLAB and GNU Octave package for baseflow recession analysis Submitting author: @mgcooper Handling editor: @elbeejay (Active) Reviewers: @alessandroamaranto, @tianydong Similarity score: 0.6921

HyRiver: Hydroclimate Data Retriever Submitting author: @cheginit Handling editor: @kthyng (Active) Reviewers: @raoulcollenteur, @arbennett Similarity score: 0.6910

Tide Model Driver for MATLAB Submitting author: @chadagreene Handling editor: @kthyng (Active) Reviewers: @adamdanz, @lnferris Similarity score: 0.6883

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

kthyng commented 1 month ago

@hugoledoux Can you edit this submission?

kthyng commented 1 month ago

@editorialbot invite @hugoledoux as editor

editorialbot commented 1 month ago

Invitation to edit this submission sent!

hugoledoux commented 4 weeks ago

@editorialbot assign @hugoledoux as editor

editorialbot commented 4 weeks ago

Assigned! @hugoledoux is now the editor

hugoledoux commented 8 hours ago

@MMesch would you be willing to review this submission? (I couldn't find an email and I tried hard; a few people said you'd be a great reviewer for this)

MMesch commented 8 hours ago

@hugoledoux Yes I would be willing to do this depending on exact criteria and timeline. I wrote you a DM on Mastodon for further contact details.

openjournals / joss-reviews

[PRE REVIEW]: PySHbundle: A Python tool for processing GRACE Gravimetry data into Global Surface Mass Change Datasets #7279

Status