search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
720 stars 38 forks source link

[PRE REVIEW]: pyOMA2: a Python module to conduct operational modal analysis #7293

Open editorialbot opened 3 weeks ago

editorialbot commented 3 weeks ago

Submitting author: !--author-handle-->@dagghe<!--end-author-handle-- (Dag) Repository: https://github.com/dagghe/pyOMA2 Branch with paper.md (empty if default branch): Joss Version: 1.0.0 Editor: !--editor-->@faroit<!--end-editor-- Reviewers: Pending Managing EiC: Kyle Niemeyer

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/fa5d6471041fe69b9b06b3fa252d4fe9"><img src="https://joss.theoj.org/papers/fa5d6471041fe69b9b06b3fa252d4fe9/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/fa5d6471041fe69b9b06b3fa252d4fe9/status.svg)](https://joss.theoj.org/papers/fa5d6471041fe69b9b06b3fa252d4fe9)

Author instructions

Thanks for submitting your paper to JOSS @dagghe. Currently, there isn't a JOSS editor assigned to your paper.

@dagghe if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 3 weeks ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 3 weeks ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.10 s (911.3 files/s, 184143.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          41           2054           5228           6760
Markdown                         7            194              0            520
reStructuredText                28            386            581            392
YAML                             5             26             45            191
TeX                              1             20              1            173
Jupyter Notebook                 4              0           1585            170
TOML                             1             19             19            103
INI                              1              7              0             36
DOS Batch                        1              8              1             26
make                             2             11              9             21
SVG                              1              0              1              3
-------------------------------------------------------------------------------
SUM:                            92           2725           7470           8395
-------------------------------------------------------------------------------

Commit count by author:

    70  Dag
    55  dagghe
    51  DiegoMargoni
    48  Diego Margoni
     3  Dag Pasca
     1  Alex Kaszynski
     1  marco-rosso-m
editorialbot commented 3 weeks ago

Paper file info:

📄 Wordcount for paper.md is 647

✅ The paper includes a Statement of need section

editorialbot commented 3 weeks ago

License info:

✅ License found: MIT License (Valid open source OSI approved license)

editorialbot commented 3 weeks ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- None

🟡 SKIP DOIs

- No DOI given, and none found for title: Subspace-based system identification and fault det...
- No DOI given, and none found for title: Modal identification of output-only systems using ...
- No DOI given, and none found for title: Damping estimation by frequency domain decompositi...
- No DOI given, and none found for title: Introduction to operational modal analysis
- No DOI given, and none found for title: Subspace identification for linear systems: Theory...
- No DOI given, and none found for title: Towards a Cloud-Based Platform for Structural Heal...

❌ MISSING DOIs

- 10.1016/j.jsv.2021.116207 may be a valid DOI for title: Robust multi-dataset identification with frequency...
- 10.1006/mssp.1999.1249 may be a valid DOI for title: Reference-based stochastic subspace identification...
- 10.1016/j.ymssp.2013.01.012 may be a valid DOI for title: Efficient multi-order uncertainty computation for ...
- 10.1155/2004/523692 may be a valid DOI for title: The PolyMAX frequency-domain method: a new standar...
- 10.1016/j.ymssp.2009.10.024 may be a valid DOI for title: A frequency–spatial domain decomposition (FSDD) me...
- 10.1007/978-1-4939-0767-0 may be a valid DOI for title: Operational modal analysis of civil engineering st...
- 10.1007/s11831-012-9069-x may be a valid DOI for title: System identification methods for (operational) mo...
- 10.1016/j.ymssp.2012.11.011 may be a valid DOI for title: Uncertainty quantification for modal parameters fr...
- 10.1016/j.conbuildmat.2020.121069 may be a valid DOI for title: Two-years static and dynamic monitoring of the san...
- 10.1016/j.engstruct.2020.110593 may be a valid DOI for title: Dynamic identification and model updating of an ei...
- 10.1016/j.jcsr.2023.107937 may be a valid DOI for title: Intensity and location of corrosion on the reliabi...
- 10.1177/10775463231213423 may be a valid DOI for title: Convolutional neural network–based structural heal...
- 10.1007/978-3-031-36663-5_5 may be a valid DOI for title: Examining Methods for Modeling Road Surface Roughn...
- 10.1016/j.istruc.2023.04.115 may be a valid DOI for title: Interoperability between BIM and FEM for vibration...

❌ INVALID DOIs

- None
editorialbot commented 3 weeks ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 3 weeks ago

Five most similar historical JOSS papers:

PySPOD: A Python package for Spectral Proper Orthogonal Decomposition (SPOD) Submitting author: @mengaldo Handling editor: @eloisabentivegna (Retired) Reviewers: @albertonogueira, @joao-l-s-almeida, @jdmoorman Similarity score: 0.6950

SHARPy: A dynamic aeroelastic simulation toolbox for very flexible aircraft and wind turbines Submitting author: @fonsocarre Handling editor: @labarba (Retired) Reviewers: @petebachant, @rafmudaf Similarity score: 0.6886

ViMag: A Visual Vibration Analysis Toolbox Submitting author: @RLado Handling editor: @Kevin-Mattheus-Moerman (Active) Reviewers: @jankoslavic, @iamtsac Similarity score: 0.6835

RECOLO: A Python package for the reconstruction of surface pressure loads from kinematic fields using the virtual fields method Submitting author: @PolymerGuy Handling editor: @Kevin-Mattheus-Moerman (Active) Reviewers: @nicoguaro, @corentin-dev Similarity score: 0.6785

AeroAcoustics.jl: A Julia package for aeroacoustics Submitting author: @1oly Handling editor: @faroit (Active) Reviewers: @nantonel, @thejasvibr Similarity score: 0.6782

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

kyleniemeyer commented 3 weeks ago

Hello @dagghe, I see in the submission notes that your original submission of pyOMA was rejected from JOSS (https://github.com/openjournals/joss-reviews/issues/3264), but was published at SoftwareX.

Can you provide more detail on how this version differs from the original?

dagghe commented 3 weeks ago

Hi @kyleniemeyer, the old module was more a collection of functions with a gui, while the new module leverages classes flexibility so to offer many more functionalities such as the ability to process multi-setup experiments, to have interactive plots to select the poles (or peaks) to extract, the possibility to define the geometry of the tested structure and plot/animate the mode shapes, storing and retrieving results and more. You can check by yourself if you want to, new repo: https://github.com/dagghe/pyOMA2 Old repo: https://github.com/dagghe/PyOMA

kyleniemeyer commented 4 days ago

@editorialbot invite @faroit as editor

Hi @faroit, could you edit this? To my eyes it seems in the neighborhood of your signal processing background.

editorialbot commented 4 days ago

Invitation to edit this submission sent!

faroit commented 2 days ago

@editorialbot assign @faroit as editor

@kyleniemeyer sure!

editorialbot commented 2 days ago

Assigned! @faroit is now the editor