openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
712 stars 38 forks source link

[REVIEW]: harmonize-wq: Standardize, clean and wrangle Water Quality Portal data into more analytic-ready formats #7305

Open editorialbot opened 2 hours ago

editorialbot commented 2 hours ago

Submitting author: !--author-handle-->@jbousquin<!--end-author-handle-- (Justin Bousquin) Repository: https://github.com/USEPA/harmonize-wq Branch with paper.md (empty if default branch): paper_JOSS Version: 0.5.0 Editor: !--editor-->@kthyng<!--end-editor-- Reviewers: !--reviewers-list-->@kthyng<!--end-reviewers-list-- Archive: Pending

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/cf3275a731d860635d261fb0388fa791"><img src="https://joss.theoj.org/papers/cf3275a731d860635d261fb0388fa791/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/cf3275a731d860635d261fb0388fa791/status.svg)](https://joss.theoj.org/papers/cf3275a731d860635d261fb0388fa791)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@kthyng, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @kthyng know.

Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest

Checklists

@kthyng, please create your checklist typing: @editorialbot generate my checklist

editorialbot commented 2 hours ago

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 2 hours ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.21105/joss.03485 is OK
- 10.1111/j.1752-1688.2011.00573.x is OK
- 10.1016/j.envsoft.2021.105210 is OK
- 10.21105/joss.03175 is OK
- 10.5066/P9X4L3GE is OK
- 10.1371/journal.pone.0239691 is OK
- 10.5066/P94I5TX3 is OK
- 10.5281/zenodo.5573592 is OK
- 10.1002/eap.2130 is OK
- 10.1002/2016WR019993 is OK
- 10.1029/2019WR024883 is OK
- 10.1021/acs.est.9b06406 is OK
- 10.1038/s41597-020-0478-7 is OK
- 10.1016/j.watres.2016.12.024 is OK
- 10.18637/jss.v059.i10 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Pint: Operate and manipulate physical quantities i...
- No DOI given, and none found for title: WQX Web API
- No DOI given, and none found for title: WQX Web User Guide

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None
editorialbot commented 2 hours ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.13 s (366.2 files/s, 375905.8 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          12            998           3491           2592
Jupyter Notebook                 7              0          37867            685
YAML                             9             52             59            321
TeX                              1             17              0            184
reStructuredText                 9            115            124            152
Markdown                         2             47              0            131
Rmd                              1             63            164             48
TOML                             1              7              0             39
DOS Batch                        1              8              1             26
make                             1              4              7              9
JSON                             2              0              0              8
-------------------------------------------------------------------------------
SUM:                            46           1311          41713           4195
-------------------------------------------------------------------------------

Commit count by author:

   334  Bousquin
   117  Justin Bousquin
     9  Cristina Mullin
     2  Romain Caneill
     2  cristinamullin
     1  Mullin
     1  Timothy Hodson
editorialbot commented 2 hours ago

Paper file info:

📄 Wordcount for paper.md is 1073

✅ The paper includes a Statement of need section

editorialbot commented 2 hours ago

License info:

✅ License found: MIT License (Valid open source OSI approved license)

editorialbot commented 2 hours ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

kthyng commented 2 hours ago

This submission was already reviewed through pyOpenSci and the review issue is available here: https://github.com/pyOpenSci/software-submission/issues/157