[REVIEW]: Bayesian model reconstruction based on spectral line observations with pomme

editorialbot commented 2 weeks ago

Submitting author: !--author-handle-->@FredDeCeuster@JBorrow<!--end-editor-- Reviewers: @karllark, @s-goldman Archive: Pending

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/d542c529434077d6022fb426fc6eb395"><img src="https://joss.theoj.org/papers/d542c529434077d6022fb426fc6eb395/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/d542c529434077d6022fb426fc6eb395/status.svg)](https://joss.theoj.org/papers/d542c529434077d6022fb426fc6eb395)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@karllark, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @JBorrow know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @s-goldman

editorialbot commented 2 weeks ago

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

editorialbot commented 2 weeks ago

Software report:

github.com/AlDanial/cloc v 1.90  T=3.09 s (39.2 files/s, 755168.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Jupyter Notebook                61              0        2310055          10280
HTML                             4            548              0           3900
Python                          23           1041           2156           1934
YAML                             7             40             22            223
Markdown                         7             62              0            134
TeX                              1             11              0            104
reStructuredText                15             58             90             69
TOML                             1              7              2             53
Bourne Shell                     2              2              3              5
-------------------------------------------------------------------------------
SUM:                           121           1769        2312328          16702
-------------------------------------------------------------------------------

Commit count by author:

   115  FredDeCeuster
    32  Frederik De Ceuster

editorialbot commented 2 weeks ago

Paper file info:

📄 Wordcount for paper.md is 722

✅ The paper includes a Statement of need section

editorialbot commented 2 weeks ago

License info:

🟡 License found: GNU General Public License v3.0 (Check here for OSI approval)

editorialbot commented 2 weeks ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.21105/joss.03905 is OK
- 10.48550/arXiv.2402.18525 is OK
- 10.1051/0004-6361/202347376 is OK
- 10.1051/0004-6361/202346116 is OK
- 10.1038/s41550-023-02154-y is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Automatic differentiation in PyTorch
- No DOI given, and none found for title: PyTorch: An Imperative Style, High-Performance Dee...

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

editorialbot commented 2 weeks ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

karllark commented 1 week ago

I will get started on my review after the JWST deadline and probably the STScI Flux Calibration workshop. Hence very late Oct or early Nov. Will try to get it before then, but not sure I will be able to. Just a FYI.

JBorrow commented 1 week ago

@editorialbot add @s-goldman as reviewer

editorialbot commented 1 week ago

@s-goldman added to the reviewers list!

JBorrow commented 1 week ago

@s-goldman the review will take place in this thread. Thank you so much for agreeing to review!

s-goldman commented 28 minutes ago

Review checklist for @s-goldman

Conflict of interest

[x] I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

[x] I confirm that I read and will adhere to the JOSS code of conduct.

General checks

[x] Repository: Is the source code for this software available at the https://github.com/Magritte-code/pomme?
[x] License: Does the repository contain a plain-text LICENSE or COPYING file with the contents of an OSI approved software license?
[x] Contribution and authorship: Has the submitting author (@FredDeCeuster) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?
[ ] Substantial scholarly effort: Does this submission meet the scope eligibility described in the JOSS guidelines
[ ] Data sharing: If the paper contains original data, data are accessible to the reviewers. If the paper contains no original data, please check this item.
[ ] Reproducibility: If the paper contains original results, results are entirely reproducible by reviewers. If the paper contains no original results, please check this item.
[x] Human and animal research: If the paper contains original data research on humans subjects or animals, does it comply with JOSS's human participants research policy and/or animal research policy? If the paper contains no such data, please check this item.

Functionality

[ ] Installation: Does installation proceed as outlined in the documentation?
[ ] Functionality: Have the functional claims of the software been confirmed?
[ ] Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

[x] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
[x] Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
[ ] Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
[ ] Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
[x] Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
[x] Community guidelines: Are there clear guidelines for third parties wishing to 1. Contribute to the software 2. Report issues or problems with the software 3. Seek support

Software paper

[ ] Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
[ ] A statement of need: Does the paper have a section titled 'Statement of need' that clearly states what problems the software is designed to solve, who the target audience is, and its relation to other work?
[ ] State of the field: Do the authors describe how this software compares to other commonly-used packages?
[ ] Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
[ ] References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

openjournals / joss-reviews