openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
715 stars 38 forks source link

[REVIEW]: modisfast: An R package for fast and efficient access to MODIS, VIIRS and GPM Earth Observation data #7343

Open editorialbot opened 3 hours ago

editorialbot commented 3 hours ago

Submitting author: !--author-handle-->@ptaconet<!--end-author-handle-- (Paul Taconet) Repository: https://github.com/ptaconet/modisfast Branch with paper.md (empty if default branch): Version: 0.9.2 Editor: !--editor-->@mikemahoney218<!--end-editor-- Reviewers: @rmendels, @V-Agudetse Archive: Pending

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/abd5750a442de6a9d95b60bf49c440cb"><img src="https://joss.theoj.org/papers/abd5750a442de6a9d95b60bf49c440cb/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/abd5750a442de6a9d95b60bf49c440cb/status.svg)](https://joss.theoj.org/papers/abd5750a442de6a9d95b60bf49c440cb)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@rmendels & @V-Agudetse, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @mikemahoney218 know.

Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest

Checklists

@rmendels, please create your checklist typing: @editorialbot generate my checklist

@V-Agudetse, please create your checklist typing: @editorialbot generate my checklist

editorialbot commented 3 hours ago

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 3 hours ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.07 s (1208.6 files/s, 270566.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
HTML                            23            694            128           5844
JavaScript                      13            812            547           4232
Markdown                         8            334              0           2243
CSS                             11            177            137           1190
R                               18            329            654            796
Rmd                              5            310            433            317
YAML                             5             31             27            157
TeX                              1             10              0            108
CSV                              1              0              0             78
XML                              1              0              0             57
JSON                             1              0              0             44
SVG                              1              0              1             11
-------------------------------------------------------------------------------
SUM:                            88           2697           1927          15077
-------------------------------------------------------------------------------

Commit count by author:

    76  Paul Taconet
    55  ptaconet
     1  floriandeboissieu
editorialbot commented 3 hours ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1016/S0034-4257(02)00084-6 is OK
- 10.1016/j.techfore.2023.122357 is OK
- 10.1016/j.rse.2023.113963 is OK
- 10.1175/bams-d-15-00306.1 is OK
- 10.32614/CRAN.package.MODISTools is OK
- 10.1016/j.cageo.2016.08.020 is OK
- 10.5281/zenodo.7938190 is OK
- 10.5281/zenodo.3945409 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: A review of selected MODIS algorithms, data produc...
- No DOI given, and none found for title: R: A Language and Environment for Statistical Comp...

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None
editorialbot commented 3 hours ago

Paper file info:

📄 Wordcount for paper.md is 987

✅ The paper includes a Statement of need section

editorialbot commented 3 hours ago

License info:

🟡 License found: GNU General Public License v3.0 (Check here for OSI approval)

editorialbot commented 3 hours ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

mikemahoney218 commented 3 hours ago

👋🏼 @ptaconet, @rmendels, @V-Agudetse this is the review thread for the paper. Just about all of our communications will happen here from now on 😄

As a reviewer, the first step is to create a checklist for your review by entering

@editorialbot generate my checklist

as the top of a new comment in this thread.

These checklists contain the JOSS requirements. As you go over the submission, please check any items that you feel have been satisfied. The first comment in this thread also contains links to the JOSS reviewer guidelines.

The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, the reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention openjournals/joss-reviews#7343 so that a link is created to this thread (and I can keep an eye on what is happening). Please also feel free to comment and ask questions on this thread. In my experience, it is better to post comments/questions/suggestions as you come across them instead of waiting until you've reviewed the entire package.

We aim for reviews to be completed within about 4 weeks. Please let me know if you require some more time.

Please feel free to ping me (@mikemahoney218) if you have any questions/concerns!