[PRE REVIEW]: nleis.py: A Nonlinear Electrochemical Impedance Analysis Toolbox

editorialbot commented 1 week ago

Submitting author: !--author-handle-->@yuefan98@lucydot<!--end-editor-- Reviewers: Pending Managing EiC: Kevin M. Moerman

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/f21e419a944424a7322cd0514dc029db"><img src="https://joss.theoj.org/papers/f21e419a944424a7322cd0514dc029db/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/f21e419a944424a7322cd0514dc029db/status.svg)](https://joss.theoj.org/papers/f21e419a944424a7322cd0514dc029db)

Author instructions

Thanks for submitting your paper to JOSS @yuefan98. Currently, there isn't a JOSS editor assigned to your paper.

@yuefan98 if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands

editorialbot commented 1 week ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

editorialbot commented 1 week ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.04 s (830.5 files/s, 171006.0 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          14           1359           1842           2527
Markdown                         6            120              0            281
YAML                             4             23              7            109
TeX                              1             11              0             92
reStructuredText                 9             74            138             67
Jupyter Notebook                 1              0            856             58
DOS Batch                        1              8              1             26
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                            37           1599           2851           3169
-------------------------------------------------------------------------------

Commit count by author:

    38  Yuefan Ji
    22  yuefan98
     3  Dan Schwartz
     3  Matt Murbach
     3  allcontributors[bot]

editorialbot commented 1 week ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1149/2.0711811jes is OK
- 10.21105/joss.02349 is OK
- 10.1016/j.ijhydene.2007.05.036 is OK
- 10.1016/j.jpowsour.2020.228742 is OK
- 10.1149/1.2055011 is OK
- 10.1149/2.0301711jes is OK
- 10.1149/1945-7111/acada7 is OK
- 10.1149/1945-7111/ad15ca is OK
- 10.1149/1945-7111/ad2596 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Electrochemical impedance spectroscopy

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

editorialbot commented 1 week ago

Paper file info:

📄 Wordcount for paper.md is 1481

✅ The paper includes a Statement of need section

editorialbot commented 1 week ago

License info:

✅ License found: MIT License (Valid open source OSI approved license)

editorialbot commented 1 week ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 1 week ago

Five most similar historical JOSS papers:

DearEIS - A GUI program for analyzing impedance spectra Submitting author: @vyrjana Handling editor: @jgostick (Active) Reviewers: @Aslan-Kosakian, @mdmurbach Similarity score: 0.7171

EchemFEM: A Firedrake-based Python package for electrochemical transport Submitting author: @tlroy Handling editor: @RMeli (Active) Reviewers: @sudarshanv01, @alizma, @TomTranter Similarity score: 0.6519

fuelcell: A Python package and graphical user interface for electrochemical data analysis Submitting author: @samaygarg Handling editor: @jgostick (Active) Reviewers: @jlopata21, @shimpalee Similarity score: 0.6489

RHEOS.jl -- A Julia Package for Rheology Data Analysis Submitting author: @akabla Handling editor: @jedbrown (Active) Reviewers: @adambeall, @gbruer15, @HaoZeke Similarity score: 0.6471

liionpack: A Python package for simulating packs of batteries with PyBaMM Submitting author: @TomTranter Handling editor: @timtroendle (Retired) Reviewers: @EricaEgg, @mefuller, @yangbai90 Similarity score: 0.6435

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

Kevin-Mattheus-Moerman commented 2 days ago

@yuefan98 Dear author, thanks for this submission. I am the AEiC on this track and here to help process the initial steps. Before we proceed, please can you have a look at the following points:

[ ] In your affiliations, can you spell out USA as United States of America, thanks.
[ ] Your README is very minimal. The following is not a strict requirement, but having separate sections e.g. on getting started, testing, documentation, etc may be good.
[ ] The references do not appear to render at the end of the paper. I'll ask our team to see if they can spot why that is, but in the meantime, feel free to try to diagnose it yourself too.

Kevin-Mattheus-Moerman commented 2 days ago

@editorialbot invite @lucydot as editor

editorialbot commented 2 days ago

Invitation to edit this submission sent!

Kevin-Mattheus-Moerman commented 2 days ago

@openjournals/dev can you see why the references are not showing in the paper? Thanks!

yuefan98 commented 1 day ago

Hi @Kevin-Mattheus-Moerman, thanks for bringing these to my attention.

Sure, I will change that accordingly
We are trying to keep the README minimal while we have comprehensive documentation linked within the README using Sphinx. Here is the link for your reference. https://nleispy.readthedocs.io/en/latest/.
Sure, I will try to fix it as well

yuefan98 commented 1 day ago

@editorialbot generate pdf

editorialbot commented 1 day ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 1 day ago

Five most similar historical JOSS papers:

DearEIS - A GUI program for analyzing impedance spectra Submitting author: @vyrjana Handling editor: @jgostick (Active) Reviewers: @Aslan-Kosakian, @mdmurbach Similarity score: 0.7094

EchemFEM: A Firedrake-based Python package for electrochemical transport Submitting author: @tlroy Handling editor: @RMeli (Active) Reviewers: @sudarshanv01, @alizma, @TomTranter Similarity score: 0.6579

liionpack: A Python package for simulating packs of batteries with PyBaMM Submitting author: @TomTranter Handling editor: @timtroendle (Retired) Reviewers: @EricaEgg, @mefuller, @yangbai90 Similarity score: 0.6577

RHEOS.jl -- A Julia Package for Rheology Data Analysis Submitting author: @akabla Handling editor: @jedbrown (Active) Reviewers: @adambeall, @gbruer15, @HaoZeke Similarity score: 0.6517

fuelcell: A Python package and graphical user interface for electrochemical data analysis Submitting author: @samaygarg Handling editor: @jgostick (Active) Reviewers: @jlopata21, @shimpalee Similarity score: 0.6485

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

yuefan98 commented 1 day ago

Hi @Kevin-Mattheus-Moerman, I have resolved issues with references and updated the affiliation. Please let me know if there are any additional adjustments I need to make at this stage. Thanks!

lucydot commented 1 day ago

@editorialbot assign me as editor

editorialbot commented 1 day ago

Assigned! @lucydot is now the editor

openjournals / joss-reviews

[PRE REVIEW]: nleis.py: A Nonlinear Electrochemical Impedance Analysis Toolbox #7349

Status