openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
725 stars 38 forks source link

[PRE REVIEW]: SenSE: Community SAR ScattEring model #7354

Open editorialbot opened 1 month ago

editorialbot commented 1 month ago

Submitting author: !--author-handle-->@McWhity<!--end-author-handle-- (Thomas Weiß) Repository: https://github.com/McWhity/sense Branch with paper.md (empty if default branch): master Version: v0.2 Editor: !--editor-->@mbobra<!--end-editor-- Reviewers: Pending Managing EiC: Chris Vernon

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/ad7ed3c2f83c9ad009e7c18fab5fb1bc"><img src="https://joss.theoj.org/papers/ad7ed3c2f83c9ad009e7c18fab5fb1bc/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/ad7ed3c2f83c9ad009e7c18fab5fb1bc/status.svg)](https://joss.theoj.org/papers/ad7ed3c2f83c9ad009e7c18fab5fb1bc)

Author instructions

Thanks for submitting your paper to JOSS @McWhity. Currently, there isn't a JOSS editor assigned to your paper.

@McWhity if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 1 month ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 1 month ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1109/36.917912 is OK
- 10.1109/36.406677 is OK
- 10.1109/TGRS.1985.289498 is OK
- 10.1163/156939302X01119 is OK
- 10.1109/36.134085 is OK
- 10.1109/36.134086 is OK
- 10.1109/TGRS.2003.821065 is OK
- 10.3390/rs12183037 is OK
- 10.3390/rs13122320 is OK
- 10.1029/RS013i002p00357 is OK
- 10.1109/TGRS.2002.800232 is OK
- 10.1109/JSTARS.2024.3448625 is OK

🟡 SKIP DOIs

- None

❌ MISSING DOIs

- 10.3998/0472119356 may be a valid DOI for title: Microwave radar and radiometric remote sensing

❌ INVALID DOIs

- None
editorialbot commented 1 month ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.05 s (1825.2 files/s, 175720.2 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          51           1082           1131           2308
reStructuredText                18            381            240            973
TeX                              2             25              0            379
Jupyter Notebook                 4              0           1081            237
make                             1             33             11            151
Markdown                         2             45              1            143
YAML                             5             26             19             84
JSON                             1              5              0             31
TOML                             1             17             19             31
Dockerfile                       1              5              1              8
Bourne Shell                     1              1              0              2
DOS Batch                        1              0              0              2
-------------------------------------------------------------------------------
SUM:                            88           1620           2503           4349
-------------------------------------------------------------------------------

Commit count by author:

   105  Thomas Weiß
    98  Alex
    68  McWhity
     7  Ben
     6  PMarzahn
     3  loewalex
     2  BenMGeo
     1  P.Marzahn
editorialbot commented 1 month ago

Paper file info:

📄 Wordcount for paper.md is 720

✅ The paper includes a Statement of need section

editorialbot commented 1 month ago

License info:

🟡 License found: Other (Check here for OSI approval)

editorialbot commented 1 month ago

:warning: An error happened when generating the pdf. Problem with affiliations for Thomas Weiß, perhaps the affiliations index need quoting?.

McWhity commented 1 month ago

@editorialbot commands

editorialbot commented 1 month ago

Hello @McWhity, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for branch
@editorialbot set joss-paper as branch

# Run checks and provide information on the repository and the paper file
@editorialbot check repository

# Check the references of the paper for missing DOIs
@editorialbot check references

# Generates the pdf paper
@editorialbot generate pdf

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Get a link to the complete list of reviewers
@editorialbot list reviewers
McWhity commented 1 month ago

@editorialbot check references

editorialbot commented 1 month ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1109/36.917912 is OK
- 10.1109/36.406677 is OK
- 10.1109/TGRS.1985.289498 is OK
- 10.1163/156939302X01119 is OK
- 10.1109/36.134085 is OK
- 10.1109/36.134086 is OK
- 10.1109/TGRS.2003.821065 is OK
- 10.3390/rs12183037 is OK
- 10.3390/rs13122320 is OK
- 10.1029/RS013i002p00357 is OK
- 10.1109/TGRS.2002.800232 is OK
- 10.3998/0472119356 is OK
- 10.1109/JSTARS.2024.3448625 is OK

🟡 SKIP DOIs

- None

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None
McWhity commented 1 month ago

@editorialbot generate pdf

editorialbot commented 1 month ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 1 month ago

Five most similar historical JOSS papers:

MWRpy: A Python package for processing microwave radiometer data Submitting author: @tobiasmarke Handling editor: @mengqi-z (Active) Reviewers: @Subho07, @kvenkman Similarity score: 0.6766

Geodata-Harvester: A Python package to jumpstart geospatial data extraction and analysis Submitting author: @sebhaan Handling editor: @hugoledoux (Active) Reviewers: @lukasbeuster, @martibosch Similarity score: 0.6738

CRNPy: An Open-Source Python Library for Cosmic-Ray Neutron Probe Data Processing Submitting author: @joaquinperaza Handling editor: @elbeejay (Active) Reviewers: @jlarsen-usgs, @danpower101 Similarity score: 0.6720

CloudnetPy: A Python package for processing cloud remote sensing data Submitting author: @tukiains Handling editor: @jedbrown (Active) Reviewers: @josephhardinee, @ekschuman Similarity score: 0.6655

itmlogic: The Irregular Terrain Model by Longley and Rice Submitting author: @edwardoughton Handling editor: @danielskatz (Active) Reviewers: @gorlapraveen, @garrettj403 Similarity score: 0.6642

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

crvernon commented 1 month ago

@McWhity it seems that this has been forked from a fork of pygeo. Could explain the provenance of this repository a bit? Thanks.

McWhity commented 1 month ago

@crvernon you are right the original repository is pygeo/sense. It was started by my former supervisor and colleague, Alexander Löw, who unfortunately died in a car accident. Thus, we do not have writing access to pygeo/sense, which is unfortunate. To continue the repository in his honor, another colleague forked it to PMarzahn/sense. However, since he did not actually work on the Python code, I moved the repository to my account to continue updating and improving it. I know it is not ideal, but we had to deal with the circumstances. Alexander Löw (pygeo) is credited as author, and he is also acknowledged as the person who initiated the repository (see Paper draft).

crvernon commented 4 weeks ago

@McWhity - Got it. Thank you for the clarification and my condolences for you loss.

crvernon commented 2 weeks ago

@editorialbot invite @mbobra as editor

:wave: @mbobra - can you take this one on as editor?

editorialbot commented 2 weeks ago

Invitation to edit this submission sent!

mbobra commented 5 days ago

@editorialbot assign me as editor

editorialbot commented 5 days ago

Assigned! @mbobra is now the editor

mbobra commented 5 days ago

👋 @McWhity Thanks for your submission! If you have any suggestions for reviewers, please let me know here (you can give me the Github handle without @ mentioning them, e.g. mbobra instead of @mbobra). Feel free to look through our database of reviewers. You can also suggest people outside of this database.

McWhity commented 2 days ago

@mbobra Thank you for taking over as editor. Here are some handles of possible reviewers

Outside of your database:

From your database: