openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
720 stars 38 forks source link

[PRE REVIEW]: canoPyHydro: Leveraging Lidar to Predict Precipitation Partitioning #7396

Open editorialbot opened 3 days ago

editorialbot commented 3 days ago

Submitting author: !--author-handle-->@wischmcj<!--end-author-handle-- (Collin Wischmeyer) Repository: https://github.com/wischmcj/canopyHydrodynamics Branch with paper.md (empty if default branch): Version: v0.1.1 Editor: Pending Reviewers: Pending Managing EiC: Kristen Thyng

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/fdba32d2d93150851a73b3a8ececebcf"><img src="https://joss.theoj.org/papers/fdba32d2d93150851a73b3a8ececebcf/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/fdba32d2d93150851a73b3a8ececebcf/status.svg)](https://joss.theoj.org/papers/fdba32d2d93150851a73b3a8ececebcf)

Author instructions

Thanks for submitting your paper to JOSS @wischmcj. Currently, there isn't a JOSS editor assigned to your paper.

@wischmcj if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 3 days ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 3 days ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1111/2041-210X.14378 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Precipitation partitioning by vegetation: A global...
- No DOI given, and none found for title: Computree Platform

❌ MISSING DOIs

- 10.1007/978-3-030-29702-2_6 may be a valid DOI for title: Spatial variability and temporal stability of loca...
- 10.1002/hyp.5563 may be a valid DOI for title: The importance of interception and why we should d...
- 10.1007/978-3-030-29702-2_13 may be a valid DOI for title: Flow pathways of throughfall and stemflow through ...
- 10.1007/978-3-030-29702-2_3 may be a valid DOI for title: Evaporative processes on vegetation: An inside loo...
- 10.1007/978-3-030-29702-2_10 may be a valid DOI for title: Relevance of precipitation partitioning to the tre...
- 10.1007/978-3-030-29702-2_11 may be a valid DOI for title: Role of precipitation partitioning in litter bioge...
- 10.1007/s11252-017-0693-y may be a valid DOI for title: Evaluating the effectiveness of urban trees to mit...
- 10.1002/esp.5435 may be a valid DOI for title: Comprehensive evaluation of throughfall erosion in...
- 10.1007/978-3-030-29702-2_12 may be a valid DOI for title: A review of the effects of throughfall and stemflo...
- 10.1007/978-3-030-29702-2_14 may be a valid DOI for title: Precipitation partitioning—hydrologic highways bet...
- 10.1016/j.jhydrol.2016.06.042 may be a valid DOI for title: Detecting spatial structures in throughfall data: ...
- 10.1007/978-3-030-29702-2_4 may be a valid DOI for title: A Global Synthesis of Throughfall and Stemflow Hyd...
- 10.1007/978-3-030-29702-2_4 may be a valid DOI for title: A Global Synthesis of Throughfall and Stemflow Hyd...

❌ INVALID DOIs

- https://doi.org/10.1016/j.agrformet.2014.01.014 is INVALID because of 'https://doi.org/' prefix
editorialbot commented 3 days ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.61 s (139.7 files/s, 384087.9 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
CSV                             14              0              0         157096
SVG                              1              0             21          61351
Python                          23            745           1213           5823
Markdown                        20            514              0           1648
Jupyter Notebook                 5              0           3505            395
YAML                            11             57             43            383
TOML                             3             38             54            252
TeX                              1             20              2            226
JSON                             1              0              0             37
reStructuredText                 3             60            119             28
DOS Batch                        1              8              1             26
CSS                              1              1              0             16
make                             1              4              5             10
-------------------------------------------------------------------------------
SUM:                            85           1447           4963         227291
-------------------------------------------------------------------------------

Commit count by author:

   275  Collin
   147  wischmcj
    62  dependabot[bot]
     9  John Van Stan
     4  Nunya Bidness
editorialbot commented 3 days ago

Paper file info:

📄 Wordcount for paper.md is 2152

✅ The paper includes a Statement of need section

editorialbot commented 3 days ago

:warning: An error happened when generating the pdf. Problem with ORCID (000-0002-0692-7064) for John Van Stan. ORCID looks to be the wrong length.

editorialbot commented 3 days ago

License info:

🔴 Failed to discover a valid open source license

kthyng commented 3 days ago

👋 @wischmcj - note that your paper does not compile. Please follow the example paper and note that you can click on the error above to find out more about it.