search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
725 stars 38 forks source link

[REVIEW]: UncertRadio: Software for determining characteristic limits in accordance to DIN EN ISO 11929 for radioactivity measurements #7398

Open editorialbot opened 1 month ago

editorialbot commented 1 month ago

Submitting author: !--author-handle-->@florianober<!--end-author-handle-- (Florian Ober) Repository: https://github.com/OpenBfS/UncertRadio Branch with paper.md (empty if default branch): paper Version: 2.5.1 Editor: !--editor-->@kellyrowland<!--end-editor-- Reviewers: @villaa, @alberto743 Archive: Pending

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/cd580ee1d2dda58267edc892c8430114"><img src="https://joss.theoj.org/papers/cd580ee1d2dda58267edc892c8430114/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/cd580ee1d2dda58267edc892c8430114/status.svg)](https://joss.theoj.org/papers/cd580ee1d2dda58267edc892c8430114)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@villaa & @alberto743, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @kellyrowland know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

@villaa, please create your checklist typing: @editorialbot generate my checklist

@alberto743, please create your checklist typing: @editorialbot generate my checklist

editorialbot commented 1 month ago

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 1 month ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.41 s (319.6 files/s, 488427.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Fortran 90                     123          23719          37023         122294
Glade                            1              0            262          15571
Markdown                         3            151              0            501
TeX                              1             32              0            408
CMake                            1             21             15            192
Bourne Shell                     1              3              2             11
INI                              1              1              0              3
-------------------------------------------------------------------------------
SUM:                           131          23927          37302         138980
-------------------------------------------------------------------------------

Commit count by author:

   141  Florian Ober
    13  Florian Ober (MRI)
     6  Flo Ober
     3  Ober
     1  Günter Kanisch
     1  Marco Lechner, GeoBoink
editorialbot commented 1 month ago

Paper file info:

📄 Wordcount for paper.md is 2312

✅ The paper includes a Statement of need section

editorialbot commented 1 month ago

License info:

🟡 License found: GNU General Public License v3.0 (Check here for OSI approval)

editorialbot commented 1 month ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.31030/2145948 is OK
- 10.31030/1714556 is OK
- 10.1007/s10967-019-06850-w is OK
- 10.1016/j.nima.2003.07.040 is OK
- 10.1016/j.radmeas.2021.106543 is OK
- 10.2139/ssrn.4498961 is OK
- 10.1016/j.apradiso.2015.12.003 is OK
- 10.1016/j.apradiso.2015.12.046 is OK
- 10.1016/j.nima.2017.02.093 is OK
- 10.21105/joss.01109 is OK
- 10.1016/j.apradiso.2018.06.016 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Rapid Simultaneous Determination of 89Sr and 90Sr ...
- No DOI given, and none found for title: Quantifying Uncertainty in Nuclear Analytical Meas...
- No DOI given, and none found for title: Datenanalyse: Mit Statistischen Methoden Und Compu...
- No DOI given, and none found for title: Allgemeine Verwaltungsvorschrift zum integrierten ...
- No DOI given, and none found for title: Gesetz zum Schutz vor der schädlichen Wirkung ioni...
- No DOI given, and none found for title: Verordnung zum Schutz vor der schädlichen Wirkung ...
- No DOI given, and none found for title: DIN EN ISO 11929-1:2021-11: Bestimmung der charakt...
- No DOI given, and none found for title: DIN EN ISO 11929-2:2021-11: Bestimmung der charakt...
- No DOI given, and none found for title: DIN EN ISO 11929-3:2021-11: Bestimmung der charakt...
- No DOI given, and none found for title: DIN EN ISO 11929-4:2021-06: Bestimmung der charakt...
- No DOI given, and none found for title: Rapid Radiochemical Method for Total Radiostrontiu...
- No DOI given, and none found for title: GNOME / Glade
- No DOI given, and none found for title: Guide to the expression of uncertainty in measurem...
- No DOI given, and none found for title: Evaluation of measurement data - Supplement 1 to t...
- No DOI given, and none found for title: An introduction to the GUM and related documents: ...
- No DOI given, and none found for title: Evaluation of measurement data - Supplement 2 to t...
- No DOI given, and none found for title: The role of measurement uncertainty in conformity ...
- No DOI given, and none found for title: Maple
- No DOI given, and none found for title: Spreadsheet design and validation for characterist...
- No DOI given, and none found for title: Fortran 95 function parser
- No DOI given, and none found for title: PLplot

❌ MISSING DOIs

- 10.3403/30386313u may be a valid DOI for title: Radiation protection instrumentation - Determinati...

❌ INVALID DOIs

- None
editorialbot commented 1 month ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

kellyrowland commented 2 weeks ago

@villaa @alberto743 just checking in here 👋 please feel free to get started with your reviews at your earliest convenience or let me know if you need to set things aside.

alberto743 commented 2 weeks ago

@kellyrowland I will not able to start before the end of November unfortunately.