[PRE REVIEW]: DynamicAll

editorialbot commented 1 month ago

Submitting author: !--author-handle-->@jguerra-astro<!--end-author-handle-- (Juan Guerra) Repository: https://github.com/jguerra-astro/dynamicall Branch with paper.md (empty if default branch): main Version: e.g V1.0 Editor: Pending Reviewers: Pending Managing EiC: Warrick Ball

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/a26f20391c1360ed1f2806fa09065816"><img src="https://joss.theoj.org/papers/a26f20391c1360ed1f2806fa09065816/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/a26f20391c1360ed1f2806fa09065816/status.svg)](https://joss.theoj.org/papers/a26f20391c1360ed1f2806fa09065816)

Author instructions

Thanks for submitting your paper to JOSS @jguerra-astro. Currently, there isn't a JOSS editor assigned to your paper.

@jguerra-astro if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands

editorialbot commented 1 month ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

editorialbot commented 1 month ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.07 s (615.3 files/s, 345474.8 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          12           1014           2098           2882
Jupyter Notebook                15              0          10343           2471
TeX                              1            133              0           1744
XML                              1              2              0            826
YAML                             4              4              5            642
Markdown                         1             16              0             57
reStructuredText                 3             63             54             48
DOS Batch                        1              8              1             26
make                             1              4              7              9
TOML                             1              0              0              3
-------------------------------------------------------------------------------
SUM:                            40           1244          12508           8708
-------------------------------------------------------------------------------

Commit count by author:

   105  Juan Guerra
    18  jguerra-astro

editorialbot commented 1 month ago

Paper file info:

📄 Wordcount for paper.md is 603

✅ The paper includes a Statement of need section

editorialbot commented 1 month ago

License info:

✅ License found: MIT License (Valid open source OSI approved license)

editorialbot commented 1 month ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1086/670067 is OK
- 10.1093/mnras/sty2672 is OK
- 10.1093/mnras/stu2720 is OK
- 10.1088/0004-637X/749/1/72 is OK
- 10.1086/115438 is OK
- 10.1103/PhysRevLett.84.3760 is OK
- 10.1103/PhysRevLett.85.1158 is OK
- 10.1051/0004-6361/201832698 is OK
- 10.1088/0004-637X/701/2/1500 is OK
- 10.1093/mnras/stt956 is OK
- 10.1088/0004-637X/765/1/22 is OK
- 10.1086/309560 is OK
- 10.1111/j.1365-2966.2010.17287.x is OK
- 10.3847/1538-4357/aac2d3 is OK
- 10.1093/mnras/stw072 is OK
- 10.1093/mnras/sts175 is OK
- 10.3847/1538-4357/abcafa is OK
- 10.1093/mnras/stab634 is OK
- 10.1016/j.newar.2013.05.003 is OK
- 10.1093/mnras/200.2.361 is OK
- 10.1088/0004-637X/796/2/91 is OK
- 10.1146/annurev-astro-091916-055313 is OK
- 10.1093/mnras/stx975 is OK
- 10.1093/mnras/stab2440 is OK
- 10.1093/mnras/stt1891 is OK
- 10.1093/mnras/sty2931 is OK
- 10.1086/147433 is OK
- 10.3847/1538-4357/835/2/193 is OK
- 10.1093/mnras/sty2505 is OK
- 10.1093/mnrasl/slv083 is OK
- 10.1093/mnras/staa1404 is OK
- 10.2307/2342435 is OK
- 10.1051/0004-6361/201833343 is OK
- 10.1086/518025 is OK
- 10.1093/mnras/stx2322 is OK
- 10.1051/0004-6361/201936196 is OK
- 10.1093/mnras/stu1866 is OK
- 10.1088/2041-8205/775/1/L30 is OK
- 10.1093/mnras/76.2.70 is OK
- 10.1111/j.1365-2966.2011.19107.x is OK
- 10.1093/mnras/stz1317 is OK
- 10.1111/j.1365-2966.2012.20696.x is OK
- 10.5281/zenodo.5777131 is OK
- 10.1093/mnras/staa692 is OK
- 10.1093/mnras/staa2101 is OK
- 10.1046/j.1365-8711.2002.05457.x is OK
- 10.1017/S1743921319007956 is OK
- 10.1146/annurev.astro.36.1.435 is OK
- 10.1111/j.1365-2966.2005.09400.x is OK
- 10.1093/mnras/sts565 is OK
- 10.1088/1475-7516/2009/06/014 is OK
- 10.1093/mnras/stv942 is OK
- 10.1051/0004-6361/201935613 is OK
- 10.3847/2515-5172/abd18b is OK
- 10.1088/0004-6256/144/1/4 is OK
- 10.3847/1538-4357/aac16b is OK
- 10.1086/177173 is OK
- 10.1111/j.1365-2966.2009.15878.x is OK
- 10.1088/1475-7516/2021/08/062 is OK
- 10.1093/mnras/sty1860 is OK
- 10.1088/2041-8205/759/2/L42 is OK
- 10.1051/0004-6361/201833910 is OK
- 10.1111/j.1365-2966.2012.20571.x is OK
- 10.3847/1538-4357/abe391 is OK
- 10.1093/mnras/stw713 is OK
- 10.1093/mnras/stx1798 is OK
- 10.1093/mnras/sty2286 is OK
- 10.1093/mnras/staa3663 is OK
- 10.1093/mnras/sts514 is OK
- 10.1093/mnras/stu1762 is OK
- 10.1093/mnras/stu383 is OK
- 10.1086/521816 is OK
- 10.1093/mnras/staa278 is OK
- 10.1111/j.1365-2966.2010.17287.x is OK
- 10.3847/1538-4357/aa5c8e is OK
- 10.1088/1361-6633/aaae16 is OK
- 10.3847/1538-4365/ab9cb0 is OK
- 10.3847/1538-4357/abbe0a is OK
- 10.1086/157282 is OK
- 10.1038/nature04805 is OK
- 10.1088/0004-637x/733/1/46 is OK
- 10.1146/annurev-astro-091918-104453 is OK
- 10.1063/PT.3.4879 is OK
- 10.1093/mnras/stz2017 is OK
- 10.1088/0004-637X/710/2/1063 is OK
- 10.1093/mnras/sty2672 is OK
- 10.1088/0004-6256/137/2/3109 is OK
- 10.1088/0004-637X/704/2/1274 is OK
- 10.1088/0004-637X/742/1/20 is OK
- 10.1046/j.1365-8711.2002.05154.x is OK
- 10.1093/mnras/stv096 is OK
- 10.1111/j.1365-2966.2010.17297.x is OK
- 10.1093/mnras/stt1113 is OK
- 10.1111/j.1365-2966.2010.16753.x is OK
- 10.1093/mnras/278.2.488 is OK
- 10.1093/mnras/stz1617 is OK
- 10.1088/0004-637X/789/2/147 is OK
- 10.1109/MCSE.2007.55 is OK
- 10.21105/joss.00024 is OK
- 10.1051/0004-6361/201322068 is OK
- 10.3847/1538-3881/aabc4f is OK
- 10.3847/1538-4357/ac7c74 is OK
- 10.21105/joss.01143 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Fisher Matrix Stability
- No DOI given, and none found for title: General spherical anisotropic Jeans models of stel...
- No DOI given, and none found for title: Mathematical Methods of Statistics
- No DOI given, and none found for title: Statistical techniques in cosmology
- No DOI given, and none found for title: Internal rotation of MW dSph satellites with Gaia ...
- No DOI given, and none found for title: VizieR Online Data Catalog: RR Lyrae stars from th...
- No DOI given, and none found for title: Testing the Nature of Dark Matter with Extremely L...
- No DOI given, and none found for title: Data analysis recipes: Fitting a model to data
- No DOI given, and none found for title: A Stellar System of a New Type
- No DOI given, and none found for title: Galactic Dynamics: Second Edition
- No DOI given, and none found for title: Proper Motion Studies of Stellar Populationsin the...
- No DOI given, and none found for title: A Hubble Astrometry Initiative: Laying the Foundat...
- No DOI given, and none found for title: The US Extremely Large Telescope Program
- No DOI given, and none found for title: JAX: composable transformations of Python+NumPy pr...
- No DOI given, and none found for title: Composable Effects for Flexible and Accelerated Pr...
- No DOI given, and none found for title: Pyro: Deep Universal Probabilistic Programming
- No DOI given, and none found for title: pytest x.y

❌ MISSING DOIs

- 10.1086/591052 may be a valid DOI for title: Proper Motion of Milky Way Dwarf Spheroidals from ...
- 10.1017/s1743921319006793 may be a valid DOI for title: Gaia results for star clusters and dwarf galaxies ...
- 10.1007/978-1-4612-0919-5_16 may be a valid DOI for title: Information and the accuracy attainable in the est...
- 10.1086/512976 may be a valid DOI for title: Determining the Nature of Dark Matter with Astrome...

❌ INVALID DOIs

- None

editorialbot commented 1 month ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 1 month ago

Five most similar historical JOSS papers:

MG-MAMPOSSt, a Fortran code to test gravity at galaxy-cluster scales Submitting author: @Pizzuti92 Handling editor: @eloisabentivegna (Retired) Reviewers: @ttricco, @eloisabentivegna Similarity score: 0.7758

popkinmocks: mock IFU datacubes for modelling stellar populations and kinematics Submitting author: @prashjet Handling editor: @plaplant (Active) Reviewers: @apoudel2014, @Jammy2211 Similarity score: 0.7747

PyAutoGalaxy: Open-Source Multiwavelength Galaxy Structure & Morphology Submitting author: @Jammy2211 Handling editor: @christinahedges (Retired) Reviewers: @alexandergagliano, @sloneil Similarity score: 0.7563

CosmicProfiles: A Python package for radial profiling of finitely sampled dark matter halos and galaxies Submitting author: @tibordome Handling editor: @adonath (Active) Reviewers: @benediktdiemer, @phil-mansfield Similarity score: 0.7470

SkyPy: A package for modelling the Universe Submitting author: @rrjbca Handling editor: @arfon (Active) Reviewers: @cescalara, @rmorgan10 Similarity score: 0.7417

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

warrickball commented 1 month ago

@jguerra-astro — Thanks for your submission! All the suitable JOSS editors are currently working at capacity so I'm going to "waitlist" this review until an editor with the relevant expertise is available to take it on. Thanks for your patience!

In the meantime, there are a few things you can have a quick look at.

I see Marla Geha is included as an author but they aren't obviously connected to the software. I don't doubt that they contributed but could you briefly comment on their contribution? You may also want to mention them as a contributor in the docs. They don't appear there either.
Please add the county to your affiliation. ("USA" is fine.)
I suspect you're selecting references from a much larger BibTeX file. Could you trim the BibTeX file down to the minimum so we only check things like DOIs for the references actually used in the paper?
Along that vein, note that a lot of references don't have DOIs. That's fine—some references don't—but if you could do a sweep (after reducing the BibTeX list and running @editorialbot check references again) to see if you can fill in any gaps that'd be great. If you're getting your data from NASA ADS, it should be up to date.

jguerra-astro commented 6 days ago

@editorialbot check references

editorialbot commented 6 days ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1086/670067 is OK
- 10.1093/mnras/sty2672 is OK
- 10.1093/mnras/sty2672 is OK
- 10.1111/j.1365-2966.2010.16753.x is OK
- 10.1093/mnras/278.2.488 is OK
- 10.1109/MCSE.2007.55 is OK
- 10.21105/joss.00024 is OK
- 10.1051/0004-6361/201322068 is OK
- 10.3847/1538-3881/aabc4f is OK
- 10.3847/1538-4357/ac7c74 is OK
- 10.21105/joss.01143 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Galactic Dynamics: Second Edition
- No DOI given, and none found for title: JAX: composable transformations of Python+NumPy pr...
- No DOI given, and none found for title: Composable Effects for Flexible and Accelerated Pr...
- No DOI given, and none found for title: Pyro: Deep Universal Probabilistic Programming
- No DOI given, and none found for title: pytest x.y

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

openjournals / joss-reviews

[PRE REVIEW]: DynamicAll #7401

Status