openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
725 stars 38 forks source link

[PRE REVIEW]: HOHQMesh: An All Quadrilateral/Hexahedral Unstructured Mesh Generator for High Order Elements #7418

Closed editorialbot closed 1 week ago

editorialbot commented 3 weeks ago

Submitting author: !--author-handle-->@andrewwinters5000<!--end-author-handle-- (Andrew Winters) Repository: https://github.com/trixi-framework/HOHQMesh Branch with paper.md (empty if default branch): paper-2024-joss Version: v1.5.2 Editor: !--editor-->@xuanxu<!--end-editor-- Reviewers: @fhindenlang, @anderslogg Managing EiC: Daniel S. Katz

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/bb9bb324fccf69238a2d690c9125044b"><img src="https://joss.theoj.org/papers/bb9bb324fccf69238a2d690c9125044b/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/bb9bb324fccf69238a2d690c9125044b/status.svg)](https://joss.theoj.org/papers/bb9bb324fccf69238a2d690c9125044b)

Author instructions

Thanks for submitting your paper to JOSS @andrewwinters5000. Currently, there isn't a JOSS editor assigned to your paper.

@andrewwinters5000 if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 3 weeks ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 3 weeks ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.10 s (1120.2 files/s, 389970.7 lines/s)
--------------------------------------------------------------------------------
Language                      files          blank        comment           code
--------------------------------------------------------------------------------
Fortran 90                       70           2863          14514          18379
Markdown                         25            539              0           1824
make                              1             92             14            637
TeX                               1             41              4            422
YAML                              7             17             24            325
Bourne Again Shell                6             37             29            167
JSON                              1              0              0             34
CMake                             2             17              3             33
JavaScript                        1              1              0             15
TOML                              1              0              0              3
--------------------------------------------------------------------------------
SUM:                            115           3607          14588          21839
--------------------------------------------------------------------------------

Commit count by author:

   236  David Kopriva
    50  Andrew Winters
    43  Michael Schlottke-Lakemper
    24  dependabot[bot]
    18  DavidAKopriva
    13  Joe Schoonover
     6  Hendrik Ranocha
     1  Arpit Babbar
     1  Joseph Schoonover
editorialbot commented 3 weeks ago

Paper file info:

πŸ“„ Wordcount for paper.md is 1225

βœ… The paper includes a Statement of need section

editorialbot commented 3 weeks ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

βœ… OK DOIs

- 10.5281/zenodo.13959058 is OK
- 10.5281/zenodo.13959071 is OK
- 10.1093/gji/ggab308 is OK
- 10.1007/978-3-319-12886-3_8 is OK
- 10.1111/cgf.12014 is OK
- 10.1016/j.jcp.2021.110467 is OK
- 10.21105/jcon.00077 is OK
- 10.1137/120876034 is OK
- 10.1093/acprof:oso/9780198528692.001.0001 is OK
- 10.1007/978-0-387-72067-8 is OK
- 10.1007/978-90-481-2261-5 is OK
- 10.1016/j.jcp.2004.01.004 is OK
- 10.1137/141000671 is OK
- 10.1088/1742-6596/1671/1/012015 is OK
- 10.1007/s10915-024-02451-2 is OK
- 10.1016/j.jcp.2024.113471 is OK
- 10.1007/s10915-013-9730-z is OK
- 10.1016/j.amc.2015.08.047 is OK
- 10.1016/j.jcp.2020.109363 is OK
- 10.48550/arXiv.2404.09050 is OK
- 10.1103/PhysRevFluids.9.053901 is OK

🟑 SKIP DOIs

- No DOI given, and none found for title: NEK fast high-order scalable CFD NEK: Fast high-or...
- No DOI given, and none found for title: A Spectral Element Method tool for 2D wave propaga...
- No DOI given, and none found for title: Algorithms for quadrilateral and hexahedral mesh g...
- No DOI given, and none found for title: The Malpasset dam failure. An overview and test ca...
- No DOI given, and none found for title: Spectral-element and adjoint methods in seismology
- No DOI given, and none found for title: DGSEM for General Advection-Diffusion Equations
- No DOI given, and none found for title: High Order Methods for Incompressible Fluid Flow
- No DOI given, and none found for title: Shallow water simulations with Trixi.jl
- No DOI given, and none found for title: A novel entropy stable discontinuous Galerkin spec...

❌ MISSING DOIs

- None

❌ INVALID DOIs

- https://doi.org/10.1002/nme.397 is INVALID because of 'https://doi.org/' prefix
- 0.1080/00221689909498511 is INVALID
- https://doi.org/10.1016/j.cpc.2015.02.008 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1016/j.cpc.2019.05.015 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1016/j.camwa.2020.05.004 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1016/j.cpc.2023.108700 is INVALID because of 'https://doi.org/' prefix
editorialbot commented 3 weeks ago

License info:

🟑 License found: Other (Check here for OSI approval)

editorialbot commented 3 weeks ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 3 weeks ago

Five most similar historical JOSS papers:

FEM_2D: A Rust Package for 2D Finite Element Method Computations with Extensive Support for hp-refinement Submitting author: @jeremiah-corrado Handling editor: @jedbrown (Active) Reviewers: @jeremylt, @YohannDudouit Similarity score: 0.7336

DTCC Builder: A mesh generator for automatic, efficient, and robust mesh generation for large-scale city modeling and simulation Submitting author: @anderslogg Handling editor: @crvernon (Active) Reviewers: @ifthompson, @ipadjen Similarity score: 0.7270

scikit-fem: A Python package for finite element assembly Submitting author: @kinnala Handling editor: @meg-simula (Retired) Reviewers: @thelfer, @AnjaliSandip Similarity score: 0.7222

MTEX2Gmsh: a tool for generating 2D meshes from EBSD data Submitting author: @DorianDepriester Handling editor: @meg-simula (Retired) Reviewers: @streeve, @ralfHielscher Similarity score: 0.7218

OpenCMP: An Open-Source Computational Multiphysics Package Submitting author: @nasserma Handling editor: @lucydot (Active) Reviewers: @bonh, @WilkAndy Similarity score: 0.7181

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

danielskatz commented 3 weeks ago

πŸ‘‹ @andrewwinters5000 - Thanks for your submission. I'll try to find an editor next, though I may be delayed a bit over next week.

While I do so, you could work on the invalid DOIs that editorialbot found. One seems to be missing a "1" at the start, and the others have prefixes that should be deleted. Please feel free to make changes to your .bib file, then use the command @editorialbot check references to check again, and the command @editorialbot generate pdf when the references are right to make a new PDF. editorialbot commands need to be the first entry in a new comment.

danielskatz commented 3 weeks ago

πŸ‘‹ @HaoZeke - I see that one of your active editing submissions is almost complete. Would you be able to take this one on next?

danielskatz commented 3 weeks ago

@editorialbot invite @HaoZeke as editor

editorialbot commented 3 weeks ago

Invitation to edit this submission sent!

andrewwinters5000 commented 3 weeks ago

@editorialbot check references

editorialbot commented 3 weeks ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

βœ… OK DOIs

- 10.5281/zenodo.13959058 is OK
- 10.5281/zenodo.13959071 is OK
- 10.1093/gji/ggab308 is OK
- 10.1002/nme.397 is OK
- 10.1007/978-3-319-12886-3_8 is OK
- 10.1080/00221689909498511 is OK
- 10.1111/cgf.12014 is OK
- 10.1016/j.cpc.2015.02.008 is OK
- 10.1016/j.cpc.2019.05.015 is OK
- 10.1016/j.camwa.2020.05.004 is OK
- 10.1016/j.jcp.2021.110467 is OK
- 10.21105/jcon.00077 is OK
- 10.1016/j.cpc.2023.108700 is OK
- 10.1137/120876034 is OK
- 10.1093/acprof:oso/9780198528692.001.0001 is OK
- 10.1007/978-0-387-72067-8 is OK
- 10.1007/978-90-481-2261-5 is OK
- 10.1016/j.jcp.2004.01.004 is OK
- 10.1137/141000671 is OK
- 10.1088/1742-6596/1671/1/012015 is OK
- 10.1007/s10915-024-02451-2 is OK
- 10.1016/j.jcp.2024.113471 is OK
- 10.1007/s10915-013-9730-z is OK
- 10.1016/j.amc.2015.08.047 is OK
- 10.1016/j.jcp.2020.109363 is OK
- 10.48550/arXiv.2404.09050 is OK
- 10.1103/PhysRevFluids.9.053901 is OK

🟑 SKIP DOIs

- No DOI given, and none found for title: NEK fast high-order scalable CFD NEK: Fast high-or...
- No DOI given, and none found for title: A Spectral Element Method tool for 2D wave propaga...
- No DOI given, and none found for title: Algorithms for quadrilateral and hexahedral mesh g...
- No DOI given, and none found for title: The Malpasset dam failure. An overview and test ca...
- No DOI given, and none found for title: Spectral-element and adjoint methods in seismology
- No DOI given, and none found for title: DGSEM for General Advection-Diffusion Equations
- No DOI given, and none found for title: High Order Methods for Incompressible Fluid Flow
- No DOI given, and none found for title: Shallow water simulations with Trixi.jl
- No DOI given, and none found for title: A novel entropy stable discontinuous Galerkin spec...

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None
andrewwinters5000 commented 3 weeks ago

@editorialbot generate pdf

editorialbot commented 3 weeks ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

andrewwinters5000 commented 3 weeks ago

πŸ‘‹ @andrewwinters5000 - Thanks for your submission. I'll try to find an editor next, though I may be delayed a bit over next week.

While I do so, you could work on the invalid DOIs that editorialbot found. One seems to be missing a "1" at the start, and the others have prefixes that should be deleted. Please feel free to make changes to your .bib file, then use the command @editorialbot check references to check again, and the command @editorialbot generate pdf when the references are right to make a new PDF. editorialbot commands need to be the first entry in a new comment.

Thanks! I have fixed the broken DOIs and will suggest reviewers as instructed above.

editorialbot commented 3 weeks ago

Five most similar historical JOSS papers:

FEM_2D: A Rust Package for 2D Finite Element Method Computations with Extensive Support for hp-refinement Submitting author: @jeremiah-corrado Handling editor: @jedbrown (Active) Reviewers: @jeremylt, @YohannDudouit Similarity score: 0.7334

DTCC Builder: A mesh generator for automatic, efficient, and robust mesh generation for large-scale city modeling and simulation Submitting author: @anderslogg Handling editor: @crvernon (Active) Reviewers: @ifthompson, @ipadjen Similarity score: 0.7268

scikit-fem: A Python package for finite element assembly Submitting author: @kinnala Handling editor: @meg-simula (Retired) Reviewers: @thelfer, @AnjaliSandip Similarity score: 0.7217

MTEX2Gmsh: a tool for generating 2D meshes from EBSD data Submitting author: @DorianDepriester Handling editor: @meg-simula (Retired) Reviewers: @streeve, @ralfHielscher Similarity score: 0.7215

OpenCMP: An Open-Source Computational Multiphysics Package Submitting author: @nasserma Handling editor: @lucydot (Active) Reviewers: @bonh, @WilkAndy Similarity score: 0.7179

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

andrewwinters5000 commented 3 weeks ago

Suggested reviewers:

andrewwinters5000 commented 2 weeks ago

Another possible reviewer:

danielskatz commented 1 week ago

πŸ‘‹ @HaoZeke - As mentioned in https://github.com/openjournals/joss-reviews/issues/7418#issuecomment-2450619565, would you be able to edit this submission?

danielskatz commented 1 week ago

πŸ‘‹ @xuanxu - Would you perhaps be able to edit this submission?

danielskatz commented 1 week ago

@editorialbot invite @xuanxu as editor

editorialbot commented 1 week ago

Invitation to edit this submission sent!

xuanxu commented 1 week ago

Yes, I can edit this submission

xuanxu commented 1 week ago

@editorialbot assign me as editor

editorialbot commented 1 week ago

Assigned! @xuanxu is now the editor

xuanxu commented 1 week ago

:wave: @anderslogg @fhindenlang Would you be willing to review this paper? You have been suggested by the author as a good fit as reviewers for this submission.

fhindenlang commented 1 week ago

In principle yes... how much time do I have to review the paper?

xuanxu commented 1 week ago

@fhindenlang Great, thanks! We try to have the review completed in 6 weeks I'll add you now and as soon as I have a second reviewer I'll start the review issue.

xuanxu commented 1 week ago

@editorialbot add @fhindenlang to reviewers

editorialbot commented 1 week ago

@fhindenlang added to the reviewers list!

fhindenlang commented 1 week ago

allright!

anderslogg commented 1 week ago

πŸ‘‹ @anderslogg @fhindenlang Would you be willing to review this paper? You have been suggested by the author as a good fit as reviewers for this submission.

Yes

xuanxu commented 1 week ago

@anderslogg Great, thanks! I'll add you and start the review issue now.

xuanxu commented 1 week ago

@editorialbot add @anderslogg to reviewers

editorialbot commented 1 week ago

@anderslogg added to the reviewers list!

xuanxu commented 1 week ago

@editorialbot start review

editorialbot commented 1 week ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/7476.