openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
706 stars 37 forks source link

[PRE REVIEW]: skijumpdesign: A Ski Jump Design Tool for Specified Equivalent Fall Height #742

Closed whedon closed 6 years ago

whedon commented 6 years ago

Submitting author: @moorepants (Jason K. Moore) Repository: https://gitlab.com/moorepants/skijumpdesign Version: v1.2.0 Editor: @Kevin-Mattheus-Moerman Reviewers: @trallard

Author instructions

Thanks for submitting your paper to JOSS @moorepants. The JOSS editor (shown at the top of this issue) will work with you on this issue to find a reviewer for your submission before creating the main review issue.

@moorepants if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
whedon commented 6 years ago

Hello human, I'm @whedon. I'm here to help you with some common editorial tasks. @Kevin-Mattheus-Moerman it looks like you're currently assigned as the editor for this paper :tada:

For a list of things I can do to help you, just type:

@whedon commands
whedon commented 6 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 6 years ago

PDF failed to compile for issue #742 with the following error:

% Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed

0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 100 11 0 11 0 0 139 0 --:--:-- --:--:-- --:--:-- 141 Error reading bibliography ./paper.bib (line 142, column 9): unexpected "(" expecting letter, white space or "{" Error running filter pandoc-citeproc: Filter returned error status 1 Looks like we failed to compile the PDF

arfon commented 6 years ago

:wave: @Kevin-Mattheus-Moerman - the submitting author suggested you as the handling editor.

arfon commented 6 years ago

@moorepants - could you take a look at the errors from the paper compilation above?

Kevin-Mattheus-Moerman commented 6 years ago

@arfon I can take this.

Kevin-Mattheus-Moerman commented 6 years ago

@moorepants I think you just need to replace a ( by a { on line 142. I created a merge request on your repo. Just say @whedon generate pdf here when you are ready to test

Kevin-Mattheus-Moerman commented 6 years ago

@moorepants any reviewers you can recommend for this work?

Kevin-Mattheus-Moerman commented 6 years ago

@devinberg is this a project you'd be interested in reviewing?

moorepants commented 6 years ago

@whedon generate pdf

whedon commented 6 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 6 years ago

PDF failed to compile for issue #742 with the following error:

% Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed

0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 100 11 0 11 0 0 77 0 --:--:-- --:--:-- --:--:-- 78 Error reading bibliography ./paper.bib (line 188, column 9): unexpected "(" expecting letter, white space or "{" Error running filter pandoc-citeproc: Filter returned error status 1 Looks like we failed to compile the PDF

moorepants commented 6 years ago

@monthubbard the review will be happening here. FYI.

moorepants commented 6 years ago

@whedon generate pdf

whedon commented 6 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 6 years ago

--> Check article proof :page_facing_up: <--

moorepants commented 6 years ago

@monthubbard Do you have any recommendations for reviewers? They'll need to be willing to review via the Github interface here.

moorepants commented 6 years ago

There are a couple reviewers on the list that have biomechanics listed: trallard and CELavecchia

moorepants commented 6 years ago

pandoc converts \(mg\) to latex mathematics locally for me but it doesn't seem to work via whedon, see:

image

I have an issue open for this: https://github.com/openjournals/joss/issues/409

moorepants commented 6 years ago

@whedon generate pdf

whedon commented 6 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 6 years ago

--> Check article proof :page_facing_up: <--

moorepants commented 6 years ago

Ok, the paper seems to be compiling correctly and I've fixed some minor issues wrt to that.

monthubbard commented 6 years ago

Prof Chris Brown, Worcester Poly, brown@wpi.edu Dr Martin Mossner, University of Innsbruck, email unknown

I have no idea whether they are willing to use Github

On May 20, 2018, at 10:03 PM, Jason K. Moore notifications@github.com wrote:

@monthubbard https://github.com/monthubbard Do you have any recommendations for reviewers? They'll need to be willing to review via the Github interface here.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/742#issuecomment-390553876, or mute the thread https://github.com/notifications/unsubscribe-auth/ABIdATPOxuxATBlplTQ7lMotbmzq3ICxks5t0kq6gaJpZM4UGC58.

devinberg commented 6 years ago

@Kevin-Mattheus-Moerman Looks interesting but I worry I'm not software savvy enough to review this. (i.e. I've been able to install this package but not successfully run it so far.)

moorepants commented 6 years ago

@devinberg If you can report the issue you have, I can try to improve the installation documentation. Thanks!

moorepants commented 6 years ago

Here is Dr. Martin Mossner's email: martin.moessner@uibk.ac.at

moorepants commented 6 years ago

Note that Devin and I fixed the Windows install issues and that should all work as expected now.

moorepants commented 6 years ago

@whedon generate pdf

whedon commented 6 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 6 years ago

--> Check article proof :page_facing_up: <--

moorepants commented 6 years ago

@whedon generate pdf

whedon commented 6 years ago
Attempting PDF compilation. Reticulating splines etc...
moorepants commented 6 years ago

This is compiling fine now and ready for review. Thanks.

whedon commented 6 years ago

--> Check article proof :page_facing_up: <--

moorepants commented 6 years ago

Are there any status updates on finding reviewers? Here are our consolidated suggestions:

Kevin-Mattheus-Moerman commented 6 years ago

Thanks @moorepants I've invited Brown and Moessner via email. I'll let you know if I hear back from them.

Kevin-Mattheus-Moerman commented 6 years ago

@trallard @CELavecchia would you be interested in reviewing this JOSS submission? Thanks

trallard commented 6 years ago

Hi! Apologies for the late reply. I would be happy to do this review, however, I am about to go on very much needed annual leave. If this can wait until the 8th of July I would be happy to pick it up then

Kevin-Mattheus-Moerman commented 6 years ago

@whedon assign @trallard as reviewer

whedon commented 6 years ago

OK, the reviewer is @trallard

Kevin-Mattheus-Moerman commented 6 years ago

Great @trallard. We'll start sooner if other reviewers join sooner but I'll ping you around the 8th of July. Enjoy your annual leave! :beach_umbrella:

trallard commented 6 years ago

Great! I will keep an eye here then

Kevin-Mattheus-Moerman commented 6 years ago

I have not had luck finding other reviewers. I have e-mailed @moorepants 's suggested reviewers but have not heard back from them yet.

moorepants commented 6 years ago

I just found this paper, maybe one of these authors would be interested:

https://www.researchgate.net/publication/323152326_Robust_Trajectory_Optimization_of_a_Ski_Jumper_for_Uncertainty_Influence_and_Safety_Quantification

trallard commented 6 years ago

@Kevin-Mattheus-Moerman do you still need reviewers for this? I am slowly easing back into work after my leave so I could pick this up if needed be

Kevin-Mattheus-Moerman commented 6 years ago

@trallard thanks. I think we can get started. If I manage to find more reviewers they can join later.

Kevin-Mattheus-Moerman commented 6 years ago

@whedon start review

whedon commented 6 years ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/818. Feel free to close this issue now!