openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
725 stars 38 forks source link

[PRE REVIEW]: 'SBIAX: Density-estimation simulation-based inference in JAX.' #7429

Open editorialbot opened 2 weeks ago

editorialbot commented 2 weeks ago

Submitting author: !--author-handle-->@homerjed<!--end-author-handle-- (Jed Homer) Repository: https://github.com/homerjed/sbiax Branch with paper.md (empty if default branch): Version: 0.0.9 Editor: Pending Reviewers: Pending Managing EiC: Chris Vernon

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/e4c4fd0dacac8b25e2d07ea4144db314"><img src="https://joss.theoj.org/papers/e4c4fd0dacac8b25e2d07ea4144db314/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/e4c4fd0dacac8b25e2d07ea4144db314/status.svg)](https://joss.theoj.org/papers/e4c4fd0dacac8b25e2d07ea4144db314)

Author instructions

Thanks for submitting your paper to JOSS @homerjed. Currently, there isn't a JOSS editor assigned to your paper.

@homerjed if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 2 weeks ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 2 weeks ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.04 s (1089.3 files/s, 155006.7 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          30            555            748           2116
Jupyter Notebook                 3              0           1100            536
YAML                             3             20              8            170
Markdown                         2             71              0            151
TeX                              1             17              0            145
TOML                             1              3              0             52
-------------------------------------------------------------------------------
SUM:                            40            666           1856           3170
-------------------------------------------------------------------------------

Commit count by author:

    43  homerjed
editorialbot commented 2 weeks ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

βœ… OK DOIs

- 10.5281/zenodo.10402073 is OK
- 10.1073/pnas.1912789117 is OK
- 10.1093/mnras/stz1960 is OK

🟑 SKIP DOIs

- No DOI given, and none found for title: Variational Inference with Normalizing Flows
- No DOI given, and none found for title: FFJORD: Free-form Continuous Dynamics for Scalable...
- No DOI given, and none found for title: Neural Ordinary Differential Equations
- No DOI given, and none found for title: BlackJAX: Composable Bayesian inference in JAX
- No DOI given, and none found for title: Masked Autoregressive Flow for Density Estimation
- No DOI given, and none found for title: Flow Matching for Generative Modeling
- No DOI given, and none found for title: Optuna: A Next-Generation Hyperparameter Optimizat...
- No DOI given, and none found for title: Neural Density Estimation and Likelihood-free Infe...
- No DOI given, and none found for title: Automatic Posterior Transformation for Likelihood-...
- No DOI given, and none found for title: JAX: composable transformations of Python+NumPy pr...
- No DOI given, and none found for title: Equinox: neural networks in JAX via callable PyTre...
- No DOI given, and none found for title: The DeepMind JAX Ecosystem
- No DOI given, and none found for title: On Neural Differential Equations
- No DOI given, and none found for title: Simulation-Based Inference Has It’s Own Dodelson-S...

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None
editorialbot commented 2 weeks ago

Paper file info:

πŸ“„ Wordcount for paper.md is 1378

βœ… The paper includes a Statement of need section

editorialbot commented 2 weeks ago

:warning: An error happened when generating the pdf. Problem with ORCID (0000-0000-0000-0000) for Jed Homer. Invalid ORCID.

editorialbot commented 2 weeks ago

License info:

βœ… License found: MIT License (Valid open source OSI approved license)

homerjed commented 2 weeks ago

@editorialbot generate pdf

editorialbot commented 2 weeks ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 2 weeks ago

Five most similar historical JOSS papers:

BayesFlow: Amortized Bayesian Workflows With Neural Networks Submitting author: @marvinschmitt Handling editor: @osorensen (Active) Reviewers: @sandeshkatakam, @LoryPack Similarity score: 0.7750

swyft: Truncated Marginal Neural Ratio Estimation in Python Submitting author: @bkmi Handling editor: @pdebuyl (Active) Reviewers: @mattpitkin, @olgadoronina Similarity score: 0.7672

BlackBIRDS: Black-Box Inference foR Differentiable Simulators Submitting author: @arnauqb Handling editor: @rkurchin (Active) Reviewers: @rajeshrinet, @marvinschmitt Similarity score: 0.7451

flowMC: Normalizing flow enhanced sampling package for probabilistic inference in JAX Submitting author: @kazewong Handling editor: @rkurchin (Active) Reviewers: @matt-graham, @Daniel-Dodd Similarity score: 0.7409

Re-Envisioning Numerical Information Field Theory (NIFTy.re): A Library for Gaussian Processes and Variational Inference Submitting author: @Edenhofer Handling editor: @dfm (Active) Reviewers: @Abinashbunty, @apizzuto Similarity score: 0.7154

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

crvernon commented 1 week ago

@homerjed - I noticed that your repository is only a few weeks old. Can you discuss the timeline of this project a bit here in this thread a bit? Thanks.

homerjed commented 1 week ago

Hi @crvernon,

This repository was pushed from code I wrote in preparation for a project about challenging the use of density estimation SBI in cosmological inference problems.

Whilst it's only a few weeks old I have been working on this code and project for about a year. Now seemed like a good time to push the code and publish (a JOSS paper + astrophysics journal paper) since I want the readers of my paper (to be Arxiv'd in the next week or so) to run my experiments themselves.

Additionally, the code is ideal for further independent SBI analyses and beyond - personally I found other existing codebases unwieldly.

Does that cover it? Let me know, cheers :)

crvernon commented 6 days ago

Thanks @homerjed

crvernon commented 6 days ago

@editorialbot invite @RMeli as editor

:wave: @RMeli are you able to take this one on as editor?

editorialbot commented 6 days ago

Invitation to edit this submission sent!