openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
725 stars 38 forks source link

[PRE REVIEW]: SWMManywhere: Synthesise Urban Drainage Network Models Anywhere in the World #7438

Open editorialbot opened 2 weeks ago

editorialbot commented 2 weeks ago

Submitting author: !--author-handle-->@barneydobson<!--end-author-handle-- (Barnaby Dobson) Repository: https://github.com/ImperialCollegeLondon/SWMManywhere Branch with paper.md (empty if default branch): Version: 0.1.10 Editor: Pending Reviewers: Pending Managing EiC: Kristen Thyng

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/b9901c3b612b995bf6977377b65f368a"><img src="https://joss.theoj.org/papers/b9901c3b612b995bf6977377b65f368a/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/b9901c3b612b995bf6977377b65f368a/status.svg)](https://joss.theoj.org/papers/b9901c3b612b995bf6977377b65f368a)

Author instructions

Thanks for submitting your paper to JOSS @barneydobson. Currently, there isn't a JOSS editor assigned to your paper.

@barneydobson if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 2 weeks ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 2 weeks ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.09 s (1041.1 files/s, 170675.5 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          49           2066           3035           6395
XML                              1              0             52           1534
Markdown                        24            291              0           1070
YAML                            13             43             16            690
TeX                              1             12              2            322
TOML                             1             14              0            151
JSON                             5              1              0             28
CSS                              1              2              0             13
Bourne Shell                     1              0              0              1
-------------------------------------------------------------------------------
SUM:                            96           2429           3105          10204
-------------------------------------------------------------------------------

Commit count by author:

   600  Dobson
   279  barneydobson
    46  dependabot[bot]
    34  Diego Alonso Alvarez
    24  pre-commit-ci[bot]
    13  Tom Bland
     5  Daniel Cummins
     3  Barnaby Dobson
     2  James Paul Turner
     1  AadiUJ
     1  Adrian D'Alessandro
     1  Dan Cummins
     1  Diego Alonso Álvarez
editorialbot commented 2 weeks ago

Paper file info:

📄 Wordcount for paper.md is 854

✅ The paper includes a Statement of need section

editorialbot commented 2 weeks ago

License info:

✅ License found: BSD 3-Clause "New" or "Revised" License (Valid open source OSI approved license)

editorialbot commented 2 weeks ago

:warning: An error happened when generating the pdf. Problem with ORCID (https://orcid.org/0000-0002-0149-4124) for Barnaby Dobson. ORCID looks to be the wrong length.

editorialbot commented 2 weeks ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.5194/isprs-archives-XLI-B4-125-2016 is OK
- 10.1016/j.compenvurbsys.2017.05.004 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Modelling transitions in urban water systems
- No DOI given, and none found for title: Google-Microsoft Open Buildings
- No DOI given, and none found for title: Planet dump retrieved from https://planet.osm.org 
- No DOI given, and none found for title: Overture Maps Foundation

❌ MISSING DOIs

- 10.1007/s12665-011-1146-1 may be a valid DOI for title: Sewer model development under minimum data require...
- 10.1016/j.compenvurbsys.2019.101370 may be a valid DOI for title: Automatic mapping of urban wastewater networks bas...
- 10.1029/2021wr030778 may be a valid DOI for title: A reduced complexity model with graph partitioning...
- 10.1016/j.jhydrol.2018.11.005 may be a valid DOI for title: Identifying fit-for-purpose lumped surrogate model...
- 10.5194/hess-26-4279-2022 may be a valid DOI for title: An algorithm for deriving the topology of belowgro...
- 10.3390/w15010046 may be a valid DOI for title: An evaluation framework for urban pluvial flooding...
- 10.31223/x5gt5x may be a valid DOI for title: SWMManywhere: A global-scale workflow for generati...
- 10.3389/fenvs.2021.626634 may be a valid DOI for title: Data reduced method for cost comparison of wastewa...

❌ INVALID DOIs

- None
kthyng commented 2 weeks ago

👋 @barneydobson - note that your paper does not compile. Please follow the example paper and note that you can click on the error above to find out more about it. Then use the command @editorialbot check references to check again, and the command @editorialbot generate pdf after making changes to the .md file to make a new PDF. editorialbot commands need to be the first entry in a new comment.

barneydobson commented 2 weeks ago

@editorialbot check references

Thanks @kthyng - TIL mendeley bibtex export doesn't include DOI 🤦‍♂️

editorialbot commented 2 weeks ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1007/s12665-011-1146-1 is OK
- 10.1016/j.compenvurbsys.2019.101370 is OK
- 10.1029/2021wr030778 is OK
- 10.1016/j.watres.2017.09.039 is OK
- 10.1016/j.jhydrol.2018.11.005 is OK
- 10.5194/hess-26-4279-2022 is OK
- 10.3390/w15010046 is OK
- 10.31223/X5GT5X is OK
- 10.3389/fenvs.2021.626634 is OK
- 10.5194/isprs-archives-XLI-B4-125-2016 is OK
- 10.1016/j.compenvurbsys.2017.05.004 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Google-Microsoft Open Buildings
- No DOI given, and none found for title: Planet dump retrieved from https://planet.osm.org 
- No DOI given, and none found for title: Overture Maps Foundation

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None
barneydobson commented 2 weeks ago

@editorialbot generate pdf

editorialbot commented 2 weeks ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 2 weeks ago

Five most similar historical JOSS papers:

PySWMM: The Python Interface to Stormwater Management Model (SWMM) Submitting author: @katmratliff Handling editor: @kbarnhart (Retired) Reviewers: @nickrsan, @jrkasprzyk Similarity score: 0.7639

VisWaterNet: A Python package for visualization of water distribution networks Submitting author: @meghnathomas Handling editor: @crvernon (Active) Reviewers: @erexer, @thurber Similarity score: 0.7314

NeuralHydrology --- A Python library for Deep Learning research in hydrology Submitting author: @kratzert Handling editor: @elbeejay (Active) Reviewers: @ammilten, @chuckaustin, @jhamman Similarity score: 0.7152

pyflowline: a mesh-independent river network generator for hydrologic models Submitting author: @changliao1025 Handling editor: @observingClouds (Active) Reviewers: @smchartrand, @andres-patrignani Similarity score: 0.7145

HyRiver: Hydroclimate Data Retriever Submitting author: @cheginit Handling editor: @kthyng (Active) Reviewers: @raoulcollenteur, @arbennett Similarity score: 0.6980

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

kthyng commented 1 week ago

@barneydobson Thanks!

Hi @barneydobson and thanks for your submission! I am looking for some specific items to make sure your submission fits our requirements at a high level (not at the more detailed review level) before moving on to finding an editor or putting this on our waitlist if no relevant editors are available. I'll comment over time as I have a chance to go through them:

In the meantime, please take a look at the comments above ⬆️ from the editorialbot to address any DOI, license, or paper issues if you're able (there may not be any), or suggest reviewers. For reviewers, please suggest 5 reviewers from the database listed above or your own (non-conflicted) extended network. Their github handles are most useful to receive but please don't use "@" to reference them since it will prematurely ping them.