openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
725 stars 38 forks source link

[PRE REVIEW]: DeepSZSim: A Python code for fast, tunable Sunyaev–Zeldovich effect submap simulations #7439

Open editorialbot opened 2 weeks ago

editorialbot commented 2 weeks ago

Submitting author: !--author-handle-->@evavagiakis<!--end-author-handle-- (Eve Vavagiakis) Repository: https://github.com/deepskies/DeepSZSim Branch with paper.md (empty if default branch): main Version: v0.1.1 Editor: Pending Reviewers: Pending Managing EiC: Warrick Ball

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/07dda69a336c2da7037499607d094e78"><img src="https://joss.theoj.org/papers/07dda69a336c2da7037499607d094e78/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/07dda69a336c2da7037499607d094e78/status.svg)](https://joss.theoj.org/papers/07dda69a336c2da7037499607d094e78)

Author instructions

Thanks for submitting your paper to JOSS @evavagiakis. Currently, there isn't a JOSS editor assigned to your paper.

@evavagiakis if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 2 weeks ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 2 weeks ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.03 s (1246.0 files/s, 171733.7 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          16            234            782            833
TeX                              1             33              0            429
Jupyter Notebook                 3              0           1628            320
Markdown                         2             60              0            133
YAML                             6             17              6            130
reStructuredText                 4             35             59             39
TOML                             1              4              0             27
DOS Batch                        1              8              1             26
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                            35            395           2483           1946
-------------------------------------------------------------------------------

Commit count by author:

   112  samueldmcdermott
    61  Brian Nord
    47  Kush Banker
    43  Elaine Ran
    42  evavagiakis
    27  Sam McDermott
    26  Helen Tan
    19  Brian-Zzzz
    15  IoanaCristescu15
     7  Isabella Vesely
     7  elaineran
     2  Rodisolomon
     2  maryanne xu
     2  maryannex
     1  Julia
     1  kbanker
editorialbot commented 2 weeks ago

Paper file info:

📄 Wordcount for paper.md is 1519

✅ The paper includes a Statement of need section

editorialbot commented 2 weeks ago

License info:

✅ License found: MIT License (Valid open source OSI approved license)

editorialbot commented 2 weeks ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1051/0004-6361/201833910 is OK
- 10.1086/309179 is OK
- 10.1088/1475-7516/2012/04/027 is OK
- 10.1093/mnras/stz093 is OK
- 10.1086/341110 is OK
- 10.1103/PhysRevD.55.1830 is OK
- 10.1103/PhysRevD.52.4307 is OK
- 10.1088/0004-637X/758/2/75 is OK
- 10.1186/s40668-019-0028-x is OK
- 10.3847/1538-4365/abfcc4 is OK
- 10.1051/0004-6361/201833910 is OK
- 10.3847/1538-4365/aaee8c is OK
- 10.1051/0004-6361/201322068 is OK
- 10.1007/s11214-008-9316-5 is OK
- 10.1103/PhysRevD.104.123521 is OK
- 10.1088/1475-7516/2022/08/029 is OK
- 10.1093/mnras/stac438 is OK
- 10.1093/pasj/64.5.102 is OK
- 10.1088/0004-637X/709/2/920 is OK
- 10.1093/mnras/stz093 is OK
- 10.1088/1475-7516/2011/07/034 is OK
- 10.48550/arXiv.2310.18482 is OK
- 10.48550/arXiv.1104.2932 is OK
- 10.1086/164143 is OK
- 10.1086/192267 is OK
- 10.1038/380603a0 is OK
- 10.1051/0004-6361/200913416 is OK
- 10.1093/mnras/222.2.323 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: CMB Analysis Summer School Notebooks
- No DOI given, and none found for title: pixell

❌ MISSING DOIs

- None

❌ INVALID DOIs

- 2020100515130300 is INVALID
editorialbot commented 2 weeks ago

:warning: An error happened when generating the pdf. Problem with ORCID (0000-0000-0000-0000) for Samantha Usman. Invalid ORCID.

warrickball commented 2 weeks ago

Hi @evavagiakis, thanks for your submission! Given the small size of this code base, I'm going to submit your article for editorial review on whether it meets JOSS's requirements for "substantial scholarly effort". This usually takes a week or two and I'll report back here as soon as I hear back from the rest of the editorial board.

Thanks for your patience!

warrickball commented 2 weeks ago

@editorialbot query scope

editorialbot commented 2 weeks ago

Submission flagged for editorial review.

warrickball commented 1 week ago

@evavagiakis — Would you mind fixing Samantha Usman's ORCID, which is currently causing the compilation failure for the paper? Once you've done so, you can comment with @editorialbot generate pdf to try again. It'll be easier for editors to assess the scope of this submission if we can compile the paper.

evavagiakis commented 1 week ago

Hi @warrickball, thanks very much and I have fixed Samantha Usman's ORCID and will now try generating the PDF again.

In response to the comment on the code base size, I wanted to note that this work summarizes two years of effort (including two summers of group undergraduate research) from our Deep Skies Collaboration working group to create the fast and flexible simulations needed for our ML research and validate them with real data. Our group is particularly proud of the fact that we are now able to generate large numbers of simulated galaxy halos in a manner that fills an unmet need in the field. We want to point out that this code has been used for a forthcoming paper on SBI which will be submitted to a journal, as one example of how it will be useful to our peers.

evavagiakis commented 1 week ago

@editorialbot generate pdf

editorialbot commented 1 week ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 1 week ago

Five most similar historical JOSS papers:

deeplenstronomy: A dataset simulation package for strong gravitational lensing Submitting author: @rmorgan10 Handling editor: @pdebuyl (Active) Reviewers: @shreyasbapat, @jiwoncpark Similarity score: 0.7466

limHaloPT: A Numerical Package for Accurate Modeling of Line Intensity Power Spectrum Submitting author: @amoradinejad Handling editor: @eloisabentivegna (Retired) Reviewers: @ziotom78, @abhimaniyar Similarity score: 0.7464

Simulating instrumental systematics of Cosmic Microwave Background experiments with s4cmb Submitting author: @JulienPeloton Handling editor: @mbobra (Active) Reviewers: @Christovis, @changhoonhahn Similarity score: 0.7424

The Python Sky Model 3 software Submitting author: @zonca Handling editor: @christinahedges (Retired) Reviewers: @patricialarsen, @smsharma Similarity score: 0.7418

SkyPy: A package for modelling the Universe Submitting author: @rrjbca Handling editor: @arfon (Active) Reviewers: @cescalara, @rmorgan10 Similarity score: 0.7377

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

warrickball commented 5 days ago

Hi @evavagiakis ­— The editorial team has agreed that this is suitable for JOSS review, so we'll proceed as usual. For now that means waiting for an editor to become available, so I'll place this on our waiting list. Thanks for your patience!

evavagiakis commented 3 days ago

Thank you @warrickball! We will stand by!