search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
725 stars 38 forks source link

[REVIEW]: XCALibre.jl: an XPU unstructured finite volume Computational Fluid Dynamics library #7441

Open editorialbot opened 1 week ago

editorialbot commented 1 week ago

Submitting author: !--author-handle-->@mberto79<!--end-author-handle-- (Humberto Medina) Repository: https://github.com/mberto79/XCALibre.jl Branch with paper.md (empty if default branch): joss-submission Version: v0.3.1 Editor: !--editor-->@AnjaliSandip<!--end-editor-- Reviewers: @vlc1, @simone-silvestri Archive: Pending

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/bc56dc3d49d6216ca3c01f3ad74f6a7d"><img src="https://joss.theoj.org/papers/bc56dc3d49d6216ca3c01f3ad74f6a7d/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/bc56dc3d49d6216ca3c01f3ad74f6a7d/status.svg)](https://joss.theoj.org/papers/bc56dc3d49d6216ca3c01f3ad74f6a7d)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@vlc1 & @simone-silvestri, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @AnjaliSandip know.

✹ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✹

Checklists

@vlc1, please create your checklist typing: @editorialbot generate my checklist

@simone-silvestri, please create your checklist typing: @editorialbot generate my checklist

editorialbot commented 1 week ago

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 1 week ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.22 s (951.6 files/s, 131906.8 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Julia                          168           3602           3294          15344
CSV                              4              0              0           2508
Markdown                        22            759              0           2251
SVG                              4              0              0            525
TeX                              1             19              0            190
GLSL                             3             22             35            120
YAML                             3              3              5             86
TOML                             3              5              0             63
-------------------------------------------------------------------------------
SUM:                           208           4410           3334          21087
-------------------------------------------------------------------------------

Commit count by author:

   842  Humberto
   313  OscarOsborn
   246  TomMazin
   157  mberto79
   143  Humberto Medina
    53  Christopher D. Ellis
     4  Tim
     1  s-ambrose-9
editorialbot commented 1 week ago

Paper file info:

📄 Wordcount for paper.md is 1555

✅ The paper includes a Statement of need section

editorialbot commented 1 week ago

License info:

✅ License found: Mozilla Public License 2.0 (Valid open source OSI approved license)

editorialbot commented 1 week ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.21105/joss.00602 is OK
- 10.5281/zenodo.7808904 is OK
- 10.1007/s12532-023-00239-3 is OK
- 10.21105/joss.02018 is OK
- 10.1016/j.jcp.2021.110467 is OK
- 10.2514/3.10041 is OK
- 10.21105/joss.05187 is OK
- 10.1063/5.0166685 is OK
- 10.1016/j.ijheatmasstransfer.2024.126150 is OK
- 10.1175/1520-0493(1963)091<0099:GCEWTP>2.3.CO;2 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Open Field Operation and Manipulation
- No DOI given, and none found for title: SU2
- No DOI given, and none found for title: CODE_SATURN
- No DOI given, and none found for title: Differentialequations.jl–a performant and feature-...
- No DOI given, and none found for title: Knet
- No DOI given, and none found for title: Instead of Rewriting Foreign Code for Machine Lear...
- No DOI given, and none found for title: WaterLily.jl: A differentiable and backend-agnosti...

❌ MISSING DOIs

- 10.1079/cabicompendium.102342 may be a valid DOI for title: Gerris

❌ INVALID DOIs

- https://doi.org/10.1016/j.ijheatfluidflow.2017.12.008 is INVALID because of 'https://doi.org/' prefix
editorialbot commented 1 week ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left: