openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
721 stars 38 forks source link

[PRE REVIEW]: MQT Core: The Backbone of the Munich Quantum Toolkit (MQT) #7446

Closed editorialbot closed 1 hour ago

editorialbot commented 2 days ago

Submitting author: !--author-handle-->@burgholzer<!--end-author-handle-- (Lukas Burgholzer) Repository: https://github.com/cda-tum/mqt-core Branch with paper.md (empty if default branch): joss-paper Version: v2.7.0 Editor: !--editor-->@danielskatz<!--end-editor-- Reviewers: @1ucian0, @edyounis, @josh146 Managing EiC: Daniel S. Katz

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/c90c6b84d6b4227af9d7219c51a9410a"><img src="https://joss.theoj.org/papers/c90c6b84d6b4227af9d7219c51a9410a/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/c90c6b84d6b4227af9d7219c51a9410a/status.svg)](https://joss.theoj.org/papers/c90c6b84d6b4227af9d7219c51a9410a)

Author instructions

Thanks for submitting your paper to JOSS @burgholzer. Currently, there isn't a JOSS editor assigned to your paper.

@burgholzer if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 2 days ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 2 days ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1109/TCAD.2020.3032630 is OK
- 10.1007/978-3-030-79837-6_14 is OK
- 10.23919/DATE54114.2022.9774631 is OK
- 10.1109/QCE52317.2021.00037 is OK
- 10.1109/ASP-DAC47756.2020.9045153 is OK
- 10.1109/ASP-DAC52403.2022.9712555 is OK
- 10.1109/DAC18072.2020.9218563 is OK
- 10.1145/3394885.3431590 is OK
- 10.1109/TCAD.2022.3197969 is OK
- 10.1109/QCE49297.2020.00051 is OK
- 10.1145/3505636 is OK
- 10.22331/q-2020-06-04-279 is OK
- 10.1109/VLSID57277.2023.00068 is OK
- 10.1145/3400302.3415622 is OK
- 10.1109/TCAD.2022.3182628 is OK
- 10.23919/DATE51398.2021.9474135 is OK
- 10.23919/DATE51398.2021.9474034 is OK
- 10.1145/3530776 is OK
- 10.1109/ASP-DAC47756.2020.9045711 is OK
- 10.1145/3394885.3431604 is OK
- 10.1109/DAC18072.2020.9218555 is OK
- 10.1109/QCE57702.2023.00095 is OK
- 10.1145/3489517.3530480 is OK
- 10.1145/3566097.3567932 is OK
- 10.1109/JETCAS.2022.3202204 is OK
- 10.1145/3593594 is OK
- 10.48550/arXiv.2405.08810 is OK
- 10.1109/QCE57702.2023.00039 is OK
- 10.1088/2058-9565/ad33ac is OK
- 10.48550/arXiv.2311.14164 is OK
- 10.1145/3566097.3567929 is OK
- 10.48550/arXiv.2012.13966 is OK
- 10.1007/978-3-031-15699-1_1 is OK
- 10.1109/ISCAS45731.2020.9180791 is OK
- 10.1109/QSW62656.2024.00013 is OK
- 10.1145/3491246 is OK
- 10.1007/978-981-15-6401-7_43-1 is OK
- 10.23919/DATE51398.2021.9474236 is OK

🟡 SKIP DOIs

- None

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None
editorialbot commented 2 days ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.18 s (1638.5 files/s, 329825.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
C++                            120           3917           1474          27688
C/C++ Header                    84           2025           2159          11392
Python                          16           1011           1719           2172
CMake                           32            218            219           1125
Markdown                        14            327              0            837
YAML                            13             50             44            586
TeX                              2             37              0            318
TOML                             1             43              7            254
JSON                             3              0              0            185
HTML                             1              0              0             76
CSS                              1              4              2             47
JSON5                            1              0              1             37
-------------------------------------------------------------------------------
SUM:                           288           7632           5625          44717
-------------------------------------------------------------------------------

Commit count by author:

   951  Lukas Burgholzer
   403  burgholzer
   329  dependabot[bot]
   121  Tom Peham
   116  pre-commit-ci[bot]
    76  Yannick Stade
    55  Stefan Hillmich
    34  renovate[bot]
    14  Thomas Grurl
    14  pehamTom
     7  Aaron Sander
     6  Martin Fink
     4  HartwigB
     4  github-actions
     4  lsschmid
     3  Berti Florea
     2  33Gjl1Xe
     2  Katrin
     2  Parham Rahimi
     2  Rebecca Ghidini
     2  TeWas
     2  Tianyi Wang
     1  Christoph Pichler
     1  Damian Rovara
     1  Elias Leon Foramitti
     1  Hartwig
     1  JoachimMarin
     1  Roope Salmi
     1  Sarah
     1  Thomas
     1  TobiasPrie
     1  p41540
editorialbot commented 2 days ago

Paper file info:

📄 Wordcount for paper.md is 623

✅ The paper includes a Statement of need section

editorialbot commented 2 days ago

License info:

✅ License found: MIT License (Valid open source OSI approved license)

editorialbot commented 2 days ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 2 days ago

Five most similar historical JOSS papers:

QXTools: A Julia framework for distributed quantum circuit simulation Submitting author: @nmoran Handling editor: @jarvist (Retired) Reviewers: @goerz, @obliviateandsurrender Similarity score: 0.7359

qujax: Simulating quantum circuits with JAX Submitting author: @SamDuffield Handling editor: @lucydot (Active) Reviewers: @jmiszczak, @amitkumarj441, @meandmytram Similarity score: 0.7268

QAOA.jl: Toolkit for the Quantum and Mean-Field Approximate Optimization Algorithms Submitting author: @timbode Handling editor: @danielskatz (Active) Reviewers: @babreu-ncsa, @pkairys, @Abinashbunty Similarity score: 0.7261

Qiskit Experiments: A Python package to characterize and calibrate quantum computers Submitting author: @eggerdj Handling editor: @danielskatz (Active) Reviewers: @nunezco2, @goerz, @TejasAvinashShetty Similarity score: 0.7090

QDistRnd: A GAP package for computing the distance of quantum error-correcting codes Submitting author: @LeonidPryadko Handling editor: @danielskatz (Active) Reviewers: @oscarhiggott, @pan-pavel Similarity score: 0.6872

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

danielskatz commented 2 days ago

👋 @burgholzer - thanks for your submission.

I'll be the editor.

Please suggest ~5 potential reviewers. You can search the list of people that have already agreed to review and may be suitable for this submission. Or people who aren't in the JOSS system would also be ok. If you know their GitHub usernames, then please mention them here in this thread (without tagging them with an @).

danielskatz commented 2 days ago

@editorialbot assign me as editor

editorialbot commented 2 days ago

Assigned! @danielskatz is now the editor

burgholzer commented 1 day ago

👋 @burgholzer - thanks for your submission.

I'll be the editor.

Hey 👋🏼

Thanks for acting as the editor for this submission!

Please suggest ~5 potential reviewers. You can search the list of people that have already agreed to review and may be suitable for this submission. Or people who aren't in the JOSS system would also be ok. If you know their GitHub usernames, then please mention them here in this thread (without tagging them with an @).

I searched through that list, but I didn't find too many suitable people on that list. hanrui-wang would work.

Outside of that list, potential reviewers include:

Hope that works. Let me know if you need further suggestions.

danielskatz commented 1 day ago

👋 @hanrui-wang & @josh146 & @erick-xanadu & @1ucian0 & @edyounis, would a few of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

1ucian0 commented 6 hours ago

Yeap. I'm good with that next week. I'm a first-timer, let me know the timeframe if that does not fit.

edyounis commented 3 hours ago

Yeah, I am happy to, but I am also a first-timer. Would I post a review as a response to the issue here?

josh146 commented 2 hours ago

Hi @danielskatz, happy to as well on my end, but let me know if we have reached saturation on the reviewer side!

danielskatz commented 1 hour ago

Thanks all - I'm happy to have all three of you. I will add you and start the review. Re the questions above, the review is checklist driven, so your main activity is to check items off your list (when I start the review, you will see how to do that). And the timeframe is more or less 2-4 weeks, but the process is iterative, like open source software, with issues and PRs when needed that the author responds.

danielskatz commented 1 hour ago

@editorialbot add @1ucian0 as reviewer

editorialbot commented 1 hour ago

@1ucian0 added to the reviewers list!

danielskatz commented 1 hour ago

@editorialbot add @edyounis as reviewer

editorialbot commented 1 hour ago

@edyounis added to the reviewers list!

danielskatz commented 1 hour ago

@editorialbot add @josh146 as reviewer

editorialbot commented 1 hour ago

@josh146 added to the reviewers list!

danielskatz commented 1 hour ago

@editorialbot start review

editorialbot commented 1 hour ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/7478.