openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
725 stars 38 forks source link

[PRE REVIEW]: Potnia: A Python library for the conversion of transliterated ancient texts to Unicode #7450

Open editorialbot opened 1 week ago

editorialbot commented 1 week ago

Submitting author: !--author-handle-->@etour-unimelb<!--end-author-handle-- (Emily Tour) Repository: https://github.com/AncientNLP/potnia.git Branch with paper.md (empty if default branch): main Version: v0.3.0 Editor: !--editor-->@arfon<!--end-editor-- Reviewers: Pending Managing EiC: Arfon Smith

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/7641150c49e996a21fa0f4dc3aadb258"><img src="https://joss.theoj.org/papers/7641150c49e996a21fa0f4dc3aadb258/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/7641150c49e996a21fa0f4dc3aadb258/status.svg)](https://joss.theoj.org/papers/7641150c49e996a21fa0f4dc3aadb258)

Author instructions

Thanks for submitting your paper to JOSS @etour-unimelb. Currently, there isn't a JOSS editor assigned to your paper.

@etour-unimelb if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 1 week ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 1 week ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.03 s (2045.4 files/s, 187381.9 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
YAML                            20            348            648           2362
Python                          22            220            220            450
TeX                              2             30              0            297
Markdown                         3             94              0            210
reStructuredText                 7            144             90            167
TOML                             1              7              1             37
DOS Batch                        1              8              1             26
Bourne Shell                     2              4              2             19
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                            59            859            969           3577
-------------------------------------------------------------------------------

Commit count by author:

   132  Robert Turnbull
    58  Emily Tour
    38  Kabir Manandhar Shrestha
     7  etour-unimelb
     1  dependabot[bot]
editorialbot commented 1 week ago

Paper file info:

📄 Wordcount for paper.md is 1628

✅ The paper includes a Statement of need section

editorialbot commented 1 week ago

License info:

✅ License found: Apache License 2.0 (Valid open source OSI approved license)

arfon commented 1 week ago

@editorialbot assign me as editor

👋 @samhforbes – I'll take this paper as it's a PyCon AU submission.

editorialbot commented 1 week ago

Assigned! @arfon is now the editor

editorialbot commented 1 week ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1162/coli_a_00481 is OK
- 10.1109/MAHC.2024.3351948 is OK
- 10.5281/zenodo.10021513 is OK
- 10.5281/zenodo.5090923 is OK
- 10.18653/v1/P19-1303 is OK
- 10.1145/3593431 is OK
- 10.1073/pnas.2003794117 is OK
- 10.36824/2020-graf-cacc is OK
- 10.1016/j.sbspro.2015.07.415 is OK
- 10.1108/eb026567 is OK
- 10.1080/00437956.1953.11659466 is OK
- 10.21105/joss.04886 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Image and Interpretation: Using Artificial Intelli...
- No DOI given, and none found for title: A Dataset of Mycenaean Linear B Sequences
- No DOI given, and none found for title: Sefaria: A Living Library of Jewish Texts Online
- No DOI given, and none found for title: Transliterating English in Arabic
- No DOI given, and none found for title: Documents in Mycenaean Greek
- No DOI given, and none found for title: Cuneify
- No DOI given, and none found for title: UnicodeConverter
- No DOI given, and none found for title: Anatolian Hieroglyphics (Luwian) generation
- No DOI given, and none found for title: The Ras Shamra Tablet Inventory
- No DOI given, and none found for title: Cuneiform Digital Library Initiative
- No DOI given, and none found for title: DIN 31635: Transliteration of the Arabic alphabet

❌ MISSING DOIs

- None

❌ INVALID DOIs

- doi:10.1515/zac-2020-0018 is INVALID (failed connection)
arfon commented 1 week ago

@etour-unimelb – due to the relatively small size of this code, the editors will now discuss if it meets the substantial scholarly effort criterion for review by JOSS. We should get back to you sometime next week.

editorialbot commented 1 week ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

arfon commented 1 week ago

@editorialbot query scope

editorialbot commented 1 week ago

Submission flagged for editorial review.

editorialbot commented 1 week ago

Five most similar historical JOSS papers:

UralicNLP: An NLP Library for Uralic Languages Submitting author: @mikahama Handling editor: @gkthiruvathukal (Active) Reviewers: @gweissman Similarity score: 0.6503

Inscriptis - A Python-based HTML to text conversion library optimized for knowledge extraction from the Web Submitting author: @AlbertWeichselbraun Handling editor: @sbenthall (Active) Reviewers: @reality, @rlskoeser Similarity score: 0.6275

teiphy: A Python Package for Converting TEI XML Collations to NEXUS and Other Formats Submitting author: @jjmccollum Handling editor: @majensen (Active) Reviewers: @tresoldi, @SimonGreenhill Similarity score: 0.6215

Crowsetta: A Python tool to work with any format for annotating animal vocalizations and bioacoustics data. Submitting author: @NickleDave Handling editor: @oliviaguest (Active) Reviewers: @oliviaguest Similarity score: 0.6214

Phonemizer: Text to Phones Transcription for Multiple Languages in Python Submitting author: @mmmaat Handling editor: @danielskatz (Active) Reviewers: @henrykironde, @chrisbrickhouse Similarity score: 0.6138

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

rbturnbull commented 3 days ago

@etour-unimelb – due to the relatively small size of this code, the editors will now discuss if it meets the substantial scholarly effort criterion for review by JOSS. We should get back to you sometime next week.

Dear @arfon - thanks for the message. Sorry we didn't respond until now. Yes, the code only has about 425 lines of Python code (in the main package plus tests). But a lot of the work in the project is in the YAML files which tell the package how to run and this is more than 2000 lines of code. We designed it so that YAML reduces the amount of code needed in Python and also makes it more accessible for domain experts to work with different languages. The PyConAU mentor team who did a pre-review of the code made a note about this in their recommendations to JOSS. Do you have their recommendation letter?

rbturnbull commented 3 days ago

I've fixed the broken DOI now.