openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
725 stars 38 forks source link

[PRE REVIEW]: pykoop: a Python Library for Koopman Operator Approximation #7451

Open editorialbot opened 1 week ago

editorialbot commented 1 week ago

Submitting author: !--author-handle-->@sdahdah<!--end-author-handle-- (Steven Dahdah) Repository: https://github.com/decargroup/pykoop Branch with paper.md (empty if default branch): paper Version: v2.0.1 Editor: Pending Reviewers: Pending Managing EiC: Arfon Smith

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/9f06e8db0de47aa49b55596155ab3cd5"><img src="https://joss.theoj.org/papers/9f06e8db0de47aa49b55596155ab3cd5/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/9f06e8db0de47aa49b55596155ab3cd5/status.svg)](https://joss.theoj.org/papers/9f06e8db0de47aa49b55596155ab3cd5)

Author instructions

Thanks for submitting your paper to JOSS @sdahdah. Currently, there isn't a JOSS editor assigned to your paper.

@sdahdah if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 1 week ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 1 week ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

āœ… OK DOIs

- 10.1098/rspa.2022.0162 is OK
- 10.1088/2632-2153/ad45b0 is OK
- 10.5281/zenodo.5576490 is OK

šŸŸ” SKIP DOIs

- No DOI given, and none found for title: Scikit-learn: Machine Learning in Python
- No DOI given, and none found for title: DLKoopman: A deep learning software package for Ko...
- No DOI given, and none found for title: \textttMachine-Learning-Dynamical-Systems/kooplear...
- No DOI given, and none found for title: Forward-Backward Extended DMD with an Asymptotic S...
- No DOI given, and none found for title: Uncertainty Modelling and Robust Observer Synthesi...
- No DOI given, and none found for title: Asymptotically Stable Data-Driven Koopman Operator...

āŒ MISSING DOIs

- 10.21105/joss.05881 may be a valid DOI for title: PyKoopman: A Python Package for Data-Driven Approx...

āŒ INVALID DOIs

- None
editorialbot commented 1 week ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.12 s (563.4 files/s, 189093.9 lines/s)
--------------------------------------------------------------------------------
Language                      files          blank        comment           code
--------------------------------------------------------------------------------
Python                           34           1556           5402          11480
Jupyter Notebook                  8              0           2246            639
reStructuredText                  6            176            228            297
Markdown                          6             70              0            235
YAML                              7              1              5            159
TeX                               2             16              0            153
Bourne Again Shell                1             11             38             34
DOS Batch                         1              8              1             26
INI                               2              1              0             19
make                              1              4              7              9
--------------------------------------------------------------------------------
SUM:                             68           1843           7927          13051
--------------------------------------------------------------------------------

Commit count by author:

   622  Steven Dahdah
     1  James Forbes
editorialbot commented 1 week ago

Paper file info:

šŸ“„ Wordcount for paper.md is 615

āœ… The paper includes a Statement of need section

editorialbot commented 1 week ago

License info:

āœ… License found: MIT License (Valid open source OSI approved license)

editorialbot commented 1 week ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 1 week ago

Five most similar historical JOSS papers:

ddop: A python package for data-driven operations management Submitting author: @AndreasPhilippi Handling editor: @arfon (Active) Reviewers: @kramea, @g4brielvs Similarity score: 0.7608

dfba: Software for efficient simulation of dynamic flux-balance analysis models in Python Submitting author: @davidtourigny Handling editor: @marcosvital (Active) Reviewers: @jdbrunner, @pstjohn, @synchon Similarity score: 0.7265

Simulation Decomposition in Python Submitting author: @tupui Handling editor: @crvernon (Active) Reviewers: @JoshuaOsborneDATA, @matt-graham Similarity score: 0.7171

giotto-deep: A Python Package for Topological Deep Learning Submitting author: @matteocao Handling editor: @osorensen (Active) Reviewers: @EduPH, @leotrs, @ismailguzel Similarity score: 0.7129

PySPOD: A Python package for Spectral Proper Orthogonal Decomposition (SPOD) Submitting author: @mengaldo Handling editor: @eloisabentivegna (Retired) Reviewers: @albertonogueira, @joao-l-s-almeida, @jdmoorman Similarity score: 0.7094

āš ļø Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

arfon commented 1 week ago

@sdahdah - thanks for your submission to JOSS. We're currently managing a large backlog of submissions and the editor most appropriate for your area is already rather busy.

For now, we will need to waitlist this paper and process it as the queue reduces. Thanks for your patience!

If you want to fix the DOIs (noting that @editorialbot's suggestions are not always right), you can, then use the following commands (one at a time, as the first line of a new comment) to regenerate the PDF and check the references.

@editorialbot generate pdf @editorialbot check references

sdahdah commented 1 week ago

Thank you, I will fix the DOIs in the meantime.

sdahdah commented 1 week ago

@editorialbot generate pdf

editorialbot commented 1 week ago

:warning: An error happened when generating the pdf.

sdahdah commented 1 week ago

@editorialbot generate pdf

editorialbot commented 1 week ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 1 week ago

Five most similar historical JOSS papers:

ddop: A python package for data-driven operations management Submitting author: @AndreasPhilippi Handling editor: @arfon (Active) Reviewers: @kramea, @g4brielvs Similarity score: 0.7618

dfba: Software for efficient simulation of dynamic flux-balance analysis models in Python Submitting author: @davidtourigny Handling editor: @marcosvital (Active) Reviewers: @jdbrunner, @pstjohn, @synchon Similarity score: 0.7265

Simulation Decomposition in Python Submitting author: @tupui Handling editor: @crvernon (Active) Reviewers: @JoshuaOsborneDATA, @matt-graham Similarity score: 0.7222

PySPOD: A Python package for Spectral Proper Orthogonal Decomposition (SPOD) Submitting author: @mengaldo Handling editor: @eloisabentivegna (Retired) Reviewers: @albertonogueira, @joao-l-s-almeida, @jdmoorman Similarity score: 0.7160

giotto-deep: A Python Package for Topological Deep Learning Submitting author: @matteocao Handling editor: @osorensen (Active) Reviewers: @EduPH, @leotrs, @ismailguzel Similarity score: 0.7157

āš ļø Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

sdahdah commented 1 week ago

@editorialbot check references

editorialbot commented 1 week ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

āœ… OK DOIs

- 10.21105/joss.05881 is OK
- 10.1098/rspa.2022.0162 is OK
- 10.1088/2632-2153/ad45b0 is OK
- 10.48550/arXiv.2403.10623 is OK
- 10.48550/arXiv.2410.01057 is OK
- 10.48550/arXiv.2408.16846 is OK
- 10.5281/zenodo.5576490 is OK

šŸŸ” SKIP DOIs

- No DOI given, and none found for title: Scikit-learn: Machine Learning in Python
- No DOI given, and none found for title: DLKoopman: A deep learning software package for Ko...
- No DOI given, and none found for title: Machine-Learning-Dynamical-Systems/kooplearn v1.1....

āŒ MISSING DOIs

- None

āŒ INVALID DOIs

- None
sdahdah commented 1 week ago

The remaining references do not have DOIs as far as I can tell.

danielskatz commented 2 days ago

šŸ‘‹ @diehlpk - Do you think you could edit this submission?

danielskatz commented 2 days ago

@editorialbot invite @diehlpk as editor

editorialbot commented 2 days ago

Invitation to edit this submission sent!

danielskatz commented 1 day ago

šŸ‘‹ @drvinceknight - Do you think you could edit this submission?

danielskatz commented 1 day ago

@editorialbot invite @drvinceknight as editor

editorialbot commented 1 day ago

Invitation to edit this submission sent!