[PRE REVIEW]: Parallel Implementation of Continuum Damage Mechanics Simulations using FEM and MATLAB

editorialbot commented 1 week ago

Submitting author: !--author-handle-->@Habiba-Eldababy@diehlpk<!--end-editor-- Reviewers: Pending Managing EiC: Arfon Smith

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/14264ce4699f0fccc0a41d19c2f9ada7"><img src="https://joss.theoj.org/papers/14264ce4699f0fccc0a41d19c2f9ada7/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/14264ce4699f0fccc0a41d19c2f9ada7/status.svg)](https://joss.theoj.org/papers/14264ce4699f0fccc0a41d19c2f9ada7)

Author instructions

Thanks for submitting your paper to JOSS @Habiba-Eldababy. Currently, there isn't a JOSS editor assigned to your paper.

@Habiba-Eldababy if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands

editorialbot commented 1 week ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

editorialbot commented 1 week ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1115/1.3101670 is OK
- 10.1007/s00466-024-02473-5 is OK
- 10.1016/j.cma.2022.115766 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Choose Between Thread-Based and Process-Based Envi...
- No DOI given, and none found for title: Compare Performance of parfor, parfeval, and spmd
- No DOI given, and none found for title: spmd - Execute code in parallel on workers of para...
- No DOI given, and none found for title: parfor – Execute for-loop iterations in parallel o...

❌ MISSING DOIs

- 10.1007/978-3-642-18255-6 may be a valid DOI for title: A course on damage mechanics
- 10.1615/intjmultcompeng.v6.i3.50 may be a valid DOI for title: A nonlinear dual-domain decomposition method: Appl...

❌ INVALID DOIs

- None

editorialbot commented 1 week ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.04 s (1561.3 files/s, 108850.5 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
MATLAB                          60            891           1072           2324
TeX                              1              8              0             62
Markdown                         2             24              0             57
YAML                             1              1              4             19
-------------------------------------------------------------------------------
SUM:                            64            924           1076           2462
-------------------------------------------------------------------------------

Commit count by author:

    22  Habiba-Eldababy

editorialbot commented 1 week ago

Paper file info:

📄 Wordcount for paper.md is 1445

🔴 Failed to discover a Statement of need section in paper

editorialbot commented 1 week ago

License info:

✅ License found: MIT License (Valid open source OSI approved license)

editorialbot commented 1 week ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 1 week ago

Five most similar historical JOSS papers:

PDLSM-FEM: Solver of Coupled Peridynamics Least Squares Minimization with Finite Element Method Submitting author: @QibangLiu Handling editor: @prashjha (Active) Reviewers: @TLCFEM, @karthikncsu, @Balaje Similarity score: 0.6999

BasicTools: a numerical simulation toolbox Submitting author: @fbordeu Handling editor: @diehlpk (Active) Reviewers: @hvonwah, @sthavishtha Similarity score: 0.6947

SeismicMesh: Triangular meshing for seismology Submitting author: @krober10nd Handling editor: @meg-simula (Retired) Reviewers: @nschloe, @jorgensd Similarity score: 0.6926

NLMech: Implementation of finite difference/meshfree discretization of nonlocal fracture models Submitting author: @diehlpk Handling editor: @Kevin-Mattheus-Moerman (Active) Reviewers: @vijaysm, @chennachaos Similarity score: 0.6855

cRacklet: a spectral boundary integral method library for interfacial rupture simulation Submitting author: @tiburoch Handling editor: @diehlpk (Active) Reviewers: @srmnitc, @kylebeggs Similarity score: 0.6833

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

arfon commented 1 week ago

@Habiba-Eldababy - thanks for your submission to JOSS. We're currently managing a large backlog of submissions and the editor most appropriate for your area is already rather busy.

While we are waiting, could you please:

Fix the DOIs (noting that @editorialbot's suggestions are not always right), you can, then use the following commands (one at a time, as the first line of a new comment) to regenerate the PDF and check the references:

@editorialbot generate pdf @editorialbot check references

Explain how this software is tested? Being able to test the capabilities of software is important (and required for JOSS as part of the review). Please explain here how a user might do this.
The paper is also a little long (and appears to be missing a Statement of need section), could you please work on that too. Thank you!

For now, we will need to waitlist this paper and process it as the queue reduces. Thanks for your patience!

kyleniemeyer commented 1 day ago

@Habiba-Eldababy before we assign an editor, can you please address the question about how your software is tested? We don't require automated testing / continuous integration, but software does need to have tests set up somehow.

kyleniemeyer commented 1 day ago

@diehlpk assuming the software will move to review after addressing the above questions, would you be able to edit this one?

diehlpk commented 1 day ago

Yes, but I can only start mid of December.

Habiba-Eldababy commented 22 hours ago

@editorialbot generate pdf

editorialbot commented 22 hours ago

:warning: An error happened when generating the pdf.

Habiba-Eldababy commented 22 hours ago

@editorialbot generate pdf

editorialbot commented 22 hours ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 22 hours ago

Five most similar historical JOSS papers:

PDLSM-FEM: Solver of Coupled Peridynamics Least Squares Minimization with Finite Element Method Submitting author: @QibangLiu Handling editor: @prashjha (Active) Reviewers: @TLCFEM, @karthikncsu, @Balaje Similarity score: 0.6999

BasicTools: a numerical simulation toolbox Submitting author: @fbordeu Handling editor: @diehlpk (Active) Reviewers: @hvonwah, @sthavishtha Similarity score: 0.6995

SeismicMesh: Triangular meshing for seismology Submitting author: @krober10nd Handling editor: @meg-simula (Retired) Reviewers: @nschloe, @jorgensd Similarity score: 0.6931

cRacklet: a spectral boundary integral method library for interfacial rupture simulation Submitting author: @tiburoch Handling editor: @diehlpk (Active) Reviewers: @srmnitc, @kylebeggs Similarity score: 0.6854

NLMech: Implementation of finite difference/meshfree discretization of nonlocal fracture models Submitting author: @diehlpk Handling editor: @Kevin-Mattheus-Moerman (Active) Reviewers: @vijaysm, @chennachaos Similarity score: 0.6849

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

Habiba-Eldababy commented 22 hours ago

Hi @arfon @kyleniemeyer ! Thank you for your initial comments and feedback. I have updated the DOIs and renamed the statement of need section. There are instructions for testing and running the code in the README file. Please let me know if you need any additional information.

kyleniemeyer commented 22 hours ago

Thank you, @Habiba-Eldababy. I think this looks sufficient to begin review, although reviewers may have additional feedback.

kyleniemeyer commented 22 hours ago

@editorialbot assign @diehlpk as editor

with the understanding that @diehlpk will begin handling the submission mid-December. Thanks!

editorialbot commented 22 hours ago

Assigned! @diehlpk is now the editor

openjournals / joss-reviews

[PRE REVIEW]: Parallel Implementation of Continuum Damage Mechanics Simulations using FEM and MATLAB #7453

Status