openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
725 stars 38 forks source link

[REVIEW]: constrained_manipulability: A ROS 2 library to Compute and Visualize Constrained Capacities for Robotic Manipulators #7481

Open editorialbot opened 1 week ago

editorialbot commented 1 week ago

Submitting author: !--author-handle-->@mazrk7<!--end-author-handle-- (Mark Zolotas) Repository: https://github.com/philip-long/constrained_manipulability Branch with paper.md (empty if default branch): paper Version: v1.0.0 Editor: !--editor-->@crvernon<!--end-editor-- Reviewers: @askuric, @JHartzer Archive: Pending

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/02f7e4e6e7e542ee3b96b0f1d2524d20"><img src="https://joss.theoj.org/papers/02f7e4e6e7e542ee3b96b0f1d2524d20/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/02f7e4e6e7e542ee3b96b0f1d2524d20/status.svg)](https://joss.theoj.org/papers/02f7e4e6e7e542ee3b96b0f1d2524d20)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@askuric & @JHartzer, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @crvernon know.

Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest

Checklists

@askuric, please create your checklist typing: @editorialbot generate my checklist

@JHartzer, please create your checklist typing: @editorialbot generate my checklist

editorialbot commented 1 week ago

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 1 week ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.02 s (1505.4 files/s, 183376.5 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
C++                              6            291            135           1616
C/C++ Header                     3            111            119            484
Python                           8            122             43            484
YAML                            10              1             12            379
Markdown                         2             57              0            235
CMake                            2             35              7            160
TeX                              1             14              0            125
XML                              2             13              0             53
Gencat NLS                       3              0              0             11
-------------------------------------------------------------------------------
SUM:                            37            644            316           3547
-------------------------------------------------------------------------------

Commit count by author:

    61  mazrk7
    40  philip-long
    34  Mark Zolotas
    18  philip long
     6  philip
     1  Tarik Kelestemur
editorialbot commented 1 week ago

Paper file info:

📄 Wordcount for paper.md is 1393

✅ The paper includes a Statement of need section

editorialbot commented 1 week ago

License info:

✅ License found: MIT License (Valid open source OSI approved license)

editorialbot commented 1 week ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1126/scirobotics.abm6074 is OK
- 10.1109/ICRA.2012.6225337 is OK
- 10.3389/frobt.2021.730433 is OK
- 10.21105/joss.05670 is OK
- 10.1109/LRA.2023.3313926 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: ROS: an open-source Robot Operating System
- No DOI given, and none found for title: Kinetostatic performance limits of cooperating rob...
- No DOI given, and none found for title: Analysis and control of robot manipulators with re...

❌ MISSING DOIs

- 10.1109/icra.2019.8794071 may be a valid DOI for title: Optimization-Based Human-in-the-Loop Manipulation ...
- 10.1109/humanoids.2018.8624962 may be a valid DOI for title: Evaluating Robot Manipulability in Constrained Env...
- 10.1007/3-540-61576-8_77 may be a valid DOI for title: Double description method revisited
- 10.1007/s10514-012-9321-0 may be a valid DOI for title: OctoMap: An efficient probabilistic 3D mapping fra...
- 10.1109/tro.2016.2623338 may be a valid DOI for title: Zmp support areas for multicontact mobility under ...
- 10.1007/978-3-319-61431-1_23 may be a valid DOI for title: Tension distribution algorithm for planar mobile c...

❌ INVALID DOIs

- None
editorialbot commented 1 week ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

crvernon commented 1 week ago

👋 @mazrk7, @askuric, and @JHartzer - This is the review thread for the paper. All of our communications will happen here from now on.

Please read the "Reviewer instructions & questions" in the first comment above.

Both reviewers have checklists at the top of this thread (in that first comment) with the JOSS requirements. As you go over the submission, please check any items that you feel have been satisfied. There are also links to the JOSS reviewer guidelines.

The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, the reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention https://github.com/openjournals/joss-reviews/issues/7481 so that a link is created to this thread (and I can keep an eye on what is happening). Please also feel free to comment and ask questions on this thread. In my experience, it is better to post comments/questions/suggestions as you come across them instead of waiting until you've reviewed the entire package.

We aim for the review process to be completed within about 4-6 weeks but please make a start well ahead of this as JOSS reviews are by their nature iterative and any early feedback you may be able to provide to the author will be very helpful in meeting this schedule.