[REVIEW]: pyuvdata v3: an interface for astronomical interferometeric datasets in python

[editorialbot]

Submitting author: !--author-handle-->@kartographer<!--end-author-handle-- (Garrett Keating) Repository: https://github.com/RadioAstronomySoftwareGroup/pyuvdata/ Branch with paper.md (empty if default branch): joss_update Version: v3.0 Editor: !--editor-->@JBorrow<!--end-editor-- Reviewers: @David-McKenna, @ptiede Archive: Pending

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/73820365e5513a0b1eef71c545b73c44"><img src="https://joss.theoj.org/papers/73820365e5513a0b1eef71c545b73c44/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/73820365e5513a0b1eef71c545b73c44/status.svg)](https://joss.theoj.org/papers/73820365e5513a0b1eef71c545b73c44)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@David-McKenna & @ptiede, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @JBorrow know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @David-McKenna

[editorialbot]

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

[editorialbot]

Software report:

github.com/AlDanial/cloc v 1.90  T=0.81 s (244.6 files/s, 177364.2 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                         127          16412          25207          78560
C                                7           1116           2586           5152
TeX                              8            431            268           3308
Markdown                         7            305              0           1656
Cython                           6            314            191           1126
reStructuredText                 9            745           2173           1062
JSON                             1              0              0            866
YAML                            17             68             43            737
CSV                              2              0              0            614
C/C++ Header                     7            114            147            513
make                             1             31              6            193
TOML                             1             14              6            125
IDL                              1             13              4            109
Prolog                           1             22              0             47
Bourne Shell                     3              9              5             18
HTML                             1              1              0              3
-------------------------------------------------------------------------------
SUM:                           199          19595          30636          94089
-------------------------------------------------------------------------------

Commit count by author:

  2547  Bryna Hazelton
   580  Matthew Kolopanis
   462  Garrett 'Karto' Keating
   395  Paul La Plante
   274  Adam Beardsley
   212  Steven Murray
   173  Garrett Keating
   159  Garrett "Karto" Keating
   159  Nicholas Kern
   139  pyxieloustar
   117  Aaron Ewall-Wice
    91  Adam Lanman
    75  Jonathan Pober
    75  Mike Wilensky
    69  aelanman
    65  Zaki Ali
    57  Danny Jacobs
    54  pre-commit-ci[bot]
    52  Danny Price
    41  Josh Dillon
    39  Dara Storer
    35  e-koch
    34  Peter Williams
    26  WSK
    25  PyxieLouStar
    23  Christopher Moriarty
    22  Jacob Burba
    20  Theodora Kunicki
    17  Tyler Cox
    14  Ruby Byrne
    13  Alex Foster
    13  Chuneeta
    11  Will S
     7  PStar
     6  Aaron Parsons
     6  James Aguirre
     6  Zachary Martinot
     6  radonnachie
     5  Adrian Liu
     5  Benjamin
     5  jburba
     4  Theo Kunicki
     2  Duncan
     2  Ross Donnachie
     2  Will Sutherland
     2  Willow Smith
     2  anguta
     1  Jonnie Pober
     1  Josh Kerrigan
     1  TrellixVulnTeam
     1  Unknown
     1  elillesk
     1  jaycedowell
     1  kartographer

[editorialbot]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1088/0004-637X/759/1/17 is OK
- 10.1088/1538-3873/ac9642 is OK
- 10.21105/joss.00140 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Astronomical Interferometry in PYthon
- No DOI given, and none found for title: AIPS FITS File Format
- No DOI given, and none found for title: A Retrospective View of MIRIAD
- No DOI given, and none found for title: MeasurementSet definition version 2.0
- No DOI given, and none found for title: The MIR Cookbook
- No DOI given, and none found for title: Memo: UVCal FITS Format
- No DOI given, and none found for title: Memo: UVBeam FITS Format
- No DOI given, and none found for title: Memo: UVH5 file format
- No DOI given, and none found for title: Memo: CalH5 file format

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

[editorialbot]

Paper file info:

📄 Wordcount for paper.md is 739

✅ The paper includes a Statement of need section

[editorialbot]

License info:

✅ License found: BSD 2-Clause "Simplified" License (Valid open source OSI approved license)

[editorialbot]

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

[David-McKenna]

Review checklist for @David-McKenna

Conflict of interest

• [x] I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

• [x] I confirm that I read and will adhere to the JOSS code of conduct.

General checks

• [x] Repository: Is the source code for this software available at the https://github.com/RadioAstronomySoftwareGroup/pyuvdata/?
• [x] License: Does the repository contain a plain-text LICENSE or COPYING file with the contents of an OSI approved software license?
• [x] Contribution and authorship: Has the submitting author (@kartographer) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?
• [x] Substantial scholarly effort: Does this submission meet the scope eligibility described in the JOSS guidelines
• [x] Data sharing: If the paper contains original data, data are accessible to the reviewers. If the paper contains no original data, please check this item.
• [x] Reproducibility: If the paper contains original results, results are entirely reproducible by reviewers. If the paper contains no original results, please check this item.
• [x] Human and animal research: If the paper contains original data research on humans subjects or animals, does it comply with JOSS's human participants research policy and/or animal research policy? If the paper contains no such data, please check this item.

Functionality

• [x] Installation: Does installation proceed as outlined in the documentation?
• [ ] Functionality: Have the functional claims of the software been confirmed?
• [ ] Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

• [x] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
• [x] Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
• [ ] Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
• [ ] Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
• [x] Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
• [x] Community guidelines: Are there clear guidelines for third parties wishing to 1. Contribute to the software 2. Report issues or problems with the software 3. Seek support

Software paper

• [x] Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
• [x] A statement of need: Does the paper have a section titled 'Statement of need' that clearly states what problems the software is designed to solve, who the target audience is, and its relation to other work?
• [ ] State of the field: Do the authors describe how this software compares to other commonly-used packages?
• [ ] Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
• [ ] References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?