search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
725 stars 38 forks source link

[PRE REVIEW]: HySoP: Hybrid Simulation with Particles #7483

Open editorialbot opened 1 week ago

editorialbot commented 1 week ago

Submitting author: !--author-handle-->@jmetancelin<!--end-author-handle-- (Jean-Matthieu Etancelin) Repository: https://gricad-gitlab.univ-grenoble-alpes.fr/particle_methods/hysop Branch with paper.md (empty if default branch): joss Version: 2024.11 Editor: Pending Reviewers: Pending Managing EiC: Daniel S. Katz

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/735fee5b21e2c53e8198a33a387aef21"><img src="https://joss.theoj.org/papers/735fee5b21e2c53e8198a33a387aef21/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/735fee5b21e2c53e8198a33a387aef21/status.svg)](https://joss.theoj.org/papers/735fee5b21e2c53e8198a33a387aef21)

Author instructions

Thanks for submitting your paper to JOSS @jmetancelin. Currently, there isn't a JOSS editor assigned to your paper.

@jmetancelin if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 1 week ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 1 week ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.95 s (564.2 files/s, 189289.4 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                         397          19597          24897         110274
Fortran 90                      40           2967           6472          10521
Meson                           69            154            179           1245
Markdown                         4            216              0            506
Bourne Shell                    11             63            255            380
YAML                             5             52            189            377
TeX                              1              0              0            197
Dockerfile                       2             41             67            146
JSON                             1              1              0            123
C++                              2             26             86             44
TOML                             1              3              4             18
C/C++ Header                     1             10             21             14
-------------------------------------------------------------------------------
SUM:                           534          23130          32170         123845
-------------------------------------------------------------------------------

Commit count by author:

  1293  Jean-Baptiste Keck
   578  Jean-Matthieu Etancelin
   479  Franck Pérignon
   200  Keck Jean-Baptiste
   135  JM Etancelin
    79  Chloe Mimeau
    54  Nicolas Grima
    36  Eric Dalissier
    28  Jean-Baptiste Lagaert
    21  Jean-Baptiste Keck Jean-Baptiste.Keck@imag.fr
    19  GRIMA NICOLAS
    17  Chloé Mimeau
    16  Christophe Picard
    11  EXT Jean-Matthieu Etancelin
     8  Nicolas G
     7  mimeau
     6  Adrien Magni
     6  Nicolas Grm
     4  EXT GRIMA Nicolas
     4  Georges-Henri Cottet
     1  JME
editorialbot commented 1 week ago

Paper file info:

📄 Wordcount for paper.md is 2887

✅ The paper includes a Statement of need section

editorialbot commented 1 week ago

License info:

✅ License found: Apache License 2.0 (Valid open source OSI approved license)

editorialbot commented 1 week ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1103/PhysRevFluids.6.L022301 is OK
- 10.1016/j.compfluid.2021.104946 is OK
- 10.3390/fluids6020068 is OK
- 10.1016/j.advwatres.2020.103780 is OK
- 10.1016/j.euromechflu.2017.03.002 is OK
- 10.1051/m2an/2014009 is OK
- 10.1016/j.compfluid.2016.06.020 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: MURPHY – A scalable multiresolution framework for ...
- No DOI given, and none found for title: Numerical modelling and High Performance Computing...
- No DOI given, and none found for title: Conception et mise en oeuvre de méthodes vortex hy...
- No DOI given, and none found for title: Couplage de modèles, algorithmes multi-échelles et...

❌ MISSING DOIs

- 10.1016/j.compfluid.2024.106287 may be a valid DOI for title: Large-Eddy Simulations with remeshed Vortex method...

❌ INVALID DOIs

- https://doi.org/10.1016/j.cpc.2019.03.007 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1016/j.jcp.2013.12.026 is INVALID because of 'https://doi.org/' prefix
editorialbot commented 1 week ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 1 week ago

Five most similar historical JOSS papers:

RHEA: an open-source Reproducible Hybrid-architecture flow solver Engineered for Academia Submitting author: @lluisjofre Handling editor: @diehlpk (Active) Reviewers: @ctdegroot, @thomasgillis Similarity score: 0.7174

PyMPDATA v1: Numba-accelerated implementation of MPDATA with examples in Python, Julia and Matlab Submitting author: @slayoo Handling editor: @arfon (Active) Reviewers: @Chiil, @wdeconinck Similarity score: 0.7154

SiSyPHE: A Python package for the Simulation of Systems of interacting mean-field Particles with High Efficiency Submitting author: @antoinediez Handling editor: @pdebuyl (Active) Reviewers: @lorenzo-rovigatti, @junghans Similarity score: 0.7066

NebulaSEM: A high-order discontinuous Galerkin spectral element code for atmospheric modeling Submitting author: @dshawul Handling editor: @observingClouds (Active) Reviewers: @capitalaslash, @esclapez Similarity score: 0.7065

OpenCMP: An Open-Source Computational Multiphysics Package Submitting author: @nasserma Handling editor: @lucydot (Active) Reviewers: @bonh, @WilkAndy Similarity score: 0.7036

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

danielskatz commented 1 week ago

@jmetancelin - thanks for your submission. However, note that JOSS submissions are expected to be 250-1000 words, roughly, and yours is about 3 times that long. Can you remove text, which could potentially be moved to the documentation or the repo, with the paper pointing to this for more detail? Alternatively, JOSS might not be the right journal for your submission if you want all of the details in the paper.

In addition, you could work on the possibly missing DOI and incorrectly formatted DOIs that editorialbot suggests, but note that some may be incorrect. Please feel free to make changes to your .bib file, then use the command @editorialbot check references to check again, and the command @editorialbot generate pdf when the references are right to make a new PDF. editorialbot commands need to be the first entry in a new comment.

You can also use @editorialbot check repository to check the paper length.

danielskatz commented 1 week ago

Also, we've switched the track for this, so another track editor will continue working with you.

kyleniemeyer commented 3 days ago

Unfortunately @jmetancelin, we do not have any editors available to handle this right now, so I have to put this in our queue until someone frees up. Please do address @danielskatz's comments in the meantime. Thanks for your patience!

jmetancelin commented 1 day ago

@editorialbot check references

editorialbot commented 1 day ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1016/j.cpc.2019.03.007 is OK
- 10.48550/arXiv.2112.07537 is OK
- 10.1103/PhysRevFluids.6.L022301 is OK
- 10.1016/j.compfluid.2021.104946 is OK
- 10.3390/fluids6020068 is OK
- 10.1016/j.advwatres.2020.103780 is OK
- 10.1016/j.euromechflu.2017.03.002 is OK
- 10.1051/m2an/2014009 is OK
- 10.1016/j.compfluid.2016.06.020 is OK
- 10.1016/j.jcp.2013.12.026 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Numerical modelling and High Performance Computing...
- No DOI given, and none found for title: Conception et mise en oeuvre de méthodes vortex hy...
- No DOI given, and none found for title: Couplage de modèles, algorithmes multi-échelles et...

❌ MISSING DOIs

- None

❌ INVALID DOIs

- 10.1016/j.compfluid.2024.10628 is INVALID
jmetancelin commented 1 day ago

@editorialbot check references

editorialbot commented 1 day ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1016/j.cpc.2019.03.007 is OK
- 10.48550/arXiv.2112.07537 is OK
- 10.1016/j.compfluid.2024.106287 is OK
- 10.1103/PhysRevFluids.6.L022301 is OK
- 10.1016/j.compfluid.2021.104946 is OK
- 10.3390/fluids6020068 is OK
- 10.1016/j.advwatres.2020.103780 is OK
- 10.1016/j.euromechflu.2017.03.002 is OK
- 10.1051/m2an/2014009 is OK
- 10.1016/j.compfluid.2016.06.020 is OK
- 10.1016/j.jcp.2013.12.026 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Numerical modelling and High Performance Computing...
- No DOI given, and none found for title: Conception et mise en oeuvre de méthodes vortex hy...
- No DOI given, and none found for title: Couplage de modèles, algorithmes multi-échelles et...

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None
jmetancelin commented 1 day ago

@editorialbot check repository

editorialbot commented 1 day ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.95 s (560.9 files/s, 187992.4 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                         397          19597          24897         110274
Fortran 90                      40           2967           6472          10521
Meson                           69            154            179           1245
Bourne Shell                    11             63            255            380
YAML                             5             52            189            377
Markdown                         4            180              0            376
TeX                              1              0              0            199
Dockerfile                       2             41             67            146
JSON                             1              1              0            123
C++                              2             26             86             44
TOML                             1              3              4             18
C/C++ Header                     1             10             21             14
-------------------------------------------------------------------------------
SUM:                           534          23094          32170         123717
-------------------------------------------------------------------------------

Commit count by author:

  1293  Jean-Baptiste Keck
   578  Jean-Matthieu Etancelin
   481  Franck Pérignon
   200  Keck Jean-Baptiste
   139  JM Etancelin
    79  Chloe Mimeau
    54  Nicolas Grima
    36  Eric Dalissier
    28  Jean-Baptiste Lagaert
    21  Jean-Baptiste Keck Jean-Baptiste.Keck@imag.fr
    19  GRIMA NICOLAS
    17  Chloé Mimeau
    16  Christophe Picard
    11  EXT Jean-Matthieu Etancelin
     8  Nicolas G
     8  mimeau
     6  Adrien Magni
     6  Nicolas Grm
     4  EXT GRIMA Nicolas
     4  Georges-Henri Cottet
     1  JME
editorialbot commented 1 day ago

Paper file info:

📄 Wordcount for paper.md is 1199

✅ The paper includes a Statement of need section

editorialbot commented 1 day ago

License info:

✅ License found: Apache License 2.0 (Valid open source OSI approved license)