openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
725 stars 38 forks source link

[PRE REVIEW]: SpecpolFlow: a new software package for spectropolarimetry using Python #7515

Open editorialbot opened 1 day ago

editorialbot commented 1 day ago

Submitting author: !--author-handle-->@folsomcp<!--end-author-handle-- (Colin Folsom) Repository: https://github.com/folsomcp/specpolFlow Branch with paper.md (empty if default branch): Version: v0.4.3 Editor: Pending Reviewers: Pending Managing EiC: Warrick Ball

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/ca985b0c5d225ac1a95b9f2f10ed4452"><img src="https://joss.theoj.org/papers/ca985b0c5d225ac1a95b9f2f10ed4452/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/ca985b0c5d225ac1a95b9f2f10ed4452/status.svg)](https://joss.theoj.org/papers/ca985b0c5d225ac1a95b9f2f10ed4452)

Author instructions

Thanks for submitting your paper to JOSS @folsomcp. Currently, there isn't a JOSS editor assigned to your paper.

@folsomcp if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 1 day ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 1 day ago

Software report:

github.com/AlDanial/cloc v 1.90  T=7.18 s (7.8 files/s, 121622.7 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Assembly                         4              0              3         858014
Python                          17            659           1889           3482
Markdown                        10            310              0            872
Jupyter Notebook                13              0           7097            651
TeX                              1             21              0            309
YAML                             5             18             47            106
TOML                             1              6              6             40
reStructuredText                 5             33             33             10
-------------------------------------------------------------------------------
SUM:                            56           1047           9075         863484
-------------------------------------------------------------------------------

Commit count by author:

   208  Colin Folsom
   126  veropetit
    65  christierba
    43  pjstanley1
    33  TaliNatan
    29  Tali Natan
    15  bzaire
    10  shaqsead16
     6  Aaron Moore
     4  Christi Erba
     3  Bonnie Zaire
     3  folsomcp
editorialbot commented 1 day ago

Paper file info:

📄 Wordcount for paper.md is 1755

✅ The paper includes a Statement of need section

editorialbot commented 1 day ago

License info:

🟡 License found: GNU General Public License v2.0 (Check here for OSI approval)

editorialbot commented 1 day ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1093/mnras/291.4.658 is OK
- 10.1051/0004-6361/201015429 is OK
- 10.1017/S1743921314007017 is OK
- 10.12942/lrsp-2012-1 is OK
- 10.1146/annurev-astro-082708-101833 is OK
- 10.1093/mnras/stw2743 is OK
- 10.1093/mnras/sty2895 is OK
- 10.1046/j.1365-8711.2000.03271.x is OK
- 10.1093/mnras/stx3021 is OK
- 10.1007/s11214-015-0152-0 is OK
- 10.1093/mnras/stu1663 is OK
- 10.1088/0031-8949/90/5/054005 is OK
- 10.1111/j.1365-2966.2011.20091.x is OK
- 10.48550/arXiv.2401.09722 is OK
- 10.1111/j.1365-2966.2008.13946.x is OK
- 10.1093/mnras/stae1955 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Stellar magnetism
- No DOI given, and none found for title: Line formation in an unresolved magnetic element: ...
- No DOI given, and none found for title: Atomic energy levels - The rare-Earth elements
- No DOI given, and none found for title: Chemical abundances of very young intermediate mas...

❌ MISSING DOIs

- None

❌ INVALID DOIs

- 10.1007/978-1-4020-2415-3 is INVALID
editorialbot commented 1 day ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 1 day ago

Five most similar historical JOSS papers:

MCALF: Multi-Component Atmospheric Line Fitting Submitting author: @ConorMacBride Handling editor: @mbobra (Active) Reviewers: @mgalloy, @Goobley Similarity score: 0.7401

PyAstroPol: A Python package for the instrumental polarization analysis of the astronomical optics. Submitting author: @hemanthpruthvi Handling editor: @pibion (Retired) Reviewers: @aquilesC, @caldarolamartin, @mwcraig Similarity score: 0.7372

EISPAC - The EIS Python Analysis Code Submitting author: @MJWeberg Handling editor: @mbobra (Active) Reviewers: @nabobalis, @PaulJWright Similarity score: 0.7358

Astronomical échelle spectroscopy data analysis with muler Submitting author: @gully Handling editor: @xuanxu (Active) Reviewers: @bmorris3, @wtgee Similarity score: 0.7183

PypeIt: The Python Spectroscopic Data Reduction Pipeline Submitting author: @profxj Handling editor: @dfm (Active) Reviewers: @Gabriel-p, @astrom-tom Similarity score: 0.7169

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

warrickball commented 1 day ago

@folsomcp — Thanks for your submission! All the suitable JOSS editors are currently working at capacity so I'm going to "waitlist" this review until an editor with the relevant expertise is available to take it on. Thanks for your patience!

warrickball commented 1 day ago

Note also that the paper is a bit long. Our docs say

The paper should be between 250-1000 words. Authors submitting papers significantly longer than 1000 words may be asked to reduce the length of their paper.

The "Overview of SpecpolFlow" in particular can probably be pared down somewhat. Please try to get the word count closer to 1000 words while we wait for an editor to pick this up. Thanks!