openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
725 stars 38 forks source link

[REVIEW]: DiffOpt: Parallel optimization of Jax models #7522

Open editorialbot opened 18 hours ago

editorialbot commented 18 hours ago

Submitting author: !--author-handle-->@AlanPearl<!--end-author-handle-- (Alan Pearl) Repository: https://github.com/AlanPearl/diffopt Branch with paper.md (empty if default branch): paper Version: v1.0.0 Editor: !--editor-->@jbytecode<!--end-editor-- Reviewers: @landreman, @ewu63 Archive: Pending

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/211b25a3f9df01ca85be7100ad149e87"><img src="https://joss.theoj.org/papers/211b25a3f9df01ca85be7100ad149e87/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/211b25a3f9df01ca85be7100ad149e87/status.svg)](https://joss.theoj.org/papers/211b25a3f9df01ca85be7100ad149e87)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@landreman & @ewu63, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @jbytecode know.

Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest

Checklists

📝 Checklist for @landreman

editorialbot commented 18 hours ago

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 18 hours ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.04 s (1131.6 files/s, 181175.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          23            532            805           1893
Jupyter Notebook                 5              0           1789            782
Markdown                         2             36              0            165
TeX                              1              6              0             86
YAML                             3              6              4             59
reStructuredText                 3             48             54             50
TOML                             1              5              0             29
DOS Batch                        1              8              1             26
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                            40            645           2660           3099
-------------------------------------------------------------------------------

Commit count by author:

    17  Alan Pearl
editorialbot commented 18 hours ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.21105/astro.2105.05859 is OK
- 10.1093/mnras/stac3118 is OK
- 10.1093/mnras/stad456 is OK
- 10.1109/ICNN.1995.488968 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: JAX: composable transformations of Python+NumPy pr...
- No DOI given, and none found for title: Multivariate Density Estimation
- No DOI given, and none found for title: Mathematical methods of statistics

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None
editorialbot commented 18 hours ago

Paper file info:

📄 Wordcount for paper.md is 1259

✅ The paper includes a Statement of need section

editorialbot commented 18 hours ago

License info:

✅ License found: MIT License (Valid open source OSI approved license)

editorialbot commented 18 hours ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

jbytecode commented 18 hours ago

Dear Reviewers @landreman and @ewu63

You can start by creating your task lists. Each list will contain several tasks.

As you complete each task, you can check off the corresponding checkbox. Since the review process for JOSS is interactive, you are encouraged to engage with the author, other reviewers, and the editor throughout. You can open issues and submit pull requests in the target repository. Please include the URL of this page in those interactions, so we can keep track of activities outside of the platform.

To generate your task list, simply type:

@editorialbot generate my checklist

Thank you in advance.

landreman commented 14 hours ago

Review checklist for @landreman

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Software paper