openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
725 stars 38 forks source link

[REVIEW]: r3f: Rotation of 3-dimensional Reference Frames #7534

Open editorialbot opened 4 days ago

editorialbot commented 4 days ago

Submitting author: !--author-handle-->@davidwoodburn<!--end-author-handle-- (David Woodburn) Repository: https://gitlab.com/davidwoodburn/r3f Branch with paper.md (empty if default branch): main Version: 2.0.9 Editor: !--editor-->@jbytecode<!--end-editor-- Reviewers: @pariterre, @vyasr Archive: Pending

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/224743383bcc8934a95f704a6290a10b"><img src="https://joss.theoj.org/papers/224743383bcc8934a95f704a6290a10b/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/224743383bcc8934a95f704a6290a10b/status.svg)](https://joss.theoj.org/papers/224743383bcc8934a95f704a6290a10b)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@pariterre & @vyasr, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @jbytecode know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

πŸ“ Checklist for @pariterre

editorialbot commented 4 days ago

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 4 days ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.03 s (272.1 files/s, 171241.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                           3            743           1839           1409
Markdown                         3             80              0            251
TeX                              1              0              0             83
-------------------------------------------------------------------------------
SUM:                             7            823           1839           1743
-------------------------------------------------------------------------------

Commit count by author:

    46  David Woodburn
editorialbot commented 4 days ago

Paper file info:

πŸ“„ Wordcount for paper.md is 485

βœ… The paper includes a Statement of need section

editorialbot commented 4 days ago

License info:

🟑 License found: Other (Check here for OSI approval)

editorialbot commented 4 days ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

βœ… OK DOIs

- 10.21105/joss.00580 is OK

🟑 SKIP DOIs

- No DOI given, and none found for title: Strapdown Inertial Navigation Technology
- No DOI given, and none found for title: Principles of GNSS, Inertial, and Multisensor Inte...
- No DOI given, and none found for title: linear_transforms
- No DOI given, and none found for title: gps-frames
- No DOI given, and none found for title: rotations
- No DOI given, and none found for title: gtFrame
- No DOI given, and none found for title: PyGeodesy

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None
editorialbot commented 4 days ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

jbytecode commented 4 days ago

Dear Reviewers @pariterre and @vyasr,

You can start by creating your task lists. Please, type

@editorialbot generate my checklist

to generate your task list. Each list will contain several tasks.

As you complete each task, you can check off the corresponding checkbox. Since the review process for JOSS is interactive, you are encouraged to engage with the author, other reviewers, and the editor throughout. You can open issues and submit pull requests in the target repository. Please include the URL of this page in those interactions, so we can keep track of activities outside of the platform.

Thank you in advance.

pariterre commented 2 days ago

Review checklist for @pariterre

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Software paper