openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
725 stars 38 forks source link

[REVIEW]: rdata: A Python library for R datasets #7540

Closed editorialbot closed 3 hours ago

editorialbot commented 3 hours ago

Submitting author: !--author-handle-->@VNMabus<!--end-author-handle-- (Carlos Ramos-Carreño) Repository: https://github.com/vnmabus/rdata Branch with paper.md (empty if default branch): feature/joss_paper Version: 0.11.0 Editor: !--editor-->@arfon<!--end-editor-- Reviewers: @has2k1, @rich-iannone Archive: 10.5281/zenodo.10776842

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/62145d2bd727d628ab413174d428984e"><img src="https://joss.theoj.org/papers/62145d2bd727d628ab413174d428984e/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/62145d2bd727d628ab413174d428984e/status.svg)](https://joss.theoj.org/papers/62145d2bd727d628ab413174d428984e)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@has2k1 & @rich-iannone, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @arfon know.

Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest

Checklists

@has2k1, please create your checklist typing: @editorialbot generate my checklist

@rich-iannone, please create your checklist typing: @editorialbot generate my checklist

editorialbot commented 3 hours ago

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 3 hours ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.05 s (1191.7 files/s, 147116.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          26           1011           1017           3125
Markdown                         6             91              0            275
reStructuredText                 8            150            204            265
YAML                             8             33             23            252
TOML                             1             18              0            135
TeX                              1              7              0             91
DOS Batch                        1              8              1             27
JSON                             2              1              0             22
SVG                              1              0              0             14
make                             1              4              6             10
-------------------------------------------------------------------------------
SUM:                            55           1323           1251           4216
-------------------------------------------------------------------------------

Commit count by author:

   160  Tuomas Rossi
   141  VNMabus
    53  vnmabus
    22  Carlos Ramos Carreño
editorialbot commented 3 hours ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.5281/zenodo.6383047 is OK
- 10.5281/zenodo.7110169 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.25080/Majora-92bf1922-00a is OK
- 10.5281/zenodo.3509134 is OK
- 10.18637/jss.v109.i02 is OK
- 10.1371/journal.pcbi.1011914 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Rpy2: R in Python

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None
editorialbot commented 3 hours ago

Paper file info:

📄 Wordcount for paper.md is 1475

✅ The paper includes a Statement of need section

editorialbot commented 3 hours ago

License info:

✅ License found: MIT License (Valid open source OSI approved license)

editorialbot commented 3 hours ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

arfon commented 3 hours ago

@editorialbot set 10.5281/zenodo.10776842 as archive

editorialbot commented 3 hours ago

Done! archive is now 10.5281/zenodo.10776842

arfon commented 3 hours ago

@editorialbot recommend-accept

editorialbot commented 3 hours ago
Attempting dry run of processing paper acceptance...
editorialbot commented 3 hours ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.5281/zenodo.6383047 is OK
- 10.5281/zenodo.7110169 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.25080/Majora-92bf1922-00a is OK
- 10.5281/zenodo.3509134 is OK
- 10.18637/jss.v109.i02 is OK
- 10.1371/journal.pcbi.1011914 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Rpy2: R in Python

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None
editorialbot commented 3 hours ago

:wave: @openjournals/misc-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/6198, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

arfon commented 3 hours ago

@editorialbot accept

editorialbot commented 3 hours ago
Doing it live! Attempting automated processing of paper acceptance...
editorialbot commented 3 hours ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Ramos-Carreño given-names: Carlos orcid: "https://orcid.org/0000-0003-2566-7058" - family-names: Rossi given-names: Tuomas orcid: "https://orcid.org/0000-0002-8713-4559" doi: 10.5281/zenodo.10776842 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Ramos-Carreño given-names: Carlos orcid: "https://orcid.org/0000-0003-2566-7058" - family-names: Rossi given-names: Tuomas orcid: "https://orcid.org/0000-0002-8713-4559" date-published: 2024-12-01 doi: 10.21105/joss.07540 issn: 2475-9066 issue: 104 journal: Journal of Open Source Software publisher: name: Open Journals start: 7540 title: "rdata: A Python library for R datasets" type: article url: "https://joss.theoj.org/papers/10.21105/joss.07540" volume: 9 title: "rdata: A Python library for R datasets" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 3 hours ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 3 hours ago

🦋🦋🦋 👉 Bluesky post for this paper 👈 🦋🦋🦋

editorialbot commented 3 hours ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/6199
  2. Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.07540
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

arfon commented 3 hours ago

@has2k1, @rich-iannone – many thanks for your reviews at pyOpenSci! JOSS and pyOpenSci relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you ✨

@vnmabus – your paper is now accepted and published in JOSS :zap::rocket::boom:

editorialbot commented 3 hours ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following

code snippets

``` Markdown: [![DOI](https://joss.theoj.org/papers/10.21105/joss.07540/status.svg)](https://doi.org/10.21105/joss.07540) HTML: DOI badge reStructuredText: .. image:: https://joss.theoj.org/papers/10.21105/joss.07540/status.svg :target: https://doi.org/10.21105/joss.07540 ```

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following: