openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
725 stars 38 forks source link

[REVIEW]: MDPSolver: An Efficient Solver for Markov Decision Processes #7544

Open editorialbot opened 21 hours ago

editorialbot commented 21 hours ago

Submitting author: !--author-handle-->@areenberg<!--end-author-handle-- (Anders Reenberg Andersen) Repository: https://github.com/areenberg/MDPSolver Branch with paper.md (empty if default branch): joss_paper Version: v0.9.7 Editor: !--editor-->@kellyrowland<!--end-editor-- Reviewers: !--reviewers-list-->@gartavanis<!--end-reviewers-list-- Archive: Pending

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/1547b20490a54135a20403c97cad6570"><img src="https://joss.theoj.org/papers/1547b20490a54135a20403c97cad6570/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/1547b20490a54135a20403c97cad6570/status.svg)](https://joss.theoj.org/papers/1547b20490a54135a20403c97cad6570)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@gartavanis, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @kellyrowland know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

@gartavanis, please create your checklist typing: @editorialbot generate my checklist

editorialbot commented 21 hours ago

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 21 hours ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.22 s (1182.4 files/s, 313296.2 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
C/C++ Header                    49           2854           3327          15094
C++                             69           2031           1857          12100
Python                          73           3004           1615          10561
reStructuredText                32           3154           2979           5543
YAML                            17            362            184           1556
CMake                            9            245            286           1189
SVG                              2              0              0            854
Markdown                         5            159              0            465
TOML                             2             12              0             86
TeX                              1              7              0             64
JSON                             1              0              0             32
Bourne Shell                     1              5             12             27
INI                              1              0              0             22
CSS                              1              0              0              3
-------------------------------------------------------------------------------
SUM:                           263          11833          10260          47596
-------------------------------------------------------------------------------

Commit count by author:

   111  Anders Reenberg Andersen
     6  Jesper Fink Andersen
     2  jesperfink
editorialbot commented 21 hours ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

βœ… OK DOIs

- 10.1002/9780470316887 is OK
- 10.1016/j.ejor.2021.07.007 is OK

🟑 SKIP DOIs

- No DOI given, and none found for title: Maintenance optimization for multi-component syste...
- No DOI given, and none found for title: pymdptoolbox
- No DOI given, and none found for title: Markov Decision Processes (MDP) Toolbox
- No DOI given, and none found for title: createMDP (Matlab)
- No DOI given, and none found for title: POMDPs.jl: A Framework for Sequential Decision Mak...

❌ MISSING DOIs

- 10.32614/cran.package.mdptoolbox may be a valid DOI for title: MDPtoolbox: Markov Decision Processes Toolbox

❌ INVALID DOIs

- None
editorialbot commented 21 hours ago

Paper file info:

πŸ“„ Wordcount for paper.md is 724

βœ… The paper includes a Statement of need section

editorialbot commented 21 hours ago

License info:

βœ… License found: MIT License (Valid open source OSI approved license)

editorialbot commented 21 hours ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left: