search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
721 stars 38 forks source link

[REVIEW]: Salabim: discrete event simulation and animation in Python #767

Closed whedon closed 6 years ago

whedon commented 6 years ago

Submitting author: @salabim (Ruud van der Ham) Repository: https://github.com/salabim/salabim Version: 2.2.23 Editor: @danielskatz Reviewer: @gonsie, @pspringer Archive: 10.6084/m9.figshare.6791129

Status

status

Status badge code:

HTML: <a href="http://joss.theoj.org/papers/225837fff5f6f153660cd05044cd4267"><img src="http://joss.theoj.org/papers/225837fff5f6f153660cd05044cd4267/status.svg"></a>
Markdown: [![status](http://joss.theoj.org/papers/225837fff5f6f153660cd05044cd4267/status.svg)](http://joss.theoj.org/papers/225837fff5f6f153660cd05044cd4267)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@gonsie & @pspringer, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

  1. Make sure you're logged in to your GitHub account
  2. Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @danielskatz know.

Review checklist for @gonsie

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Software paper

Review checklist for @pspringer

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Software paper

danielskatz commented 6 years ago

The merge of my pull request for the bib file did not work - I think you merged into the patch, rather than into the master. Here's what I think the file should contain:


@book{Matloff:2013,
    author = {Matloff, Norm},
    title = {Introduction to Discrete-Event Simulation and the SimPy Language},
    year = 2013,
    note = {Available from \url{http://heather.cs.ucdavis.edu/~matloff/156/PLN/DESimIntro.pdf}, Accessed 2018-07-04}
    }
@book{Robinson:2004,
    author = {Robinson, Stewart},
    title = {Simulation – The practice of model development and use},
    publisher={Wiley},
    year = 2013
    }
@book{Page:2005,
    author = {Bernd Page and Wolfgang Kreutzer},
    title = {Simulating Discrete Event Systems},
    publisher={Shaker Verlag},
    year = 2005
    }
@book{Lutz:2014,
    author = {Mark Lutz},
    title = {Python Pocket Reference}, 
    publisher = {O'Reilly},
    year = 2014
    }```
salabim commented 6 years ago

I have now put a new paper.bib, with your contents on the master branch.

Does it work now?

From: Daniel S. Katz notifications@github.com Sent: Wednesday, July 4, 2018 8:16:32 PM To: openjournals/joss-reviews Cc: salabim; Mention Subject: Re: [openjournals/joss-reviews] [REVIEW]: Salabim: discrete event simulation and animation in Python (#767)

The merge of my pull request for the bib file did not work - I think you merged into the patch, rather than into the master. Here's what I think the file should contain:

@bookhttps://github.com/book{Matloff:2013, author = {Matloff, Norm}, title = {Introduction to Discrete-Event Simulation and the SimPy Language}, year = 2013, note = {Available from \url{http://heather.cs.ucdavis.edu/~matloff/156/PLN/DESimIntro.pdf}http://heather.cs.ucdavis.edu/%7Ematloff/156/PLN/DESimIntro.pdf%7D, Accessed 2018-07-04} } @bookhttps://github.com/book{Robinson:2004, author = {Robinson, Stewart}, title = {Simulation – The practice of model development and use}, publisher={Wiley}, year = 2013 } @bookhttps://github.com/book{Page:2005, author = {Bernd Page and Wolfgang Kreutzer}, title = {Simulating Discrete Event Systems}, publisher={Shaker Verlag}, year = 2005 } @bookhttps://github.com/book{Lutz:2014, author = {Mark Lutz}, title = {Python Pocket Reference}, publisher = {O'Reilly}, year = 2014 }

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/openjournals/joss-reviews/issues/767#issuecomment-402537804, or mute the threadhttps://github.com/notifications/unsubscribe-auth/Ac9rCzOgx6oMsksd2RoOOn68DEX8SvAuks5uDQaAgaJpZM4UdQqy.

danielskatz commented 6 years ago

@whedon generate pdf

whedon commented 6 years ago 
Attempting PDF compilation. Reticulating splines etc...
whedon commented 6 years ago

--> Check article proof :page_facing_up: <--

danielskatz commented 6 years ago

close

let's try changing the first entry to

@book{Matloff:2013,
    author = {Matloff, Norm},
    title = {Introduction to Discrete-Event Simulation and the Sim{P}y Language},
    year = 2013,
    url = {http://heather.cs.ucdavis.edu/~matloff/156/PLN/DESimIntro.pdf}
    }

Then you should be able to go to the GitHub Issue where the review is taking place (this one, https://github.com/openjournals/joss-reviews/issues/767), and type "@whedon generate pdf" a new comment to generate a new PDF.

salabim commented 6 years ago

@whedon generate pdf

whedon commented 6 years ago 
Attempting PDF compilation. Reticulating splines etc...
whedon commented 6 years ago

--> Check article proof :page_facing_up: <--

salabim commented 6 years ago

Got it!

From: Daniel S. Katz notifications@github.com Sent: Wednesday, July 4, 2018 8:29:09 PM To: openjournals/joss-reviews Cc: salabim; Mention Subject: Re: [openjournals/joss-reviews] [REVIEW]: Salabim: discrete event simulation and animation in Python (#767)

close

let's try changing the first entry to

@book{Matloff:2013, author = {Matloff, Norm}, title = {Introduction to Discrete-Event Simulation and the Sim{P}y Language}, year = 2013, url = {http://heather.cs.ucdavis.edu/~matloff/156/PLN/DESimIntro.pdf} }

Then you should be able to go to the GitHub Issue where the review is taking place (this one, #767https://github.com/openjournals/joss-reviews/issues/767), and type "@whedonhttps://github.com/whedon generate pdf" a new comment to generate a new PDF.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/openjournals/joss-reviews/issues/767#issuecomment-402539423, or mute the threadhttps://github.com/notifications/unsubscribe-auth/Ac9rCwmMfmK-aklYkBtf2DO3chUjS6sIks5uDQl1gaJpZM4UdQqy.

pspringer commented 6 years ago

@salabim, @danielskatz, the References section in paper.md is blank. Also, where is the link to the pdf version of the paper, other than whedon's "Check article proof"?

danielskatz commented 6 years ago

@pspringer - don't worry about the lack of references in the .md file, they are built automatically in the PDF from the .bib file. And the latest "Check article proof" is the most recent version of the pdf version.

pspringer commented 6 years ago

@danielskatz, @salabim, I've checked everything off on the list, it looks good.

gonsie commented 6 years ago

@salabim do any of the paper references have DOIs?

gonsie commented 6 years ago

@danielskatz I guess I'm done with my review. This submission meets the criteria for acceptance.

salabim commented 6 years ago

@whedon generate pdf

whedon commented 6 years ago 
Attempting PDF compilation. Reticulating splines etc...
whedon commented 6 years ago

--> Check article proof :page_facing_up: <--

salabim commented 6 years ago

@whedon generate pdf

whedon commented 6 years ago 
Attempting PDF compilation. Reticulating splines etc...
whedon commented 6 years ago

PDF failed to compile for issue #767 with the following error:

% Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed

0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 100 11 0 11 0 0 259 0 --:--:-- --:--:-- --:--:-- 261 Error reading bibliography ./paper.bib (line 18, column 1): unexpected "d" expecting space, ",", white space or "}" Error running filter pandoc-citeproc: Filter returned error status 1 Looks like we failed to compile the PDF

salabim commented 6 years ago

@whedon generate pdf

whedon commented 6 years ago 
Attempting PDF compilation. Reticulating splines etc...
whedon commented 6 years ago

--> Check article proof :page_facing_up: <--

salabim commented 6 years ago

@gonsie I have found one DOI and added it to the references (paper.bib).

danielskatz commented 6 years ago

@gonsie - Can you go ahead and check off the last box? The references are books which generally don't have DOIs.

gonsie commented 6 years ago

@danielskatz done.

danielskatz commented 6 years ago

👋 @arfon - can you take over for the last steps to accept this?

@pspringer and @gonsie - thanks for your work on your reviews!

arfon commented 6 years ago

@salabim - At this point could you make an archive of the reviewed software in Zenodo/figshare/other service and update this thread with the DOI of the archive? I can then move forward with accepting the submission.

salabim commented 6 years ago

@arfon The DOI of the figshare repository is 10.6084/m9.figshare.6791129

arfon commented 6 years ago

@whedon set 10.6084/m9.figshare.6791129 as archive

whedon commented 6 years ago

OK. 10.6084/m9.figshare.6791129 is the archive.

arfon commented 6 years ago

@gonsie, @pspringer - many thanks for your reviews and to @danielskatz for editing this submission ✨

@salabim - your paper is now accepted into JOSS and your DOI is https://doi.org/10.21105/joss.00767 :zap: :rocket: :boom:

whedon commented 6 years ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](http://joss.theoj.org/papers/10.21105/joss.00767/status.svg)](https://doi.org/10.21105/joss.00767)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.00767">
  <img src="http://joss.theoj.org/papers/10.21105/joss.00767/status.svg" alt="DOI badge" >
</a>

This is how it will look in your documentation:

DOI

We need your help!

Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following: