[REVIEW]: iml: An R package for Interpretable Machine Learning

whedon commented 6 years ago

Submitting author: @christophM (Christoph Molnar) Repository: https://github.com/christophM/iml Version: v0.5.2 Editor: @leeper Reviewer: @nhejazi Archive: 10.5281/zenodo.1299059

Status

Status badge code:

HTML: <a href="http://joss.theoj.org/papers/9e8466400de93f5aabfb999f23db5072"><img src="http://joss.theoj.org/papers/9e8466400de93f5aabfb999f23db5072/status.svg"></a>
Markdown: [![status](http://joss.theoj.org/papers/9e8466400de93f5aabfb999f23db5072/status.svg)](http://joss.theoj.org/papers/9e8466400de93f5aabfb999f23db5072)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@nhejazi, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

Make sure you're logged in to your GitHub account
Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @leeper know.

Review checklist for @nhejazi

Conflict of interest

[x] As the reviewer I confirm that I have read the JOSS conflict of interest policy and that there are no conflicts of interest for me to review this work.

Code of Conduct

[x] I confirm that I read and will adhere to the JOSS code of conduct.

General checks

[x] Repository: Is the source code for this software available at the repository url?
[x] License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
[x] Version: Does the release version given match the GitHub release (v0.5.2)?
[x] Authorship: Has the submitting author (@christophM) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?

Functionality

[x] Installation: Does installation proceed as outlined in the documentation?
[x] Functionality: Have the functional claims of the software been confirmed?
[x] Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

[x] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
[x] Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
[x] Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
[x] Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
[x] Automated tests: Are there automated tests or manual steps described so that the function of the software can be verified?
[x] Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

[x] Authors: Does the paper.md file include a list of authors with their affiliations?
[x] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
[x] References: Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?

whedon commented 6 years ago

Hello human, I'm @whedon. I'm here to help you with some common editorial tasks. @nhejazi it looks like you're currently assigned as the reviewer for this paper :tada:.

:star: Important :star:

If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿

To fix this do the following two things:

Set yourself as 'Not watching' https://github.com/openjournals/joss-reviews:

watching

You may also like to change your default settings for this watching repositories in your GitHub profile here: https://github.com/settings/notifications

notifications

For a list of things I can do to help you, just type:

@whedon commands

whedon commented 6 years ago

Attempting PDF compilation. Reticulating splines etc...

whedon commented 6 years ago

--> Check article proof :page_facing_up: <--

nhejazi commented 6 years ago

I've now completed a preliminary review of the iml R package -- @christophM, this looks really great! There are just a few outstanding items that require your attention before I can check off the remaining items required for the JOSS review. Please take a look at the two issues (on examples and on licensing/contributions) that provide specific details on what needs to be addressed. Feel free to let me know if I can provide any further information that might be helpful in completing this review.

leeper commented 6 years ago

@nhejazi Thank you for the very fast review!

@christophM Please address these issues when you get a chance and let me know when they're complete.

christophM commented 6 years ago

@nhejazi thank you for the review!

@leeper, @nhejazi I adressed and closed the issues (I was not sure whether to leave them open or close them. feel free to re-open if something is missing).

leeper commented 6 years ago

Great. @nhejazi Can you take another look and let me know about any new or continuing concerns?

nhejazi commented 6 years ago

Everything looks good to me! I've checked off the remaining review items.

leeper commented 6 years ago

Thanks, @nhejazi!

leeper commented 6 years ago

@christophM The review process is now complete. To finalize your submission and accept your paper in JOSS, we need two things. First, can you confirm that all references in your bibliography have a DOI (if one exists). It looks like a few of those papers should have DOIs.

Second, we need you to deposit a copy of your software repository (including any revisions made during the JOSS review process) with a data-archiving service. To do so:

Create a GitHub release of the current version of your software repository
Deposit that release with Zenodo, figshare, or a similar DOI issuer.
Post a comment here with the DOI for the release.

christophM commented 6 years ago

I went through the references and updated the DOIs, wherever I found one.

christophM commented 6 years ago

@whedon commands

whedon commented 6 years ago

Here are some things you can ask me to do:

# List all of Whedon's capabilities
@whedon commands

# Assign a GitHub user as the sole reviewer of this submission
@whedon assign @username as reviewer

# Add a GitHub user to the reviewers of this submission
@whedon add @username as reviewer

# Remove a GitHub user from the reviewers of this submission
@whedon remove @username as reviewer

# List of editor GitHub usernames
@whedon list editors

# List of reviewers together with programming language preferences and domain expertise
@whedon list reviewers

# Change editorial assignment
@whedon assign @username as editor

# Set the software archive DOI at the top of the issue e.g.
@whedon set 10.0000/zenodo.00000 as archive

# Open the review issue
@whedon start review

🚧 🚧 🚧 Experimental Whedon features 🚧 🚧 🚧

# Compile the paper
@whedon generate pdf

christophM commented 6 years ago

@whedon generate pdf

whedon commented 6 years ago

Attempting PDF compilation. Reticulating splines etc...

whedon commented 6 years ago

--> Check article proof :page_facing_up: <--

christophM commented 6 years ago

Here is the DOI:

https://doi.org/10.5281/zenodo.1299059

leeper commented 6 years ago

@whedon set 10.5281/zenodo.1299059 as archive

whedon commented 6 years ago

OK. 10.5281/zenodo.1299059 is the archive.

leeper commented 6 years ago

@arfon over to you

arfon commented 6 years ago

@nhejazi - many thanks for your review here and to @leeper for editing this submission ✨

@christophM - your paper is now accepted into JOSS and your DOI is https://doi.org/10.21105/joss.00786 :zap: :rocket: :boom:

whedon commented 6 years ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippet:

[![DOI](http://joss.theoj.org/papers/10.21105/joss.00786/status.svg)](https://doi.org/10.21105/joss.00786)

This is how it will look in your documentation:

We need your help!

Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: http://joss.theoj.org/reviewer-signup.html
Making a small donation to support our running costs here: https://www.flipcause.com/secure/cause_pdetails/Mjk3Nzk=

christophM commented 6 years ago

@arfon @nhejazi @leeper Thanks for the smooth and pleasant process!

christophM commented 6 years ago

Hi @arfon, I just talked to @leeper about the possibilty to add an author to the paper after publishing. When I wrote the paper, I (falsely) assumed that only code contributors can be authors.

It would be really great if I could update the paper with authors that also contributed conceptually.

@leeper mentioned that it might be possible. @arfon is it possible to update the list of authors?

Thanks for your efforts!

arfon commented 6 years ago

@arfon is it possible to update the list of authors?

Yes, please update the paper.md in your master branch of the repository and give me a shout when you've done so.

christophM commented 6 years ago

Thanks @arfon. I updated the paper.md in the master. Let me know if there are any more actions I have to take.

arfon commented 6 years ago

I updated the paper.md in the master. Let me know if there are any more actions I have to take.

👍 this should be updated on the JOSS site now. It can take a few hours to update due to caching.

christophM commented 6 years ago

Great, thanks a lot!

openjournals / joss-reviews