Closed whedon closed 6 years ago
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @miykael it looks like you're currently assigned as the reviewer for this paper :tada:.
:star: Important :star:
If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿
To fix this do the following two things:
For a list of things I can do to help you, just type:
@whedon commands
Attempting PDF compilation. Reticulating splines etc...
Hi @miykael, the docs website is ready for you to provide a sense of what it is. I am finalizing the implementation for one another class Carpet, but what it is now should give you a very good sense of what's happening.
It should be ready now, I believe.
Perfect! I have a conference and workshop coming up in the next 10 days but will start reviewing in the time between and finalize the review shortly after.
No problem. I plan to add an example notebook for Carpet
class shortly, the docs already (API etc) should give you a good idea.
@raamana : is this ready for a review? It seems like you are still working on some things?
Yes it is. Sorry I should have made that explicit.
@miykael: have you had a chance to take a look?
@arokem and @raamana I apologize for my late reply, I had an unforeseen hectic two weeks. But the review has now my full attention!
The software looks very good and useful and I will write my full review in the issue tracker of https://github.com/raamana/mrivis. But I think the repo is missing a paper.md
file (as mentioned
in the author guidlines), or is this optional?
thanks - looking fwd to learn your comments.
its in the docs folder, as required : https://github.com/raamana/mrivis/blob/master/docs/paper.md
@raamana and @arokem - my review can be found under https://github.com/raamana/mrivis/issues/11. @raamana, don't hesitate to ask for clarification!
@arokem - the review under https://github.com/raamana/mrivis/issues/11 is finished. @raamana corrected all relevant issues and the software is in my opinion ready for publication. What are the next steps?
Thanks Michael for a thorough and a helpful review, appreciate it.
Ariel, this is the final DOI for this version: 10.5281/zenodo.1443427
Just pushed the latest code to pypi also! :)
Thanks @miykael for the excellent review! 👏 Your work is done here...
@whedon set 10.5281/zenodo.1443427 as archive
OK. 10.5281/zenodo.1443427 is the archive.
@raamana : sorry - a couple of things I noticed about your article just now:
The title is not capitalized. I don't think that you want every word in the title to be capitalized, but the very first word probably should be. Also, the title currently doesn't include the name of the software library. I would recommend adding that.
The references do not have DOIs. Please add these.
@whedon generate pdf
Attempting PDF compilation. Reticulating splines etc...
@whedon generate pdf
Attempting PDF compilation. Reticulating splines etc...
Good catch - fixed them now.
Thanks for doing that. Would you mind creating a new Zenodo DOI?
Sure - it is 10.5281/zenodo.1450944
@whedon set 10.5281/zenodo.1450944 as archive
OK. 10.5281/zenodo.1450944 is the archive.
@arfon : I believe that this paper is ready to be accepted!
@miykael - many thanks for your review here and to @arokem for editing this submission ✨
@raamana - your paper is now accepted into JOSS and your DOI is https://doi.org/10.21105/joss.00897 :zap: :rocket: :boom:
:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:
If you would like to include a link to your paper from your README use the following code snippets:
Markdown:
[![DOI](http://joss.theoj.org/papers/10.21105/joss.00897/status.svg)](https://doi.org/10.21105/joss.00897)
HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.00897">
<img src="http://joss.theoj.org/papers/10.21105/joss.00897/status.svg" alt="DOI badge" >
</a>
reStructuredText:
.. image:: http://joss.theoj.org/papers/10.21105/joss.00897/status.svg
:target: https://doi.org/10.21105/joss.00897
This is how it will look in your documentation:
We need your help!
Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
Submitting author: @raamana (Pradeep Reddy Raamana) Repository: https://github.com/raamana/mrivis Version: 0.3 Editor: @arokem Reviewer: @miykael Archive: 10.5281/zenodo.1450944
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@miykael, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @arokem know.
✨ Please try and complete your review in the next two weeks ✨
Review checklist for @miykael
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?