openjournals / joss

The Journal of Open Source Software
https://joss.theoj.org
MIT License
1.55k stars 187 forks source link

Bad software URL in old paper #1293

Closed danielskatz closed 11 months ago

danielskatz commented 1 year ago

As noticed by @sdruskat in https://github.com/openjournals/joss-reviews/issues/1760#issuecomment-1801327582, the software repo for the software in https://doi.org/10.21105/joss.01777 is entered as github.com/rmsare/pymccrgb rather than the correct https://github.com/rmsare/pymccrgb which causes the link to be treated as local and not to work.

Can this be fixed in our metadata, and then can the metadata be re-issued?

xuanxu commented 1 year ago

Fixed!

sdruskat commented 1 year ago

@xuanxu & @danielskatz Sorry for the postscript, but I found two more of the same errors in the current complete set of published papers:

danielskatz commented 1 year ago

Thanks for finding these. I hope @xuanxu can fix them fairly easily.

@xuanxu - do you think this is something we should be checking for in the generate pdf processing?

xuanxu commented 11 months ago

Fixed! From now on the JOSS site doesn't allow relative URLs for new submissions.