openjournals / joss

The Journal of Open Source Software
https://joss.theoj.org
MIT License
1.55k stars 187 forks source link

`papers/by/AUTHOR` page doesn't work for names containing period characters #1346

Closed kandersolar closed 3 months ago

kandersolar commented 5 months ago

On the page for published papers, the list of author names in the side bar is hyperlinked to a page listing all publications by each author. However, that page seems broken (HTTP 406) for author names containing a period, at least on Chrome -- I observe no issues with Firefox.

Here is an example:

Deleting the "." in the URL gets it working for me.

sneakers-the-rat commented 3 months ago

Can replicate in local development server. getting a 306 Not acceptable, "ActionController::UnknownFormat in PapersController#filter" right here: https://github.com/openjournals/joss/blob/4cd24daa5176eb8b4f6d7ecb0a93133b9cddc0ca/app/controllers/papers_controller.rb#L136

Chrome doesn't URL encode the . as %2E while firefox does.