Closed danielskatz closed 2 months ago
See https://github.com/openjournals/inara/issues/71 and https://github.com/openjournals/inara/pull/72. I was also thinking about this
Thanks very much @cthoyt for your good and complete work!
@cthoyt & @xuanxu - We're now having problems accepting papers - see https://github.com/openjournals/joss-reviews/issues/6917#issuecomment-2331099794 for example. Is this problem tied to the ROR-related change?
looking at it now. will give an update in 20-30 minutes
See https://github.com/openjournals/inara/pull/77, I think I've got a solution
👋 @xuanxu & @arfon - Can either of you check this and then potential merge it if that seems appropriate?
@cthoyt @tarleb – looks like we have a paper using RORs (yay!), but the paper formatting looks pretty janky (see the spacing between affiliations text): https://github.com/openjournals/joss-papers/blob/joss.07377/joss.07377/10.21105.joss.07377.pdf
Any thoughts on how this could be potentially improved?
yay! and, oh no!
I think this is an artifact of how I turned the ROR SVG into the latex commands. This was a bit of oversight on my part not trying with a more involved author list, but unfortunately when I was making changes to Inara, the diffs were very big and unruly, and I tried to minimize the document changes. I will take a second pass at this, and see if the bounding boxes in the latex commands can be adjusted :)
hi @arfon, thanks for being patient. I hope I wasn't holding up the daily JOSS grind. I've got a fix in https://github.com/openjournals/inara/pull/90 :)
hi @arfon, we've merged the fix and made a new 1.1.2 release of Inara that includes it
JOSS should make use of the new version once this PR is merged: https://github.com/xuanxu/publishing-artifacts-action/pull/1
Merged!
Maybe there's still room for improvement on the vertical positioning and left padding, but this is looking much better already!
Maybe there's still room for improvement on the vertical positioning and left padding, but this is looking much better already!
😻
If JOSS asked authors to use RORs to indicate their affiliations, we could pass them to Crossref and be a better member of the community, and it would also be easier for us to understand our authors.
We could also use RORs for editors and reviewers.