openjournals / joss

The Journal of Open Source Software
https://joss.theoj.org
MIT License
1.55k stars 187 forks source link

Titles in ToC #1379

Closed sneakers-the-rat closed 3 weeks ago

sneakers-the-rat commented 3 weeks ago

Partial fix of: https://github.com/openjournals/joss/issues/1377

Cool! learned how to use yield and content_for in rails templates.

Screenshot 2024-10-23 at 1 19 19 PM

Should keep page title the same if there is no title provided, and otherwise be {title} - Journal of Open Source Software

Put the page name first because i don't think i'm alone in having my tabs often looking like this

Screenshot 2024-10-23 at 1 20 21 PM
danielskatz commented 3 weeks ago

I wonder if these should be "JOSS: {title}"? I kind of like the JOSS ones to be together in my menu/list...

sneakers-the-rat commented 3 weeks ago

we can do whatever we want!

I'm looking at just my tabs right now, and all of them are {page title} - {site title}

Screenshot 2024-10-23 at 1 34 34 PM

So that is the norm, and then the favicon handles the grouping -- maybe your tab hygeine is better than mine ;)

Another thing is SEO, where having the full name in the page title is good (SEO can be a bit of mythology sometimes, so it may not matter that much if it's also in the header metadata), and JOSS: {page title} - Journal of Open Source Software is a little awkward.

but ya not strongly opinionated, just a frequent too-many-tabs-open-haver

danielskatz commented 3 weeks ago

I hate to admit this, but I don't use tabs, I use windows, and I choose them from a menu that lists them in alphabetical order...

sneakers-the-rat commented 3 weeks ago

to each their own, but yes ha i think that might be a relatively rare use pattern ;). I don't think four characters would be the end of the world, just a little nonstandard. the SEO question is really the only materially differentiating factor.

Interestingly enough, duckduckgo is filling this in for us even without having a page title:

Screenshot 2024-10-23 at 2 16 48 PM