Github Action failing to create JOSE draft

openjournals / openjournals-draft-action

Experimental GitHub Action

MIT License

53 stars 12 forks source link

Github Action failing to create JOSE draft #11

Closed AlexanderJuestel closed 2 years ago

AlexanderJuestel commented 2 years ago

Hello,

I am trying to create a draft for the JOSE Journal using the following workflow adapted from https://github.com/marketplace/actions/open-journals-pdf-generator:

https://github.com/cgre-aachen/gemgis_data/blob/main/.github/workflows/draft-pdf.yml

I copied the workflow and adapted it from a JOSS paper where the workflow worked as planned. However, with JOSE it is failing, see for example https://github.com/cgre-aachen/gemgis_data/actions/runs/2084732180

Some advice would be highly appreciated on what is wrong. Have a good weekend and thanks in advance.

Cheers Alex

tarleb commented 2 years ago

Thanks for the report, I'll take a look.

tarleb commented 2 years ago

I identified two issue:

There are some spurious dashes and extra-spaces in the metadata, which confuse the YAML parser.
The use of BibTeX commands like \citep is not supported; replacing these with Markdown markup allows the paper to compile.

I'll open a PR to your repo with the necessary fixes.

AlexanderJuestel commented 2 years ago

@tarleb I remember that I edited the metadata but must have mixed up some of the dashes and spaces. Thanks for spotting that. Also thanks for the hints with the markdown markup. I will also change that in our JOSS draft!

Closing the issue as it was fixed with https://github.com/cgre-aachen/gemgis_data/pull/2

tarleb commented 2 years ago

Happy to hear it worked :)

AlexanderJuestel commented 2 years ago

@tarleb, sorry to bother you again but somehow I managed to break the draft once again. I added an orcid number for the second author and changed some Information in the affiliations and now it is not compiling once again: https://github.com/cgre-aachen/gemgis_data/actions/runs/2467336434

I made sure that all spaces and dashes are correct as you mentioned that before.

The draft is stored here: https://github.com/cgre-aachen/gemgis_data/tree/main/jose

Thanks for your help!

tarleb commented 2 years ago

Sure. In line 31, the value must be quoted as the affiliation contains a colon. Cheers!

AlexanderJuestel commented 2 years ago

Ai ai ai, that was it! Thanks for your prompt help! Learned something new again!