openjournals / theoj

The Open Journal
http://theoj.org
MIT License
129 stars 10 forks source link

Allow editors to delete papers #156

Closed freelanceastro closed 9 years ago

stuartlynn commented 9 years ago

Probably not delete but "hide" / mark as rejected right?

On Tue, 31 Mar 2015 at 16:30 Adam Becker notifications@github.com wrote:

— Reply to this email directly or view it on GitHub https://github.com/openjournals/theoj/issues/156.

marcrohloff commented 9 years ago

Maybe we should clarify the workflow?

I assume that a workflow would be something along the line of:

freelanceastro commented 9 years ago

This was intended simply to allow editors to delete accidental/multiple/spam submissions. It should only be possible before any reviewers are assigned.

The workflow is:

marcrohloff commented 9 years ago

Does 'delete' delete all versions or just one version? Can you delete only the most recent version? If so what happens to the previous version?

freelanceastro commented 9 years ago

Since this should only be possible in the "submitted" state, before reviewers are assigned, I think deleting a paper should delete all versions. The use case (for now, at least) is accidental or duplicate submission.

Also, not to make Stuart even more godlike, but I'm thinking that this power should really be limited to the admin account, at least for now. @stuartlynn, @arfon, do you agree?

marcrohloff commented 9 years ago

Should be done. Since this is intended for accidental or spam submissions it is currently a permanent deletion.

freelanceastro commented 9 years ago

I'm seeing this, but it's behaving the opposite of the way we want -- it only appears on papers that are past the "submitted" stage, rather than only appearing on papers that are in that stage.

marcrohloff commented 9 years ago

Should be fixed now.

freelanceastro commented 9 years ago

Yep, looks good.

marcrohloff commented 9 years ago

Done