[WIP] Polymer 1.0

[arfon]

Nothing much to see here so far. These changes are simply the result of running: find . -name "*.html" -execdir polyup --overwrite "{}" \; in app/assets/components.

[arfon]

@stuartlynn - this PR is the result of running the Polyup tool on the current code. It looks to have left (reasonably?) useful notes about what is likely to be broken at this stage.

Not sure if you're planning on looking at any of this over the weekend but I thought I'd let you know that Polyup has already done its stuff on this PR :smile:

[stuartlynn]

My plan was to run the polyup tool and go from there so thats cool thanks. Will let you know how far I get.

Cheers

On Sat, Jan 9, 2016 at 11:14 AM Arfon Smith notifications@github.com wrote:

@stuartlynn https://github.com/stuartlynn - this PR is the result of running the Polyup tool on the current code. It looks to have left (reasonably?) useful notes about what is likely to be broken at this stage.

Not sure if you're planning on looking at any of this over the weekend but I thought I'd let you know that Polyup has already done its stuff on this PR [image: :smile:]

— Reply to this email directly or view it on GitHub https://github.com/openjournals/theoj/pull/256#issuecomment-170256915.

Stuart Lynn Map Scientist

CartoDB—Map Your World's Data 143 Roebling St 2A, New York, 11211, USA T: +3123940797 Twitter: @stuart_lynn W: www.cartodb.com

Live sessions to learn CartoDB

[stuartlynn]

Ok so updated and resolved a few issues. Updated the polymer library and webcomponents, removed extra include tags that polyup included and have fixed a few bugs it introduced. Getting a lot of errors from the old polymer components. I think we are going to have to replace all the polymer components we used with their polymer 1.0 counterparts.

@marcrohloff where we handling the component installs with bower? I cant quiet remember. If so we might just be able to call update on a bunch of them but we might have to switch out a bunch by hand for the newer versions.

So for example we need to upgrade from core-ajax to iron-ajax https://elements.polymer-project.org/elements/iron-ajax . Not sure if polyup does this automatically when it finds import statements and we just don't have those because of the asset pipeline.

If we are using bower some of that might be possible to upgrade as follows https://github.com/PolymerLabs/polyup/blob/master/AfterUseGuide.md#bower

I cant see a bower file in the root dir and I cant remember how we where handling the dependancies.

[marcrohloff]

I wasn't using bower, I don't know if that has changed.

[stuartlynn]

Ok I am going to start swapping out components tonight. I might set up bower to install to the vendor directory and set up a bower.json file for the components so its easy to upgrade in future. Let me know if there are any objections

[arfon]

Ok I am going to start swapping out components tonight. I might set up bower to install to the vendor directory and set up a bower.json file for the components so its easy to upgrade in future. Let me know if there are any objections

Sounds good to me.

[arfon]

@stuartlynn - did you make any further progress on this? I believe @marcrohloff is going to try and chip in this week so it would be good to get a status update from you.

[marcrohloff]

wrt to the title overflow/ellipses. The overflow:ellipses options does not, unfortunately, work with multiline text only with single line. There is nothing in Polymer to do the ellipses. You can truncate at n characters but that is tricky with non-fixed width fonts. There are also some jQuery add-ins that do the ellipses. I have just found them to be unreliable. Probably because I have my screen scaled. The last option I've seen is to fade out the last line.

https://css-tricks.com/line-clampin/

[marcrohloff]

I'll merge this for now. Just so that we are all clear - we are now working off the master branch.

[marcrohloff]

Also I'm creating a polymer-0.5 branch with the old code for posterity aka reference