search

openjournals / theoj

The Open Journal
http://theoj.org
MIT License
129 stars 10 forks source link

Stubbing out static homepage #276

Closed arfon closed 7 years ago

arfon commented 7 years ago

Current status:

screen shot 2017-01-02 at 2 37 41 pm

marcrohloff commented 7 years ago

Don't we want to do this as a Polymer page? It will make it much easier to keep the look and feel consistent (especially with the toolbar)

arfon commented 7 years ago

Don't we want to do this as a Polymer page? It will make it much easier to keep the look and feel consistent (especially with the toolbar)

Possibly. I've been thinking though that we should consider only using Polymer for the review UI and using Rails templates for the rest of the application. I realize this will be an additional overhead to maintain the styles but there's not a huge amount shared (other than the top menu).

arfon commented 7 years ago

Let's chat about this when we talk later this week.

marcrohloff commented 7 years ago

If we go this route then we should move the toolbar to the server side layout and just render the review control in an inner div. The one downside is that Polymer deals with the sorting of the paper lists for us. We will need to find another solution to do that, either server or client side.

arfon commented 7 years ago

If we go this route then we should move the toolbar to the server side layout and just render the review control in an inner div.

That sounds like a good idea.

BTW, I was planning on leaving this PR open for a while until I'd finished up building the front page but I'm happy to keep pushing to this branch (and opening new PRs as I progress) - happy to do whatever you prefer @marcrohloff