openjournals / theoj

The Open Journal
http://theoj.org
MIT License
129 stars 10 forks source link

Should be possible to select text when annotating #34

Open arfon opened 9 years ago

arfon commented 9 years ago

Currently it's not. Looks like some smart folks have figured this out though:

stuartlynn commented 9 years ago

Started implementing this in this pull request.

https://github.com/openjournals/theoj/pull/41

I think its not working because of some PDF.js version issues

freelanceastro commented 9 years ago

Might the fix from #38 work here too?

marcrohloff commented 9 years ago

There were definitely issues I noticed while doing this that need affect this issue. There are several levels of scaling involved that I haven't quite figured out how to resolve (scaling between the pdf and the canvas as well as between the canvas and the ui (pixels) )

arfon commented 9 years ago

@stuartlynn @marcrohloff it looks like there are some people attempting to solve this problem here: https://groups.google.com/forum/#!topic/mozilla.dev.pdf-js/usjv3igacCg & http://www.google.com/url?q=http%3A%2F%2Ftech.chitgoks.com%2F2015%2F03%2F30%2Fhow-to-create-annotations-in-pdf-js%2F&sa=D&sntz=1&usg=AFQjCNGoGkwU2JR5BXqAy1mlzNw4mqo1NA