openjs-foundation / summit

Organizing a Collaborator Summit
144 stars 58 forks source link

Session Proposal: Node.js ESM and async_hooks, brainstorm / identify the spurious promises. #340

Closed mcollina closed 2 years ago

mcollina commented 2 years ago

Proposal

Topic of the session

Type of the session

Estimated duration of the session

1 hour / Open

Date and Time of the session

Level

Pre-requisite knowledge

async_hooks ESM

Describe the session

In https://github.com/nodejs/node/pull/44323#issuecomment-1230508612, @GeoffreyBooth and myself have tried to identify where the promises that are not tracked by async_hooks are created, so that we can:

  1. clarify that there are no bugs using ESM+async_hooks, as those promise chains do not lead to user code being run.
  2. clarify what bug this is causing so we can fix them

Session facilitator(s), Github handle(s) and timezone(s)

@mcollina (@GeoffreyBooth remotely)

Meeting notes and Virtual Meeting Link

Follow-up / Set-up sessions (if any)

Additional context (optional)


GeoffreyBooth commented 2 years ago

See also: https://github.com/nodejs/node/pull/44323#issuecomment-1258743982

WaleedAshraf commented 2 years ago

added in the schedule. Let me know if you have a preference for a time slot. https://docs.google.com/spreadsheets/d/1WJpK6ZD43GaI-h-HOuHnG0DmQ8orkxFLbYJ_jUiXX54/edit#gid=0

GeoffreyBooth commented 2 years ago

What's the time of this session, in UTC? I'm confused by the spreadsheet, as the timezone it lists I think isn't Ireland time?

Also the Zoom link please.

targos commented 2 years ago

I think it's 1400 in UTC.

WaleedAshraf commented 2 years ago

The schedule is in Ireland time. Sorry for the confusion. @GeoffreyBooth

targos commented 2 years ago

Zoom:

WaleedAshraf commented 2 years ago

Here are the recordings.

I've also added the recording links in the schedule sheet. Sorry, we couldn't record the sessions in the second room. Hopefully next time we'll prepare better.

I'll close this issue as the event has passed. Thanks, everyone for being part of it and for the support.