search

openjump-gis / openjump

OpenJUMP, the Open Source GIS with more than one trick in its kangaroo pocket, takes the leap from svn to git. join the effort!
http://openjump.org
GNU General Public License v2.0
29 stars 14 forks source link

Improve layerable hierarchy #3

Closed edeso closed 3 years ago

edeso commented 3 years ago

from Mike via Re: [JPP-Devel] OpenJUMP 2 refactoring layerable hierarchy

a rather big change in improve_layerable_hierarchy branch

Main modifications are : 1/ introduction of GeoReferencedLayerable, abstract class extending AbstractLayerable and wrapping Blackboard, Envelope and SRSInfo implemented by

2/ elimination of WorkbenchContext reference in many classes and constructors related to RasterImageLayer (trying to follow OOP principles like encapsulation or separation of concerns)

I did not check if It still works with Sextante or OpenKlem though.

Let me know if you think it can be merged as is or if it needs tests with some particular extensions

before being merge.

edeso commented 3 years ago

hey Mike,

just opened a pull request so we can discuss the changeset properly :)

two issues:

  1. let's test it with "legacy" extensions and maybe simply keep old constructors marked deprecated. removing them will render a lot of code dead and already have the JTS upgrade backlog.
  2. please squash all your changes into a single commit before the next pul request, so it'll appear as one changeset later.

just comments, didn#t test nothing.. regards ede