Closed ma15569 closed 1 year ago
yeah. no. that looks wrong. you seem to have based your changes on some outdated 'heatmap' branch.
better start with branch main of a current clone/fork. read here e.g. https://www.freecodecamp.org/news/how-to-make-your-first-pull-request-on-github-3/ they do it step by step .
I Ede, the info you sent me seems available only for Linux ( I actually use windows). Anyhow I don't understand if the pull request I did some hours ago was Ok or not:
[image: immagine.png]
Il giorno mer 30 nov 2022 alle ore 14:20 edeso @.***> ha scritto:
Closed #76 https://github.com/openjump-gis/openjump/pull/76.
— Reply to this email directly, view it on GitHub https://github.com/openjump-gis/openjump/pull/76#event-7922019159, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQSYPM46Y6PRETDZI2SFNQTWK5IBNANCNFSM6AAAAAASOWVT3E . You are receiving this because you authored the thread.Message ID: @.***>
@ma15569 well the steps are generally the same, on any platform. it was just the first example i could find. fell free to search for yourself ;)
wrt. to your other PR. i added comments in there and renamed to a speaking title. please read and adapt there.
Ok. I will try with GitHub Desktop, tomorrow Peppe
Il giorno mer 30 nov 2022 alle ore 17:22 edeso @.***> ha scritto:
@ma15569 https://github.com/ma15569 well the steps are generally the same, on any platform. it was just the first example i could find. fell free to search for yourself ;)
wrt. to your other PR https://github.com/openjump-gis/openjump/pull/77. i added comments in there and renamed to a speaking title. please read and adapt there.
— Reply to this email directly, view it on GitHub https://github.com/openjump-gis/openjump/pull/76#issuecomment-1332421200, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQSYPM36VPYYT3G3NS7HVQDWK55NJANCNFSM6AAAAAASOWVT3E . You are receiving this because you were mentioned.Message ID: @.***>
well,
normally you would use probably Eclipse and egit (Eclipse git integration), but as the changes are fairly simple you can do them online as well. just go to your branch that is connected to the Pull Request https://github.com/ma15569/openjump/tree/patch-10
click the file you want to edit, then on the right top there is a 'Pencil icon' (edit mode) edit commit et'voila ;)
good luck! ..ede
On 30.11.2022 17:25, ma15569 wrote:
Ok. I will try with GitHub Desktop, tomorrow Peppe
Il giorno mer 30 nov 2022 alle ore 17:22 edeso @.***> ha scritto:
@ma15569 https://github.com/ma15569 well the steps are generally the same, on any platform. it was just the first example i could find. fell free to search for yourself ;)
wrt. to your other PR https://github.com/openjump-gis/openjump/pull/77. i added comments in there and renamed to a speaking title. please read and adapt there.
— Reply to this email directly, view it on GitHub https://github.com/openjump-gis/openjump/pull/76#issuecomment-1332421200, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQSYPM36VPYYT3G3NS7HVQDWK55NJANCNFSM6AAAAAASOWVT3E . You are receiving this because you were mentioned.Message ID: @.***>
— Reply to this email directly, view it on GitHub https://github.com/openjump-gis/openjump/pull/76#issuecomment-1332425351, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACMDSQL6X67S5AGYRASY2SDWK55ZJANCNFSM6AAAAAASOWVT3E. You are receiving this because you modified the open/close state.Message ID: @.***>