search

openjusticeok / ojodb

OJO's R package for opening the black box of our justice system
https://openjusticeok.github.io/ojodb/
GNU General Public License v3.0
8 stars 3 forks source link

Data pull spinner #139

Closed brancengregory closed 1 year ago

brancengregory commented 1 year ago

@andrewjbe Note the documentation of DBI::dbGetRowCount. The purpose is to get the number of rows that have been fetched in total from dbFetch so far, not to get the total number of rows that will be in the result set

andrewjbe commented 1 year ago

I updated the documentation to accommodate the ... and .con we added to ojo_check_ssl() and ojo_search_minutes(), and I also updated the pkgdown to include the new functions ojo_collect(), ojo_version(), and skip_if_no_db(). Also removed dplyr from depends since you can just use ojo_collect() now

brancengregory commented 1 year ago

Let's add dplyr back in since you will never not be mutating/filtering/etc.! @andrewjbe

brancengregory commented 1 year ago

We just need to write some tests and then this looks good for review!