openkfw / Oscar

A digital decision support system for humanitarian operations
https://www.oscarplatform.org/
GNU General Public License v3.0
11 stars 1 forks source link

geodata with only apiUrl for already existing path #142

Closed bariela closed 1 year ago

bariela commented 1 year ago

Description

Removed condition for collectionName in geodata config, so the geodata can be defined by "apiUrl" to already existing collection and data by just url

Motivation and Context

Came across usecase, where I've got existing db collection

How has this been tested?

Screenshots (if appropriate):

Types of changes

Checklist:

srezacova commented 1 year ago

https://github.com/openkfw/Oscar/blob/e646b217598dd01e08c823edf38aad7fb46f5d41/initial-data-load/src/mapLayers/layersGeoDataUpload.ts#L81 Hi, is it necessary to have this line here now? If data.apiUrl exist, we have already set it. If not, undefined will be returned even without this line.

bariela commented 1 year ago

https://github.com/openkfw/Oscar/blob/e646b217598dd01e08c823edf38aad7fb46f5d41/initial-data-load/src/mapLayers/layersGeoDataUpload.ts#L81

Hi, is it necessary to have this line here now? If data.apiUrl exist, we have already set it. If not, undefined will be returned even without this line.

true, good catch!