openkfw / open-geodata-model

Open Geodata Model for Mapping Project Sites in ODA
https://openkfw.github.io/open-geodata-model/
Other
4 stars 8 forks source link

Use external dac codes #71

Closed fretchen closed 4 months ago

fretchen commented 4 months ago

This is a first step to test the compatibility of the lists.

Quite interestingly it is directly running into troubles.

Approach

The DAC codes are pull from this source. Then we look within the template for all the existing codes.

1. Issue: Missing codes

There is a substantial amount of codes that are missing. Some examples of missing codes:

the code 11321 is not present in the template the code 11322 is not present in the template the code 15120 is not present in the template the code 15140 is not present in the template the code 15161 is not present in the template the code 15162 is not present in the template the code 15163 is not present in the template the code 15164 is not present in the template

2. Issue: Voluntary codes

The row voluntary codes is only present within the template. But no row like this present within the official reference.

@Maja4Dev any idea on what might be going on here ?

Maja4Dev commented 4 months ago

Regarding the codes from the original DAC source you cited in your comment above @fretchen: all the codes mentioned by you are marked as "withdrawn" there - which means they have basically been eliminated from the original source and we dont need them either.

Regarding the DAC codes marked as "voluntary codes" in our template -> they are all part of the he original DAC sources you cited, only without being tagged as "voluntary". I guess this was maybe voluntary some time ago. For our purposes, we don't need this "voluntary" tag, so we can just make reference to this source.

fretchen commented 4 months ago

@Maja4Dev your comments fixed the problem indeed. So as a summary of this PR:

An open question for the future is if we would like to go the next step and fully generate the worksheet from the external json. I do not see this as high priority so I would propose to park it for the moment...

Looking forward to your comments @Maja4Dev.