openkfw / open-geodata-model

Open Geodata Model for Mapping Project Sites in ODA
https://openkfw.github.io/open-geodata-model/
Other
4 stars 8 forks source link

Add location types reference #73

Closed fretchen closed 4 months ago

fretchen commented 4 months ago

The initial commits of this PR were done by Co-Pilot. They failed.

fretchen commented 4 months ago

I had a look through the situation and now think that I have a working proposition on how to have a good and flexible reference for the location types:

Some things where this solution helps:

Some open points if we like this solution:

@Maja4Dev and @Jo-Schie I would be curious about your comments and would only finish this up if you guys give a green light.

P.S.: FWIW. The whole process is also working nicely with the kfw_location_types.json file, whose content is identical to the content of the xlsx. But the xlsx is nicer to manipulate for translations in the future, which is why I would like to keep both as the json is easier machine readable. I would most likely add a simple script which automatically converts the xlsx to json...

fretchen commented 4 months ago

Dear @Maja4Dev and @Jo-Schie the PR is now ready for review. Main points are:

All other changes are IMHO minor.

fretchen commented 4 months ago

reviewed and discussed with @Jo-Schie and @Maja4Dev