Closed fretchen closed 4 months ago
I had a look through the situation and now think that I have a working proposition on how to have a good and flexible reference for the location types:
kfw_location_types.xlsx
subsector
, character
, code
, name
, name_de
, geometry
, category
, description
, description_fr
. Location Types IATI and New
worksheet in the french and english version of the template.Some things where this solution helps:
Some open points if we like this solution:
@Maja4Dev and @Jo-Schie I would be curious about your comments and would only finish this up if you guys give a green light.
P.S.: FWIW. The whole process is also working nicely with the kfw_location_types.json file, whose content is identical to the content of the xlsx. But the xlsx is nicer to manipulate for translations in the future, which is why I would like to keep both as the json is easier machine readable. I would most likely add a simple script which automatically converts the xlsx to json...
Dear @Maja4Dev and @Jo-Schie the PR is now ready for review. Main points are:
kfw_location_types.xlsx
which contains the location_typeslocation_types.md
which contains the documentation for the location types and how the reference is connected to the templatestest_location_types.py
which contains units tests to ensure that the french and the english template contain all the necessary location types.All other changes are IMHO minor.
reviewed and discussed with @Jo-Schie and @Maja4Dev
The initial commits of this PR were done by Co-Pilot. They failed.