Please add 'test_requires' to setup.py

openkim / kliff

KIM-based Learning-Integrated Fitting Framework for interatomic potentials.

https://kliff.readthedocs.io

GNU Lesser General Public License v2.1

34 stars 20 forks source link

Please add 'test_requires' to setup.py #11

Open yurivict opened 3 years ago

yurivict commented 3 years ago

tests fail with:

ImportError: Failed to import test module: calculator_torch
...
ImportError: Failed to import test module: linear_regression
...
ImportError: Failed to import test module: model_torch
...
ImportError: Failed to import test module: nn
...

mjwen commented 3 years ago

Hi @yurivict. How did you get these errors, via python setup.py test? These modules based on PyTorch are not needed for the current tests. Also, we use pytest in this project instead of unittest.

yurivict commented 3 years ago

python setup.py test prints these messages.

mjwen commented 3 years ago

python setup.py test is deprecated:

$ python setup.py test
running test
WARNING: Testing via this command is deprecated and will be removed in a future version.

tests_require is also deprecated by setuptool. We'll add tests requirements to extras_require.

yurivict commented 3 years ago

Then README needs to say how to run tests.